From: Michal Hocko <mhocko@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
Johannes Weiner <hannes@cmpxchg.org>,
Joonsoo Kim <js1304@gmail.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Petr Mladek <pmladek@suse.cz>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH] mm: simplify node/zone name printing
Date: Mon, 19 Dec 2016 09:12:10 +0100 [thread overview]
Message-ID: <20161219081210.GA32389@dhcp22.suse.cz> (raw)
In-Reply-To: <20161219073228.GA1339@jagdpanzerIV.localdomain>
On Mon 19-12-16 16:32:28, Sergey Senozhatsky wrote:
[...]
> as far as I can tell, now for_each_populated_zone() iterations are
> split by non-CONT printk() from show_zone_node(), which previously
> has been printk(KERN_CONT "%s: ", zone->name), so pr_cont(\n)
> between iterations was important, but now that non-CONT printk()
> should do the trick. it's _a bit_ hacky, though.
Do you consider that more hacky than the original? At least for me,
starting with KERN_CONT and relying on an explicit \n sounds more error
prone than leaving the last pr_cont without \n and relying on the
implicit flushing.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
Johannes Weiner <hannes@cmpxchg.org>,
Joonsoo Kim <js1304@gmail.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Petr Mladek <pmladek@suse.cz>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH] mm: simplify node/zone name printing
Date: Mon, 19 Dec 2016 09:12:10 +0100 [thread overview]
Message-ID: <20161219081210.GA32389@dhcp22.suse.cz> (raw)
In-Reply-To: <20161219073228.GA1339@jagdpanzerIV.localdomain>
On Mon 19-12-16 16:32:28, Sergey Senozhatsky wrote:
[...]
> as far as I can tell, now for_each_populated_zone() iterations are
> split by non-CONT printk() from show_zone_node(), which previously
> has been printk(KERN_CONT "%s: ", zone->name), so pr_cont(\n)
> between iterations was important, but now that non-CONT printk()
> should do the trick. it's _a bit_ hacky, though.
Do you consider that more hacky than the original? At least for me,
starting with KERN_CONT and relying on an explicit \n sounds more error
prone than leaving the last pr_cont without \n and relying on the
implicit flushing.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2016-12-19 8:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 12:32 [PATCH] mm: simplify node/zone name printing Michal Hocko
2016-12-16 12:32 ` Michal Hocko
2016-12-19 7:00 ` Vlastimil Babka
2016-12-19 7:00 ` Vlastimil Babka
2016-12-19 7:32 ` Sergey Senozhatsky
2016-12-19 7:32 ` Sergey Senozhatsky
2016-12-19 8:12 ` Michal Hocko [this message]
2016-12-19 8:12 ` Michal Hocko
2016-12-19 8:27 ` Sergey Senozhatsky
2016-12-19 8:27 ` Sergey Senozhatsky
2016-12-19 10:27 ` Petr Mladek
2016-12-19 10:27 ` Petr Mladek
2016-12-19 14:03 ` Michal Hocko
2016-12-19 14:03 ` Michal Hocko
2016-12-19 10:05 ` Petr Mladek
2016-12-19 10:05 ` Petr Mladek
2016-12-19 13:20 ` Michal Hocko
2016-12-19 13:20 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161219081210.GA32389@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=pmladek@suse.cz \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.