From: viro@ZenIV.linux.org.uk (Al Viro)
Subject: [PATCH v3 2/5] lib: Add Sed-opal library
Date: Tue, 20 Dec 2016 06:50:13 +0000 [thread overview]
Message-ID: <20161220065013.GC1555@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1482176149-2257-3-git-send-email-scott.bauer@intel.com>
On Mon, Dec 19, 2016@12:35:46PM -0700, Scott Bauer wrote:
> +int fdev_sed_ioctl(struct file *filep, unsigned int cmd,
> + unsigned long arg)
> +{
> + struct sed_key key;
> + struct sed_context *sed_ctx;
> +
> + if (!capable(CAP_SYS_ADMIN))
> + return -EACCES;
> +
> + if (!filep->f_sedctx || !filep->f_sedctx->ops || !filep->f_sedctx->dev)
> + return -ENODEV;
> +
> + sed_ctx = filep->f_sedctx;
First of all, that's a bisect hazard. What's more, looking through the
rest of patchset, WTF does it
* need to be called that early in ioctl(2) handling, instead of
having ->ioctl() instance for that sucker calling it?
* _not_ get your ->f_sedctx as an explicit argument, passed by
the caller in ->ioctl(), seeing that it's possible to calculate by
file->private_data?
* store that thing in struct file itself, bloating it for everything
all for the sake of few drivers that might want to use that helper?
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Scott Bauer <scott.bauer@intel.com>
Cc: linux-nvme@lists.infradead.org, Rafael.Antognolli@intel.com,
axboe@fb.com, keith.busch@intel.com, jonathan.derrick@intel.com,
hch@infradead.org, linux-kernel@vger.kernel.org,
sagi@grimberg.me
Subject: Re: [PATCH v3 2/5] lib: Add Sed-opal library
Date: Tue, 20 Dec 2016 06:50:13 +0000 [thread overview]
Message-ID: <20161220065013.GC1555@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1482176149-2257-3-git-send-email-scott.bauer@intel.com>
On Mon, Dec 19, 2016 at 12:35:46PM -0700, Scott Bauer wrote:
> +int fdev_sed_ioctl(struct file *filep, unsigned int cmd,
> + unsigned long arg)
> +{
> + struct sed_key key;
> + struct sed_context *sed_ctx;
> +
> + if (!capable(CAP_SYS_ADMIN))
> + return -EACCES;
> +
> + if (!filep->f_sedctx || !filep->f_sedctx->ops || !filep->f_sedctx->dev)
> + return -ENODEV;
> +
> + sed_ctx = filep->f_sedctx;
First of all, that's a bisect hazard. What's more, looking through the
rest of patchset, WTF does it
* need to be called that early in ioctl(2) handling, instead of
having ->ioctl() instance for that sucker calling it?
* _not_ get your ->f_sedctx as an explicit argument, passed by
the caller in ->ioctl(), seeing that it's possible to calculate by
file->private_data?
* store that thing in struct file itself, bloating it for everything
all for the sake of few drivers that might want to use that helper?
next prev parent reply other threads:[~2016-12-20 6:50 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 19:35 [PATCH v3 0/5] SED OPAL Library Scott Bauer
2016-12-19 19:35 ` Scott Bauer
2016-12-19 19:35 ` [PATCH v3 1/5] include: Add definitions for sed Scott Bauer
2016-12-19 19:35 ` Scott Bauer
2016-12-20 6:46 ` Christoph Hellwig
2016-12-20 6:46 ` Christoph Hellwig
2016-12-25 14:15 ` Jethro Beekman
2016-12-25 14:15 ` Jethro Beekman
2016-12-27 22:14 ` Scott Bauer
2016-12-27 22:14 ` Scott Bauer
2016-12-19 19:35 ` [PATCH v3 2/5] lib: Add Sed-opal library Scott Bauer
2016-12-19 19:35 ` Scott Bauer
2016-12-19 21:34 ` Keith Busch
2016-12-19 21:34 ` Keith Busch
2016-12-20 6:07 ` Christoph Hellwig
2016-12-20 6:07 ` Christoph Hellwig
2016-12-20 3:21 ` kbuild test robot
2016-12-20 3:21 ` kbuild test robot
2016-12-20 3:48 ` kbuild test robot
2016-12-20 3:48 ` kbuild test robot
2016-12-20 6:50 ` Al Viro [this message]
2016-12-20 6:50 ` Al Viro
2016-12-20 7:28 ` Christoph Hellwig
2016-12-20 7:28 ` Christoph Hellwig
2016-12-20 21:55 ` Scott Bauer
2016-12-20 21:55 ` Scott Bauer
2016-12-21 9:42 ` Christoph Hellwig
2016-12-21 9:42 ` Christoph Hellwig
2016-12-20 22:07 ` Jon Derrick
2016-12-20 22:07 ` Jon Derrick
2016-12-21 9:47 ` Christoph Hellwig
2016-12-21 9:47 ` Christoph Hellwig
2016-12-19 19:35 ` [PATCH v3 3/5] fs: Wire up SED/Opal to ioctl Scott Bauer
2016-12-19 19:35 ` Scott Bauer
2016-12-20 6:21 ` Christoph Hellwig
2016-12-20 6:21 ` Christoph Hellwig
2016-12-19 19:35 ` [PATCH v3 4/5] nvme: Implement resume_from_suspend and SED Allocation code Scott Bauer
2016-12-19 19:35 ` Scott Bauer
2016-12-19 21:59 ` Keith Busch
2016-12-19 21:59 ` Keith Busch
2016-12-19 22:23 ` Scott Bauer
2016-12-19 22:23 ` Scott Bauer
2016-12-20 6:17 ` Christoph Hellwig
2016-12-20 6:17 ` Christoph Hellwig
2016-12-20 15:49 ` Keith Busch
2016-12-20 15:49 ` Keith Busch
2016-12-20 15:46 ` Christoph Hellwig
2016-12-20 15:46 ` Christoph Hellwig
2016-12-20 16:05 ` Scott Bauer
2016-12-20 16:05 ` Scott Bauer
2016-12-21 9:01 ` Christoph Hellwig
2016-12-21 9:01 ` Christoph Hellwig
2016-12-20 17:52 ` Scott Bauer
2016-12-20 17:52 ` Scott Bauer
2016-12-21 9:37 ` Christoph Hellwig
2016-12-21 9:37 ` Christoph Hellwig
2016-12-20 4:11 ` kbuild test robot
2016-12-20 4:11 ` kbuild test robot
2016-12-20 6:21 ` Christoph Hellwig
2016-12-20 6:21 ` Christoph Hellwig
2016-12-20 6:49 ` Christoph Hellwig
2016-12-20 6:49 ` Christoph Hellwig
2016-12-25 14:15 ` Jethro Beekman
2016-12-25 14:15 ` Jethro Beekman
2016-12-27 22:12 ` Scott Bauer
2016-12-27 22:12 ` Scott Bauer
2016-12-28 8:39 ` Christoph Hellwig
2016-12-28 8:39 ` Christoph Hellwig
2016-12-19 19:35 ` [PATCH v3 5/5] Maintainers: Add Information for SED Opal library Scott Bauer
2016-12-19 19:35 ` Scott Bauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161220065013.GC1555@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.