From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next 14/27] net: mvpp2: add ip_version field in "struct mvpp2"
Date: Wed, 21 Dec 2016 18:02:52 +0100 [thread overview]
Message-ID: <20161221170252.GO30952@lunn.ch> (raw)
In-Reply-To: <1482318994-23488-15-git-send-email-thomas.petazzoni@free-electrons.com>
Hi Thomas
Minor nit pick.
On Wed, Dec 21, 2016 at 12:16:21PM +0100, Thomas Petazzoni wrote:
> In preparation to the introduction for the support of PPv2.2 in the
> mvpp2 driver, this commit adds an ip_version field to the struct
> mvpp2
When i read this, i was thinking IPv4 vs IPv6. It is a network driver after all.
Could you maybe call this hw_version?
Thanks
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Yehuda Yitschak <yehuday@marvell.com>,
Jason Cooper <jason@lakedaemon.net>,
Hanna Hawa <hannah@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
Stefan Chulski <stefanc@marvell.com>,
Marcin Wojtas <mw@semihalf.com>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH net-next 14/27] net: mvpp2: add ip_version field in "struct mvpp2"
Date: Wed, 21 Dec 2016 18:02:52 +0100 [thread overview]
Message-ID: <20161221170252.GO30952@lunn.ch> (raw)
In-Reply-To: <1482318994-23488-15-git-send-email-thomas.petazzoni@free-electrons.com>
Hi Thomas
Minor nit pick.
On Wed, Dec 21, 2016 at 12:16:21PM +0100, Thomas Petazzoni wrote:
> In preparation to the introduction for the support of PPv2.2 in the
> mvpp2 driver, this commit adds an ip_version field to the struct
> mvpp2
When i read this, i was thinking IPv4 vs IPv6. It is a network driver after all.
Could you maybe call this hw_version?
Thanks
Andrew
next prev parent reply other threads:[~2016-12-21 17:02 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 11:16 [PATCH net-next 00/27] net: mvpp2: add basic support for PPv2.2 Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 01/27] dt-bindings: net: update Marvell PPv2 binding for PPv2.2 support Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 02/27] net: mvpp2: handle too large value handling in mvpp2_rx_pkts_coal_set() Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 03/27] net: mvpp2: handle too large value in mvpp2_rx_time_coal_set() Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 04/27] net: mvpp2: release reference to txq_cpu[] entry after unmapping Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 05/27] net: mvpp2: remove unused 'tx_skb' field of 'struct mvpp2_tx_queue' Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 06/27] net: mvpp2: drop useless fields in mvpp2_bm_pool and related code Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 07/27] net: mvpp2: simplify mvpp2_bm_bufs_add() Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 08/27] net: mvpp2: remove unused register definitions Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 09/27] net: mvpp2: fix indentation of MVPP2_EXT_GLOBAL_CTRL_DEFAULT Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 10/27] net: mvpp2: simplify MVPP2_PRS_RI_* definitions Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 11/27] net: mvpp2: switch to build_skb() in the RX path Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 12/27] net: mvpp2: enable building on 64-bit platforms Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 13/27] net: mvpp2: add and use accessors for TX/RX descriptors Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 14/27] net: mvpp2: add ip_version field in "struct mvpp2" Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 17:02 ` Andrew Lunn [this message]
2016-12-21 17:02 ` Andrew Lunn
2016-12-21 17:04 ` Thomas Petazzoni
2016-12-21 17:04 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 15/27] net: mvpp2: introduce an intermediate union for the TX/RX descriptors Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 16/27] net: mvpp2: introduce PPv2.2 HW descriptors and adapt accessors Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 17/27] net: mvpp2: adjust the allocation/free of BM pools for PPv2.2 Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 18/27] net: mvpp2: adapt the mvpp2_rxq_*_pool_set functions to PPv2.2 Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 19/27] net: mvpp2: adapt mvpp2_defaults_set() " Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 20/27] net: mvpp2: adjust mvpp2_{rxq, txq}_init for PPv2.2 Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 20/27] net: mvpp2: adjust mvpp2_{rxq,txq}_init " Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 21/27] net: mvpp2: handle register mapping and access " Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 22/27] net: mvpp2: handle misc PPv2.1/PPv2.2 differences Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 23/27] net: mvpp2: add AXI bridge initialization for PPv2.2 Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 24/27] net: mvpp2: rework RXQ interrupt group " Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 25/27] net: mvpp2: adapt rxq distribution to PPv2.2 Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 26/27] net: mvpp2: add support for an additional clock needed for PPv2.2 Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 11:16 ` [PATCH net-next 27/27] net: mvpp2: finally add the PPv2.2 compatible string Thomas Petazzoni
2016-12-21 11:16 ` Thomas Petazzoni
2016-12-21 16:03 ` [PATCH net-next 00/27] net: mvpp2: add basic support for PPv2.2 David Miller
2016-12-21 16:03 ` David Miller
2016-12-21 16:12 ` Thomas Petazzoni
2016-12-21 16:12 ` Thomas Petazzoni
2016-12-21 16:24 ` David Miller
2016-12-21 16:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161221170252.GO30952@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.