From: Andy Gross <andy.gross@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: David Brown <david.brown@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
John Stultz <john.stultz@linaro.org>,
linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [1/5] ARM: dts: qcom: apq8064: Add missing scm clock
Date: Wed, 28 Dec 2016 21:14:32 -0600 [thread overview]
Message-ID: <20161229031432.GA18506@hector.attlocal.net> (raw)
In-Reply-To: <20161221114939.19973-1-bjorn.andersson@linaro.org>
On Wed, Dec 21, 2016 at 03:49:35AM -0800, Bjorn Andersson wrote:
> As per the device tree binding the apq8064 scm node requires the core
> clock to be specified, so add this.
>
> Cc: John Stultz <john.stultz@linaro.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> arch/arm/boot/dts/qcom-apq8064.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
> index 268bd470c865..78bf155a52f3 100644
> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
> @@ -303,6 +303,9 @@
> firmware {
> scm {
> compatible = "qcom,scm-apq8064";
> +
> + clocks = <&gcc CE3_CORE_CLK>;
> + clock-names = "core";
Isn't this supposed to be the DFAB clk? The RPM one? I think that's why we let
the clock just fall through optionally before the recent changes that broke
this.
Regards,
Andy
WARNING: multiple messages have this Message-ID (diff)
From: andy.gross@linaro.org (Andy Gross)
To: linux-arm-kernel@lists.infradead.org
Subject: [1/5] ARM: dts: qcom: apq8064: Add missing scm clock
Date: Wed, 28 Dec 2016 21:14:32 -0600 [thread overview]
Message-ID: <20161229031432.GA18506@hector.attlocal.net> (raw)
In-Reply-To: <20161221114939.19973-1-bjorn.andersson@linaro.org>
On Wed, Dec 21, 2016 at 03:49:35AM -0800, Bjorn Andersson wrote:
> As per the device tree binding the apq8064 scm node requires the core
> clock to be specified, so add this.
>
> Cc: John Stultz <john.stultz@linaro.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> arch/arm/boot/dts/qcom-apq8064.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
> index 268bd470c865..78bf155a52f3 100644
> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
> @@ -303,6 +303,9 @@
> firmware {
> scm {
> compatible = "qcom,scm-apq8064";
> +
> + clocks = <&gcc CE3_CORE_CLK>;
> + clock-names = "core";
Isn't this supposed to be the DFAB clk? The RPM one? I think that's why we let
the clock just fall through optionally before the recent changes that broke
this.
Regards,
Andy
next prev parent reply other threads:[~2016-12-29 3:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 11:49 [PATCH 1/5] ARM: dts: qcom: apq8064: Add missing scm clock Bjorn Andersson
2016-12-21 11:49 ` Bjorn Andersson
2016-12-21 11:49 ` [PATCH 2/5] ARM: dts: qcom: apq8064: Add riva-pil node Bjorn Andersson
2016-12-21 11:49 ` Bjorn Andersson
2016-12-21 11:49 ` Bjorn Andersson
2017-01-07 1:07 ` John Stultz
2017-01-07 1:07 ` John Stultz
2017-01-07 1:07 ` John Stultz
2016-12-21 11:49 ` [PATCH 5/5] ARM: dts: qcom: sd600eval: Enable riva-pil Bjorn Andersson
2016-12-21 11:49 ` Bjorn Andersson
2016-12-29 3:14 ` Andy Gross [this message]
2016-12-29 3:14 ` [1/5] ARM: dts: qcom: apq8064: Add missing scm clock Andy Gross
[not found] ` <20161221114939.19973-1-bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-12-21 11:49 ` [PATCH 3/5] ARM: dts: qcom: apq8064-sony-yuga: Enable riva-pil Bjorn Andersson
2016-12-21 11:49 ` Bjorn Andersson
2016-12-21 11:49 ` Bjorn Andersson
2016-12-21 11:49 ` [PATCH 4/5] ARM: dts: qcom: sd600-eval: pm8921_s2 regulator properties Bjorn Andersson
2016-12-21 11:49 ` Bjorn Andersson
2016-12-21 11:49 ` Bjorn Andersson
2017-01-07 1:10 ` [PATCH 1/5] ARM: dts: qcom: apq8064: Add missing scm clock John Stultz
2017-01-07 1:10 ` John Stultz
2017-01-07 1:10 ` John Stultz
2017-01-07 3:01 ` Andy Gross
2017-01-07 3:01 ` Andy Gross
[not found] ` <20170107030120.GC5710-3KkwrOJo9xYlRp7syxWybdHuzzzSOjJt@public.gmane.org>
2017-01-07 7:30 ` Bjorn Andersson
2017-01-07 7:30 ` Bjorn Andersson
2017-01-07 7:30 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161229031432.GA18506@hector.attlocal.net \
--to=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.