From: Minchan Kim <minchan@kernel.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
Johannes Weiner <hannes@cmpxchg.org>,
Vlastimil Babka <vbabka@suse.cz>, Rik van Riel <riel@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH 3/7] mm, vmscan: show the number of skipped pages in mm_vmscan_lru_isolate
Date: Thu, 29 Dec 2016 14:53:29 +0900 [thread overview]
Message-ID: <20161229055329.GB1815@bbox> (raw)
In-Reply-To: <20161228153032.10821-4-mhocko@kernel.org>
On Wed, Dec 28, 2016 at 04:30:28PM +0100, Michal Hocko wrote:
> From: Michal Hocko <mhocko@suse.com>
>
> mm_vmscan_lru_isolate shows the number of requested, scanned and taken
> pages. This is mostly OK but on 32b systems the number of scanned pages
> is quite misleading because it includes both the scanned and skipped
> pages. Moreover the skipped part is scaled based on the number of taken
> pages. Let's report the exact numbers without any additional logic and
> add the number of skipped pages. This should make the reported data much
> more easier to interpret.
>
> Signed-off-by: Michal Hocko <mhocko@suse.com>
Acked-by: Minchan Kim <minchan@kernel.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: <linux-mm@kvack.org>, Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
Johannes Weiner <hannes@cmpxchg.org>,
Vlastimil Babka <vbabka@suse.cz>, Rik van Riel <riel@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH 3/7] mm, vmscan: show the number of skipped pages in mm_vmscan_lru_isolate
Date: Thu, 29 Dec 2016 14:53:29 +0900 [thread overview]
Message-ID: <20161229055329.GB1815@bbox> (raw)
In-Reply-To: <20161228153032.10821-4-mhocko@kernel.org>
On Wed, Dec 28, 2016 at 04:30:28PM +0100, Michal Hocko wrote:
> From: Michal Hocko <mhocko@suse.com>
>
> mm_vmscan_lru_isolate shows the number of requested, scanned and taken
> pages. This is mostly OK but on 32b systems the number of scanned pages
> is quite misleading because it includes both the scanned and skipped
> pages. Moreover the skipped part is scaled based on the number of taken
> pages. Let's report the exact numbers without any additional logic and
> add the number of skipped pages. This should make the reported data much
> more easier to interpret.
>
> Signed-off-by: Michal Hocko <mhocko@suse.com>
Acked-by: Minchan Kim <minchan@kernel.org>
next prev parent reply other threads:[~2016-12-29 5:53 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 15:30 [PATCH 0/7] vm, vmscan: enahance vmscan tracepoints Michal Hocko
2016-12-28 15:30 ` Michal Hocko
2016-12-28 15:30 ` [PATCH 1/7] mm, vmscan: remove unused mm_vmscan_memcg_isolate Michal Hocko
2016-12-28 15:30 ` Michal Hocko
2016-12-29 7:33 ` Hillf Danton
2016-12-29 7:33 ` Hillf Danton
2016-12-28 15:30 ` [PATCH 2/7] mm, vmscan: add active list aging tracepoint Michal Hocko
2016-12-28 15:30 ` Michal Hocko
2016-12-29 5:33 ` Minchan Kim
2016-12-29 5:33 ` Minchan Kim
2016-12-29 7:52 ` Michal Hocko
2016-12-29 7:52 ` Michal Hocko
2016-12-30 1:48 ` Minchan Kim
2016-12-30 1:48 ` Minchan Kim
2016-12-30 9:26 ` Michal Hocko
2016-12-30 9:26 ` Michal Hocko
2016-12-30 9:38 ` Hillf Danton
2016-12-30 9:38 ` Hillf Danton
2016-12-30 16:04 ` Minchan Kim
2016-12-30 16:04 ` Minchan Kim
2016-12-30 16:37 ` Michal Hocko
2016-12-30 16:37 ` Michal Hocko
2016-12-30 17:30 ` Michal Hocko
2016-12-30 17:30 ` Michal Hocko
2017-01-03 5:03 ` Minchan Kim
2017-01-03 5:03 ` Minchan Kim
2017-01-03 8:21 ` Michal Hocko
2017-01-03 8:21 ` Michal Hocko
2017-01-04 5:07 ` Minchan Kim
2017-01-04 5:07 ` Minchan Kim
2017-01-04 7:28 ` Vlastimil Babka
2017-01-04 7:28 ` Vlastimil Babka
2017-01-04 7:50 ` Michal Hocko
2017-01-04 7:50 ` Michal Hocko
2016-12-29 7:44 ` Hillf Danton
2016-12-29 7:44 ` Hillf Danton
2016-12-28 15:30 ` [PATCH 3/7] mm, vmscan: show the number of skipped pages in mm_vmscan_lru_isolate Michal Hocko
2016-12-28 15:30 ` Michal Hocko
2016-12-29 5:53 ` Minchan Kim [this message]
2016-12-29 5:53 ` Minchan Kim
2016-12-29 7:49 ` Hillf Danton
2016-12-29 7:49 ` Hillf Danton
2017-01-03 17:21 ` Vlastimil Babka
2017-01-03 17:21 ` Vlastimil Babka
2017-01-03 20:43 ` Michal Hocko
2017-01-03 20:43 ` Michal Hocko
2016-12-28 15:30 ` [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint Michal Hocko
2016-12-28 15:30 ` Michal Hocko
2016-12-28 15:50 ` Nikolay Borisov
2016-12-28 15:50 ` Nikolay Borisov
2016-12-28 16:00 ` Michal Hocko
2016-12-28 16:00 ` Michal Hocko
2016-12-28 16:40 ` Nikolay Borisov
2016-12-28 16:40 ` Nikolay Borisov
2016-12-28 16:49 ` Michal Hocko
2016-12-28 16:49 ` Michal Hocko
2016-12-29 6:02 ` Minchan Kim
2016-12-29 6:02 ` Minchan Kim
2016-12-29 7:56 ` Michal Hocko
2016-12-29 7:56 ` Michal Hocko
2016-12-30 1:56 ` Minchan Kim
2016-12-30 1:56 ` Minchan Kim
2016-12-30 9:33 ` Michal Hocko
2016-12-30 9:33 ` Michal Hocko
2016-12-29 7:53 ` Hillf Danton
2016-12-29 7:53 ` Hillf Danton
2017-01-03 17:08 ` Vlastimil Babka
2017-01-03 17:08 ` Vlastimil Babka
2017-01-03 20:47 ` Michal Hocko
2017-01-03 20:47 ` Michal Hocko
2017-01-03 20:52 ` Michal Hocko
2017-01-03 20:52 ` Michal Hocko
2017-01-03 21:24 ` Michal Hocko
2017-01-03 21:24 ` Michal Hocko
2017-01-03 21:40 ` Vlastimil Babka
2017-01-03 21:40 ` Vlastimil Babka
2017-01-03 21:48 ` Michal Hocko
2017-01-03 21:48 ` Michal Hocko
2016-12-28 15:30 ` [PATCH 5/7] mm, vmscan: extract shrink_page_list reclaim counters into a struct Michal Hocko
2016-12-28 15:30 ` Michal Hocko
2016-12-29 8:00 ` Hillf Danton
2016-12-29 8:00 ` Hillf Danton
2016-12-28 15:30 ` [PATCH 6/7] mm, vmscan: enhance mm_vmscan_lru_shrink_inactive tracepoint Michal Hocko
2016-12-28 15:30 ` Michal Hocko
2016-12-29 8:05 ` Hillf Danton
2016-12-29 8:05 ` Hillf Danton
2016-12-28 15:30 ` [PATCH 7/7] mm, vmscan: add mm_vmscan_inactive_list_is_low tracepoint Michal Hocko
2016-12-28 15:30 ` Michal Hocko
2016-12-29 8:19 ` Hillf Danton
2016-12-29 8:19 ` Hillf Danton
2016-12-30 9:11 ` [PATCH 0/7] vm, vmscan: enahance vmscan tracepoints Mel Gorman
2016-12-30 9:11 ` Mel Gorman
2016-12-30 9:36 ` Michal Hocko
2016-12-30 9:36 ` Michal Hocko
2016-12-30 10:20 ` Mel Gorman
2016-12-30 10:20 ` Mel Gorman
-- strict thread matches above, loose matches on Subject: below --
2017-01-04 10:19 [PATCH 0/7 v2] " Michal Hocko
2017-01-04 10:19 ` [PATCH 3/7] mm, vmscan: show the number of skipped pages in mm_vmscan_lru_isolate Michal Hocko
2017-01-04 10:19 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161229055329.GB1815@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=riel@redhat.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.