From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Xishi Qiu <qiuxishi@huawei.com>,
ngupta@vflare.org, Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: mm: fix typo of cache_alloc_zspage()
Date: Thu, 29 Dec 2016 15:59:35 +0900 [thread overview]
Message-ID: <20161229065935.GE1815@bbox> (raw)
In-Reply-To: <20161229065205.GA3892@jagdpanzerIV.localdomain>
Hi Sergey,
On Thu, Dec 29, 2016 at 03:52:05PM +0900, Sergey Senozhatsky wrote:
> On (12/29/16 15:44), Minchan Kim wrote:
> > On Thu, Dec 29, 2016 at 10:06:47AM +0800, Xishi Qiu wrote:
> > > Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
> > > ---
> > > mm/zsmalloc.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> > > index 9cc3c0b..2d6c92e 100644
> > > --- a/mm/zsmalloc.c
> > > +++ b/mm/zsmalloc.c
> > > @@ -364,7 +364,7 @@ static struct zspage *cache_alloc_zspage(struct zs_pool *pool, gfp_t flags)
> > > {
> > > return kmem_cache_alloc(pool->zspage_cachep,
> > > flags & ~(__GFP_HIGHMEM|__GFP_MOVABLE));
> > > -};
> > > +}
> >
> > Although it's trivial, we need descritpion.
> > Please, could you resend to Andrew Morton with filling description?
>
> I don't know... do we want to have it as a separate patch?
> may be we can fold it into some other patch someday later.
Xishi spent his time to make the patch(review,create/send). And I want to
give a credit to him. :)
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Xishi Qiu <qiuxishi@huawei.com>,
ngupta@vflare.org, Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: mm: fix typo of cache_alloc_zspage()
Date: Thu, 29 Dec 2016 15:59:35 +0900 [thread overview]
Message-ID: <20161229065935.GE1815@bbox> (raw)
In-Reply-To: <20161229065205.GA3892@jagdpanzerIV.localdomain>
Hi Sergey,
On Thu, Dec 29, 2016 at 03:52:05PM +0900, Sergey Senozhatsky wrote:
> On (12/29/16 15:44), Minchan Kim wrote:
> > On Thu, Dec 29, 2016 at 10:06:47AM +0800, Xishi Qiu wrote:
> > > Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
> > > ---
> > > mm/zsmalloc.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> > > index 9cc3c0b..2d6c92e 100644
> > > --- a/mm/zsmalloc.c
> > > +++ b/mm/zsmalloc.c
> > > @@ -364,7 +364,7 @@ static struct zspage *cache_alloc_zspage(struct zs_pool *pool, gfp_t flags)
> > > {
> > > return kmem_cache_alloc(pool->zspage_cachep,
> > > flags & ~(__GFP_HIGHMEM|__GFP_MOVABLE));
> > > -};
> > > +}
> >
> > Although it's trivial, we need descritpion.
> > Please, could you resend to Andrew Morton with filling description?
>
> I don't know... do we want to have it as a separate patch?
> may be we can fold it into some other patch someday later.
Xishi spent his time to make the patch(review,create/send). And I want to
give a credit to him. :)
Thanks.
next prev parent reply other threads:[~2016-12-29 6:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-29 2:06 mm: fix typo of cache_alloc_zspage() Xishi Qiu
2016-12-29 2:06 ` Xishi Qiu
2016-12-29 6:44 ` Minchan Kim
2016-12-29 6:44 ` Minchan Kim
2016-12-29 6:52 ` Sergey Senozhatsky
2016-12-29 6:52 ` Sergey Senozhatsky
2016-12-29 6:59 ` Minchan Kim [this message]
2016-12-29 6:59 ` Minchan Kim
2016-12-29 7:34 ` Sergey Senozhatsky
2016-12-29 7:34 ` Sergey Senozhatsky
2016-12-29 7:56 ` Minchan Kim
2016-12-29 7:56 ` Minchan Kim
2016-12-29 8:03 ` Sergey Senozhatsky
2016-12-29 8:03 ` Sergey Senozhatsky
2016-12-29 10:34 ` Xishi Qiu
2016-12-29 10:34 ` Xishi Qiu
2016-12-30 1:07 ` Sergey Senozhatsky
2016-12-30 1:07 ` Sergey Senozhatsky
2016-12-29 7:54 ` [PATCH V2] " Xishi Qiu
2016-12-29 7:54 ` Xishi Qiu
2017-01-06 4:08 ` [PATCH] mm: fix some typos in mm/zsmalloc.c Xishi Qiu
2017-01-06 4:08 ` Xishi Qiu
2017-01-06 4:38 ` Minchan Kim
2017-01-06 4:38 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161229065935.GE1815@bbox \
--to=minchan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=qiuxishi@huawei.com \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.