All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3][v2] arm64: freescale: ls2080a: Split devicetree for code resuability
Date: Fri, 30 Dec 2016 19:26:38 +0800	[thread overview]
Message-ID: <20161230112635.GQ6177@dragon> (raw)
In-Reply-To: <1480325824-14649-3-git-send-email-abhimanyu.saini@nxp.com>

On Mon, Nov 28, 2016 at 03:07:03PM +0530, Abhimanyu Saini wrote:
> LS2088A and LS2080A are similar SoCs with a few differences like
> ARM cores etc.
> 
> Reorganize the LS2080A device tree to move the common nodes to:
> 	- fsl-ls2080a-ls2088a.dtsi
> 	- fsl-ls2080a-ls2088a-rdb.dts
> 	- fsl-ls2080a-ls2088a-qds.dts

I do not quite like the naming of these files.  Will the following one
be better?

 - fsl-ls208xa.dtsi
 - fsl-ls208xa-rdb.dtsi
 - fsl-ls208xa-qds.dtsi

Also if a DTS file is only to be included by another one, not to
generate a DTB, we name it .dtsi rather than .dts.

Shawn

> 
> Signed-off-by: Abhimanyu Saini <abhimanyu.saini@nxp.com>
> Signed-off-by: Priyanka Jain <priyanka.jain@nxp.com>
> Signed-off-by: Ashish Kumar <ashish.kumar@nxp.com>
> ---
>  .../boot/dts/freescale/fsl-ls2080a-ls2088a-qds.dts | 196 ++++++
>  .../boot/dts/freescale/fsl-ls2080a-ls2088a-rdb.dts | 152 +++++
>  .../boot/dts/freescale/fsl-ls2080a-ls2088a.dtsi    | 727 +++++++++++++++++++++
>  arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts  | 154 +----
>  arch/arm64/boot/dts/freescale/fsl-ls2080a-rdb.dts  | 110 +---
>  arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi     | 706 +-------------------
>  6 files changed, 1100 insertions(+), 945 deletions(-)
>  create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls2080a-ls2088a-qds.dts
>  create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls2080a-ls2088a-rdb.dts
>  create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls2080a-ls2088a.dtsi

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Abhimanyu Saini <abhimanyu.saini-3arQi8VN3Tc@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	scott.wood-3arQi8VN3Tc@public.gmane.org,
	stuart.yoder-3arQi8VN3Tc@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Priyanka Jain <priyanka.jain-3arQi8VN3Tc@public.gmane.org>,
	Ashish Kumar <ashish.kumar-3arQi8VN3Tc@public.gmane.org>
Subject: Re: [PATCH 2/3][v2] arm64: freescale: ls2080a: Split devicetree for code resuability
Date: Fri, 30 Dec 2016 19:26:38 +0800	[thread overview]
Message-ID: <20161230112635.GQ6177@dragon> (raw)
In-Reply-To: <1480325824-14649-3-git-send-email-abhimanyu.saini-3arQi8VN3Tc@public.gmane.org>

On Mon, Nov 28, 2016 at 03:07:03PM +0530, Abhimanyu Saini wrote:
> LS2088A and LS2080A are similar SoCs with a few differences like
> ARM cores etc.
> 
> Reorganize the LS2080A device tree to move the common nodes to:
> 	- fsl-ls2080a-ls2088a.dtsi
> 	- fsl-ls2080a-ls2088a-rdb.dts
> 	- fsl-ls2080a-ls2088a-qds.dts

I do not quite like the naming of these files.  Will the following one
be better?

 - fsl-ls208xa.dtsi
 - fsl-ls208xa-rdb.dtsi
 - fsl-ls208xa-qds.dtsi

Also if a DTS file is only to be included by another one, not to
generate a DTB, we name it .dtsi rather than .dts.

Shawn

> 
> Signed-off-by: Abhimanyu Saini <abhimanyu.saini-3arQi8VN3Tc@public.gmane.org>
> Signed-off-by: Priyanka Jain <priyanka.jain-3arQi8VN3Tc@public.gmane.org>
> Signed-off-by: Ashish Kumar <ashish.kumar-3arQi8VN3Tc@public.gmane.org>
> ---
>  .../boot/dts/freescale/fsl-ls2080a-ls2088a-qds.dts | 196 ++++++
>  .../boot/dts/freescale/fsl-ls2080a-ls2088a-rdb.dts | 152 +++++
>  .../boot/dts/freescale/fsl-ls2080a-ls2088a.dtsi    | 727 +++++++++++++++++++++
>  arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts  | 154 +----
>  arch/arm64/boot/dts/freescale/fsl-ls2080a-rdb.dts  | 110 +---
>  arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi     | 706 +-------------------
>  6 files changed, 1100 insertions(+), 945 deletions(-)
>  create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls2080a-ls2088a-qds.dts
>  create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls2080a-ls2088a-rdb.dts
>  create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls2080a-ls2088a.dtsi
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-12-30 11:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-28  9:37 [PATCH 0/3][v2] Add QorIQ LS2088A platform support Abhimanyu Saini
     [not found] ` <1480325824-14649-1-git-send-email-abhimanyu.saini-3arQi8VN3Tc@public.gmane.org>
2016-11-28  9:37   ` [PATCH 1/3][v2] dt-bindings: Add compatible for LS2088A QDS and RDB boards Abhimanyu Saini
2016-12-03 21:33     ` Rob Herring
2016-12-03 21:33       ` Rob Herring
2016-11-28  9:37   ` [PATCH 2/3][v2] arm64: freescale: ls2080a: Split devicetree for code resuability Abhimanyu Saini
2016-12-30 11:26     ` Shawn Guo [this message]
2016-12-30 11:26       ` Shawn Guo
2016-11-28  9:37   ` [PATCH 3/3][v2] arm64: Add DTS support for FSL's LS2088A SoC Abhimanyu Saini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161230112635.GQ6177@dragon \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.