From: Peter Zijlstra <peterz@infradead.org>
To: linux-kernel@vger.kernel.org, mingo@kernel.org,
tglx@linutronix.de, hpa@zytor.com
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:timers/urgent] ktime: Get rid of the union
Date: Tue, 3 Jan 2017 11:36:34 +0100 [thread overview]
Message-ID: <20170103103634.GA25813@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <tip-64dac5c9e0f5a933e4520f0cb689b7b143925207@git.kernel.org>
On Sun, Dec 25, 2016 at 05:26:33AM -0800, tip-bot for Thomas Gleixner wrote:
> Commit-ID: 64dac5c9e0f5a933e4520f0cb689b7b143925207
> Gitweb: http://git.kernel.org/tip/64dac5c9e0f5a933e4520f0cb689b7b143925207
> Author: Thomas Gleixner <tglx@linutronix.de>
> AuthorDate: Sun, 25 Dec 2016 11:38:40 +0100
> Committer: Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Sun, 25 Dec 2016 13:11:50 +0100
>
> ktime: Get rid of the union
>
> ktime is a union because the initial implementation stored the time in
> scalar nanoseconds on 64 bit machine and in a endianess optimized timespec
> variant for 32bit machines. The Y2038 cleanup removed the timespec variant
> and switched everything to scalar nanoseconds. The union remained, but
> become completely pointless.
>
> Get rid of the union and just keep ktime_t as simple typedef of type s64.
All good stuff. One question that remains is why keep the type while
removing the cycles_t type?
next parent reply other threads:[~2017-01-03 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-64dac5c9e0f5a933e4520f0cb689b7b143925207@git.kernel.org>
2017-01-03 10:36 ` Peter Zijlstra [this message]
2017-01-04 8:54 ` [tip:timers/urgent] ktime: Get rid of the union Thomas Gleixner
2017-01-04 9:39 ` Peter Zijlstra
2017-01-04 13:47 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170103103634.GA25813@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.