[PATCH] char: lack of bool string made CONFIG_DEVPORT always on

[PATCH] char: lack of bool string made CONFIG_DEVPORT always on

[Max]

From: Max Bires <jbires@google.com>

Without a bool string present, using "# CONFIG_DEVPORT is not set" in
defconfig files would not actually unset devport. This ensured that
/dev/port was always on, but there are reasons a user may wish to disable
it (smaller kernel, attack surface reduction) if it's not being used. Adding
a message here in order to make this user visible.

Signed-off-by: Max Bires <jbires@google.com>
---
 drivers/char/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index 7ad3127..d647e7e 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -589,10 +589,13 @@ config TELCLOCK
 	  controlling the behavior of this hardware.
 
 config DEVPORT
-	bool
+	bool "/dev/port character device"
 	depends on !M68K
 	depends on ISA || PCI
 	default y
+	help
+		Say Y here if you want to support the /dev/port device. The
+		/dev/port device is similar to /dev/mem, but for I/O ports.
 
 config DCC_TTY
 	tristate "DCC tty driver"
-- 
2.8.0.rc3.226.g39d4020

Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on

[Greg KH]

On Tue, Dec 13, 2016 at 04:32:25PM -0800, Max wrote:
> From: Max Bires <jbires@google.com>
> 
> Without a bool string present, using "# CONFIG_DEVPORT is not set" in
> defconfig files would not actually unset devport. This ensured that
> /dev/port was always on, but there are reasons a user may wish to disable
> it (smaller kernel, attack surface reduction) if it's not being used. Adding
> a message here in order to make this user visible.
> 
> Signed-off-by: Max Bires <jbires@google.com>
> ---
>  drivers/char/Kconfig | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index 7ad3127..d647e7e 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -589,10 +589,13 @@ config TELCLOCK
>  	  controlling the behavior of this hardware.
>  
>  config DEVPORT
> -	bool
> +	bool "/dev/port character device"
>  	depends on !M68K
>  	depends on ISA || PCI
>  	default y
> +	help
> +		Say Y here if you want to support the /dev/port device. The
> +		/dev/port device is similar to /dev/mem, but for I/O ports.


Hm, did you look at how the indentation for all of the help entries are
in this file?  Please match it up to be the same...

Other than that, this looks much better, the format and style of the
submission was fine.

thanks,

greg k-h

[PATCH] char: lack of bool string made CONFIG_DEVPORT always on

[Max]

Without a bool string present, using "# CONFIG_DEVPORT is not set" in
defconfig files would not actually unset devport. This ensured that
/dev/port was always on, but there are reasons a user may wish to disable
it (smaller kernel, attack surface reduction) if it's not being used. Adding
a message here in order to make this user visible.

Signed-off-by: Max Bires <jbires@google.com>
---
 drivers/char/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index 7ad3127..e8fc493 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -589,10 +589,13 @@ config TELCLOCK
 	  controlling the behavior of this hardware.
 
 config DEVPORT
-	bool
+	bool "/dev/port character device"
 	depends on !M68K
 	depends on ISA || PCI
 	default y
+	help
+	  Say Y here if you want to support the /dev/port device. The
+	  /dev/port device is similar to /dev/mem, but for I/O ports.
 
 config DCC_TTY
 	tristate "DCC tty driver"
-- 
2.8.0.rc3.226.g39d4020

Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on

[Geert Uytterhoeven]

On Wed, Dec 14, 2016 at 2:18 AM, Max <jbires@google.com> wrote:
> Without a bool string present, using "# CONFIG_DEVPORT is not set" in
> defconfig files would not actually unset devport. This ensured that
> /dev/port was always on, but there are reasons a user may wish to disable
> it (smaller kernel, attack surface reduction) if it's not being used. Adding
> a message here in order to make this user visible.
>
> Signed-off-by: Max Bires <jbires@google.com>
> ---
>  drivers/char/Kconfig | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index 7ad3127..e8fc493 100644
>
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -589,10 +589,13 @@ config TELCLOCK
>           controlling the behavior of this hardware.
>
>  config DEVPORT
> -       bool
> +       bool "/dev/port character device"

bool "/dev/port character device" if EXPERT?

>         depends on !M68K
>         depends on ISA || PCI
>         default y
> +       help
> +         Say Y here if you want to support the /dev/port device. The
> +         /dev/port device is similar to /dev/mem, but for I/O ports.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on

[Arnd Bergmann]

On Wednesday, December 14, 2016 9:58:53 AM CET Geert Uytterhoeven wrote:
> >
> > --- a/drivers/char/Kconfig
> > +++ b/drivers/char/Kconfig
> > @@ -589,10 +589,13 @@ config TELCLOCK
> >           controlling the behavior of this hardware.
> >
> >  config DEVPORT
> > -       bool
> > +       bool "/dev/port character device"
> 
> bool "/dev/port character device" if EXPERT?

I think the 'default y' is good enough, there are good reasons
even for non-EXPERT configurations to turn this off.

	Arnd

Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on

[Josh Triplett]

On Wed, Dec 14, 2016 at 10:11:19AM +0100, Arnd Bergmann wrote:
> On Wednesday, December 14, 2016 9:58:53 AM CET Geert Uytterhoeven wrote:
> > >
> > > --- a/drivers/char/Kconfig
> > > +++ b/drivers/char/Kconfig
> > > @@ -589,10 +589,13 @@ config TELCLOCK
> > >           controlling the behavior of this hardware.
> > >
> > >  config DEVPORT
> > > -       bool
> > > +       bool "/dev/port character device"
> > 
> > bool "/dev/port character device" if EXPERT?
> 
> I think the 'default y' is good enough, there are good reasons
> even for non-EXPERT configurations to turn this off.

Agreed. /dev/port seems like something the majority of modern systems
can safely turn off.

Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on

[Arnd Bergmann]

On Tuesday, December 27, 2016 3:05:54 PM CET Max Bires wrote:
> So this is fine as is then? Just making sure that outside of the
> development tree being closed for now that this patch is good to go now
> that space/tab formatting is fixed.

Yes, the change is fine, please add my

Acked-by: Arnd Bergmann <arnd@arndb.de>

Note two details:

- Please avoid top-posting in emails as you did here

- In your patch submission the sender is listed as "Max" without
  a last name, while your Signed-off-by line contains your full
  name. As the sender gets used as the author tag, please
  resubmit the patch with your full name as sender or add a
  separate "From: " line at the beginning of the mail.
  Git format-patch/send-email gets this right as long as your
  git configuration has your full name.

	Arnd

[PATCH] char: lack of bool string made CONFIG_DEVPORT always on

[Max Bires]

Without a bool string present, using "# CONFIG_DEVPORT is not set" in
defconfig files would not actually unset devport. This ensured that
/dev/port was always on, but there are reasons a user may wish to disable
it (smaller kernel, attack surface reduction) if it's not being used. Adding
a message here in order to make this user visible.

Signed-off-by: Max Bires <jbires@google.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/char/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index 7ad3127..e8fc493 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -589,10 +589,13 @@ config TELCLOCK
 	  controlling the behavior of this hardware.
 
 config DEVPORT
-	bool
+	bool "/dev/port character device"
 	depends on !M68K
 	depends on ISA || PCI
 	default y
+	help
+	  Say Y here if you want to support the /dev/port device. The
+	  /dev/port device is similar to /dev/mem, but for I/O ports.
 
 config DCC_TTY
 	tristate "DCC tty driver"
-- 
2.8.0.rc3.226.g39d4020

Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on

[Greg KH]

On Tue, Jan 03, 2017 at 04:53:13AM -0800, Max Bires wrote:
> Without a bool string present, using "# CONFIG_DEVPORT is not set" in
> defconfig files would not actually unset devport. This ensured that
> /dev/port was always on, but there are reasons a user may wish to disable
> it (smaller kernel, attack surface reduction) if it's not being used. Adding
> a message here in order to make this user visible.
> 
> Signed-off-by: Max Bires <jbires@google.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/char/Kconfig | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index 7ad3127..e8fc493 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -589,10 +589,13 @@ config TELCLOCK
>  	  controlling the behavior of this hardware.
>  
>  config DEVPORT
> -	bool
> +	bool "/dev/port character device"
>  	depends on !M68K
>  	depends on ISA || PCI
>  	default y
> +	help
> +	  Say Y here if you want to support the /dev/port device. The
> +	  /dev/port device is similar to /dev/mem, but for I/O ports.
>  
>  config DCC_TTY
>  	tristate "DCC tty driver"

This does not apply at all to 4.10-rc2, what did you make it against?
Please redo it so that I can actually apply it...

thanks,

greg k-h

[PATCH] Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This esnured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being used. Adding a message here in order to make this user visible.

[Max Bires]

Signed-off-by: Max Bires <jbires@google.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/char/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index fde005e..4ee2a10 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -571,9 +571,12 @@ config TELCLOCK
 	  controlling the behavior of this hardware.
 
 config DEVPORT
-	bool
+	bool "/dev/port character device"
 	depends on ISA || PCI
 	default y
+	help
+	  Say Y here if you want to support the /dev/port device. The /dev/port
+	  device is similar to /dev/mem, but for I/O ports.
 
 source "drivers/s390/char/Kconfig"
 
-- 
2.8.0.rc3.226.g39d4020

Re: [PATCH] Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This esnured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being used. Adding a message here in order to make this user visible.

[Greg KH]

On Tue, Jan 03, 2017 at 06:26:33AM -0800, Max Bires wrote:
> Signed-off-by: Max Bires <jbires@google.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/char/Kconfig | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Odd subject line :(

[PATCH] char: lack of bool string made CONFIG_DEVPORT always on

[Max Bires]

Without a bool string present, using "# CONFIG_DEVPORT is not set" in
defconfig files would not actually unset devport. This esnured that
/dev/port was always on, but there are reasons a user may wish to
disable it (smaller kernel, attack surface reduction) if it's not being
used. Adding a message here in order to make this user visible.

Signed-off-by: Max Bires <jbires@google.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/char/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index fde005e..4ee2a10 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -571,9 +571,12 @@ config TELCLOCK
 	  controlling the behavior of this hardware.
 
 config DEVPORT
-	bool
+	bool "/dev/port character device"
 	depends on ISA || PCI
 	default y
+	help
+	  Say Y here if you want to support the /dev/port device. The /dev/port
+	  device is similar to /dev/mem, but for I/O ports.
 
 source "drivers/s390/char/Kconfig"
 
-- 
2.8.0.rc3.226.g39d4020