* [PATCH] Staging: fbtft: hx8340bn: Style fix, octal not decimal permissions
@ 2017-01-04 1:20 Derek Robson
2017-01-04 9:41 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Derek Robson @ 2017-01-04 1:20 UTC (permalink / raw)
To: thomas.petazzoni; +Cc: noralf, gregkh, devel, linux-kernel, Derek Robson
Fixed coding style issue, found with Checkpatch.pl
changed permissions to octal style.
---
drivers/staging/fbtft/fb_hx8340bn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fb_hx8340bn.c b/drivers/staging/fbtft/fb_hx8340bn.c
index 9970ed74bb38..c24331cc179c 100644
--- a/drivers/staging/fbtft/fb_hx8340bn.c
+++ b/drivers/staging/fbtft/fb_hx8340bn.c
@@ -37,7 +37,7 @@
"3 3 17 8 4 7 05 7 6 0 3 1 6 0 0 "
static bool emulate;
-module_param(emulate, bool, 0);
+module_param(emulate, bool, 0000);
MODULE_PARM_DESC(emulate, "Force emulation in 9-bit mode");
static int init_display(struct fbtft_par *par)
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: fbtft: hx8340bn: Style fix, octal not decimal permissions
2017-01-04 1:20 [PATCH] Staging: fbtft: hx8340bn: Style fix, octal not decimal permissions Derek Robson
@ 2017-01-04 9:41 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2017-01-04 9:41 UTC (permalink / raw)
To: Derek Robson
Cc: Thomas Petazzoni, Noralf Trønnes, Greg Kroah-Hartman, devel,
linux-kernel@vger.kernel.org
On Wed, Jan 4, 2017 at 3:20 AM, Derek Robson <robsonde@gmail.com> wrote:
> Fixed coding style issue, found with Checkpatch.pl
> changed permissions to octal style.
You missed SoB.
> @@ -37,7 +37,7 @@
> "3 3 17 8 4 7 05 7 6 0 3 1 6 0 0 "
>
> static bool emulate;
> -module_param(emulate, bool, 0);
> +module_param(emulate, bool, 0000);
Why not to allow reading as well?
> MODULE_PARM_DESC(emulate, "Force emulation in 9-bit mode");
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-04 9:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-04 1:20 [PATCH] Staging: fbtft: hx8340bn: Style fix, octal not decimal permissions Derek Robson
2017-01-04 9:41 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.