From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v1 3/3] gpiolib: Convert fwnode_get_named_gpiod() to configure GPIO
Date: Wed, 4 Jan 2017 14:52:09 +0200 [thread overview]
Message-ID: <20170104125209.GT3353@lahna.fi.intel.com> (raw)
In-Reply-To: <20170103170119.35950-3-andriy.shevchenko@linux.intel.com>
On Tue, Jan 03, 2017 at 07:01:19PM +0200, Andy Shevchenko wrote:
> Make fwnode_get_named_gpiod() consistent with the rest of gpiod_get() like API,
> i.e. configure GPIO pin immediately after request.
>
> Besides obvious clean up it will help to configure pins based on firmware
> provided resources.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/gpio/devres.c | 9 +++++++--
> drivers/gpio/gpiolib.c | 20 ++++++++++++++++----
> drivers/input/keyboard/gpio_keys.c | 9 +--------
> drivers/input/keyboard/gpio_keys_polled.c | 11 ++---------
> drivers/leds/leds-gpio.c | 2 +-
> drivers/video/fbdev/amba-clcd-nomadik.c | 15 +++++----------
> include/linux/gpio/consumer.h | 19 +++++++++++++------
> 7 files changed, 45 insertions(+), 40 deletions(-)
>
> diff --git a/drivers/gpio/devres.c b/drivers/gpio/devres.c
> index 54da61112752..3da9c39fed04 100644
> --- a/drivers/gpio/devres.c
> +++ b/drivers/gpio/devres.c
> @@ -129,13 +129,18 @@ EXPORT_SYMBOL(devm_gpiod_get_index);
> * @dev: GPIO consumer
> * @con_id: function within the GPIO consumer
> * @child: firmware node (child of @dev)
> + * @flags: GPIO initialization flags
Please call this 'dflags' as it is called elsewhere as well.
Otherwise looks reasonable to me.
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2017-01-04 12:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 17:01 [PATCH v1 1/3] gpiolib: Switch to for_each_set_bit() Andy Shevchenko
2017-01-03 17:01 ` [PATCH v1 2/3] gpiolib: Update documentation of struct acpi_gpio_info Andy Shevchenko
2017-01-04 12:37 ` Mika Westerberg
2017-01-11 11:10 ` Linus Walleij
2017-01-03 17:01 ` [PATCH v1 3/3] gpiolib: Convert fwnode_get_named_gpiod() to configure GPIO Andy Shevchenko
2017-01-04 12:52 ` Mika Westerberg [this message]
2017-01-09 13:49 ` Andy Shevchenko
2017-01-09 13:59 ` Mika Westerberg
2017-01-04 12:58 ` [PATCH v1 1/3] gpiolib: Switch to for_each_set_bit() Mika Westerberg
2017-01-11 11:08 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104125209.GT3353@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.