From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v1 1/3] gpiolib: Switch to for_each_set_bit()
Date: Wed, 4 Jan 2017 14:58:39 +0200 [thread overview]
Message-ID: <20170104125839.GU3353@lahna.fi.intel.com> (raw)
In-Reply-To: <20170103170119.35950-1-andriy.shevchenko@linux.intel.com>
On Tue, Jan 03, 2017 at 07:01:17PM +0200, Andy Shevchenko wrote:
> The macro for_each_set_bit() effectively looks up to the next set bit in array
> of bits.
>
> Instead of open coding that switch to for_each_set_bit() in
> gpio_chip_set_multiple().
>
> While here, make gpio_chip_set_multiple() non-destructive against its
> parameters. We are safe since all callers, i.e.
> gpiod_set_array_value_complex(), handle that already.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2017-01-04 13:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 17:01 [PATCH v1 1/3] gpiolib: Switch to for_each_set_bit() Andy Shevchenko
2017-01-03 17:01 ` [PATCH v1 2/3] gpiolib: Update documentation of struct acpi_gpio_info Andy Shevchenko
2017-01-04 12:37 ` Mika Westerberg
2017-01-11 11:10 ` Linus Walleij
2017-01-03 17:01 ` [PATCH v1 3/3] gpiolib: Convert fwnode_get_named_gpiod() to configure GPIO Andy Shevchenko
2017-01-04 12:52 ` Mika Westerberg
2017-01-09 13:49 ` Andy Shevchenko
2017-01-09 13:59 ` Mika Westerberg
2017-01-04 12:58 ` Mika Westerberg [this message]
2017-01-11 11:08 ` [PATCH v1 1/3] gpiolib: Switch to for_each_set_bit() Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104125839.GU3353@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.