From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mailbox: sti: Fix mbox-names copy and paste error
Date: Wed, 4 Jan 2017 16:01:07 +0000 [thread overview]
Message-ID: <20170104160107.GD24225@dell> (raw)
In-Reply-To: <20170104145732.7yiqbi7rf7m6lem4@rob-hp-laptop>
On Wed, 04 Jan 2017, Rob Herring wrote:
> On Wed, Jan 04, 2017 at 12:05:27PM +0000, Lee Jones wrote:
> > Due to an over-sight, mbox-names has become mbox-name in some instances.
> >
> > Let's put it right.
> >
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > Documentation/devicetree/bindings/mailbox/sti-mailbox.txt | 4 ++--
> > arch/arm/boot/dts/stih407-family.dtsi | 8 ++++----
> > drivers/mailbox/mailbox-sti.c | 2 +-
> > 3 files changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt b/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt
> > index 351f612..648d176 100644
> > --- a/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt
> > +++ b/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt
> > @@ -9,7 +9,7 @@ Controller
> > Required properties:
> > - compatible : Should be "st,stih407-mailbox"
> > - reg : Offset and length of the device's register set
> > -- mbox-name : Name of the mailbox
> > +- mbox-names : Name of the mailbox
>
> It's worse than this. mbox-names is for the mailbox client side.
Ah yes, of course. False alarm.
Let's just leave it as it is. ;)
I'll reply to the reporter directly.
> This should just be dropped. Plus, *-names is pointless when there
> is only 1 element.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: patrice.chotard-qxv4g6HH51o@public.gmane.org,
jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-F5mvAk5X5gdBDgjK7y7TUQ@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] mailbox: sti: Fix mbox-names copy and paste error
Date: Wed, 4 Jan 2017 16:01:07 +0000 [thread overview]
Message-ID: <20170104160107.GD24225@dell> (raw)
In-Reply-To: <20170104145732.7yiqbi7rf7m6lem4@rob-hp-laptop>
On Wed, 04 Jan 2017, Rob Herring wrote:
> On Wed, Jan 04, 2017 at 12:05:27PM +0000, Lee Jones wrote:
> > Due to an over-sight, mbox-names has become mbox-name in some instances.
> >
> > Let's put it right.
> >
> > Signed-off-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > ---
> > Documentation/devicetree/bindings/mailbox/sti-mailbox.txt | 4 ++--
> > arch/arm/boot/dts/stih407-family.dtsi | 8 ++++----
> > drivers/mailbox/mailbox-sti.c | 2 +-
> > 3 files changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt b/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt
> > index 351f612..648d176 100644
> > --- a/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt
> > +++ b/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt
> > @@ -9,7 +9,7 @@ Controller
> > Required properties:
> > - compatible : Should be "st,stih407-mailbox"
> > - reg : Offset and length of the device's register set
> > -- mbox-name : Name of the mailbox
> > +- mbox-names : Name of the mailbox
>
> It's worse than this. mbox-names is for the mailbox client side.
Ah yes, of course. False alarm.
Let's just leave it as it is. ;)
I'll reply to the reporter directly.
> This should just be dropped. Plus, *-names is pointless when there
> is only 1 element.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: patrice.chotard@st.com, jassisinghbrar@gmail.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@stlinux.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH] mailbox: sti: Fix mbox-names copy and paste error
Date: Wed, 4 Jan 2017 16:01:07 +0000 [thread overview]
Message-ID: <20170104160107.GD24225@dell> (raw)
In-Reply-To: <20170104145732.7yiqbi7rf7m6lem4@rob-hp-laptop>
On Wed, 04 Jan 2017, Rob Herring wrote:
> On Wed, Jan 04, 2017 at 12:05:27PM +0000, Lee Jones wrote:
> > Due to an over-sight, mbox-names has become mbox-name in some instances.
> >
> > Let's put it right.
> >
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > Documentation/devicetree/bindings/mailbox/sti-mailbox.txt | 4 ++--
> > arch/arm/boot/dts/stih407-family.dtsi | 8 ++++----
> > drivers/mailbox/mailbox-sti.c | 2 +-
> > 3 files changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt b/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt
> > index 351f612..648d176 100644
> > --- a/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt
> > +++ b/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt
> > @@ -9,7 +9,7 @@ Controller
> > Required properties:
> > - compatible : Should be "st,stih407-mailbox"
> > - reg : Offset and length of the device's register set
> > -- mbox-name : Name of the mailbox
> > +- mbox-names : Name of the mailbox
>
> It's worse than this. mbox-names is for the mailbox client side.
Ah yes, of course. False alarm.
Let's just leave it as it is. ;)
I'll reply to the reporter directly.
> This should just be dropped. Plus, *-names is pointless when there
> is only 1 element.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-01-04 16:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 12:05 [PATCH] mailbox: sti: Fix mbox-names copy and paste error Lee Jones
2017-01-04 12:05 ` Lee Jones
2017-01-04 14:57 ` Rob Herring
2017-01-04 14:57 ` Rob Herring
2017-01-04 16:01 ` Lee Jones [this message]
2017-01-04 16:01 ` Lee Jones
2017-01-04 16:01 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104160107.GD24225@dell \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.