* [patch] platform/x86: mlx-platform: free first dev on error
@ 2017-01-07 6:33 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-01-07 6:33 UTC (permalink / raw)
To: Vadim Pasternak; +Cc: Darren Hart, platform-driver-x86, kernel-janitors
There is an off-by-one error so we don't unregister priv->pdev_mux[0].
Also it's slightly simpler as a while loop instead of a for loop.
Fixes: 58cbbee2391c ("x86/platform/mellanox: Introduce support for Mellanox systems platform")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c
index 04e1f2b30fa6..8f98c211b440 100644
--- a/drivers/platform/x86/mlx-platform.c
+++ b/drivers/platform/x86/mlx-platform.c
@@ -342,7 +342,7 @@ static int __init mlxplat_init(void)
return 0;
fail_platform_mux_register:
- for (i--; i > 0 ; i--)
+ while (--i >= 0)
platform_device_unregister(priv->pdev_mux[i]);
platform_device_unregister(priv->pdev_i2c);
fail_alloc:
^ permalink raw reply related [flat|nested] 4+ messages in thread* [patch] platform/x86: mlx-platform: free first dev on error
@ 2017-01-07 6:33 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-01-07 6:33 UTC (permalink / raw)
To: Vadim Pasternak; +Cc: Darren Hart, platform-driver-x86, kernel-janitors
There is an off-by-one error so we don't unregister priv->pdev_mux[0].
Also it's slightly simpler as a while loop instead of a for loop.
Fixes: 58cbbee2391c ("x86/platform/mellanox: Introduce support for Mellanox systems platform")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c
index 04e1f2b30fa6..8f98c211b440 100644
--- a/drivers/platform/x86/mlx-platform.c
+++ b/drivers/platform/x86/mlx-platform.c
@@ -342,7 +342,7 @@ static int __init mlxplat_init(void)
return 0;
fail_platform_mux_register:
- for (i--; i > 0 ; i--)
+ while (--i >= 0)
platform_device_unregister(priv->pdev_mux[i]);
platform_device_unregister(priv->pdev_i2c);
fail_alloc:
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [patch] platform/x86: mlx-platform: free first dev on error
2017-01-07 6:33 ` Dan Carpenter
@ 2017-01-07 8:02 ` Vadim Pasternak
-1 siblings, 0 replies; 4+ messages in thread
From: Vadim Pasternak @ 2017-01-07 8:02 UTC (permalink / raw)
To: Dan Carpenter
Cc: Darren Hart, platform-driver-x86@vger.kernel.org,
kernel-janitors@vger.kernel.org
> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Saturday, January 07, 2017 8:34 AM
> To: Vadim Pasternak <vadimp@mellanox.com>
> Cc: Darren Hart <dvhart@infradead.org>; platform-driver-
> x86@vger.kernel.org; kernel-janitors@vger.kernel.org
> Subject: [patch] platform/x86: mlx-platform: free first dev on error
>
> There is an off-by-one error so we don't unregister priv->pdev_mux[0].
> Also it's slightly simpler as a while loop instead of a for loop.
>
> Fixes: 58cbbee2391c ("x86/platform/mellanox: Introduce support for
> Mellanox systems platform")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Acked-by: Vadim Pasternak <vadimp@mellanox.com>
> diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-
> platform.c
> index 04e1f2b30fa6..8f98c211b440 100644
> --- a/drivers/platform/x86/mlx-platform.c
> +++ b/drivers/platform/x86/mlx-platform.c
> @@ -342,7 +342,7 @@ static int __init mlxplat_init(void)
> return 0;
>
> fail_platform_mux_register:
> - for (i--; i > 0 ; i--)
> + while (--i >= 0)
> platform_device_unregister(priv->pdev_mux[i]);
> platform_device_unregister(priv->pdev_i2c);
> fail_alloc:
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [patch] platform/x86: mlx-platform: free first dev on error
@ 2017-01-07 8:02 ` Vadim Pasternak
0 siblings, 0 replies; 4+ messages in thread
From: Vadim Pasternak @ 2017-01-07 8:02 UTC (permalink / raw)
To: Dan Carpenter
Cc: Darren Hart, platform-driver-x86@vger.kernel.org,
kernel-janitors@vger.kernel.org
> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Saturday, January 07, 2017 8:34 AM
> To: Vadim Pasternak <vadimp@mellanox.com>
> Cc: Darren Hart <dvhart@infradead.org>; platform-driver-
> x86@vger.kernel.org; kernel-janitors@vger.kernel.org
> Subject: [patch] platform/x86: mlx-platform: free first dev on error
>
> There is an off-by-one error so we don't unregister priv->pdev_mux[0].
> Also it's slightly simpler as a while loop instead of a for loop.
>
> Fixes: 58cbbee2391c ("x86/platform/mellanox: Introduce support for
> Mellanox systems platform")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Acked-by: Vadim Pasternak <vadimp@mellanox.com>
> diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-
> platform.c
> index 04e1f2b30fa6..8f98c211b440 100644
> --- a/drivers/platform/x86/mlx-platform.c
> +++ b/drivers/platform/x86/mlx-platform.c
> @@ -342,7 +342,7 @@ static int __init mlxplat_init(void)
> return 0;
>
> fail_platform_mux_register:
> - for (i--; i > 0 ; i--)
> + while (--i >= 0)
> platform_device_unregister(priv->pdev_mux[i]);
> platform_device_unregister(priv->pdev_i2c);
> fail_alloc:
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-07 8:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-07 6:33 [patch] platform/x86: mlx-platform: free first dev on error Dan Carpenter
2017-01-07 6:33 ` Dan Carpenter
2017-01-07 8:02 ` Vadim Pasternak
2017-01-07 8:02 ` Vadim Pasternak
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.