From: Leon Romanovsky <leonro@mellanox.com>
To: David Miller <davem@redhat.com>
Cc: eli@dev.mellanox.co.il, saeedm@mellanox.com, dledford@redhat.com,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
eli@mellanox.com, matanb@mellanox.com
Subject: Re: [for-next 07/10] IB/mlx5: Use blue flame register allocator in mlx5_ib
Date: Sun, 8 Jan 2017 08:22:57 +0200 [thread overview]
Message-ID: <20170108062257.GH15685@mtr-leonro.local> (raw)
In-Reply-To: <20170106.111131.1775665484264248231.davem@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]
On Fri, Jan 06, 2017 at 11:11:31AM -0500, David Miller wrote:
> From: Leon Romanovsky <leonro@mellanox.com>
> Date: Fri, 6 Jan 2017 08:06:09 +0200
>
> > On Thu, Jan 05, 2017 at 03:07:31PM -0500, David Miller wrote:
> >> From: Eli Cohen <eli@dev.mellanox.co.il>
> >> Date: Thu, 5 Jan 2017 14:03:18 -0600
> >>
> >> > If necessary I can make sure it builds on 32 bits as well.
> >>
> >> Please do.
> >
> > Dave,
> >
> > I'm failing to understand the benefits of building mlx5 on 32 bits, and
> > see only disadvantages:
> > * It is actual dead code without test coverage.
> > * It misleads reviewers/customers by seeing code for 32 bits.
> > * It adds compilation time for 32 bits platforms and "punishes" them
> > for not relevant for them driver.
> >
> > Why do you call removing all that as a "regression"?
>
> We have this thing called "CONFIG_COMPILE_TEST", it has tons of value,
> perhaps you've seen it before?
Thanks David,
I see your point.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Leon Romanovsky <leonro@mellanox.com>
To: David Miller <davem@redhat.com>
Cc: <eli@dev.mellanox.co.il>, <saeedm@mellanox.com>,
<dledford@redhat.com>, <netdev@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, <eli@mellanox.com>,
<matanb@mellanox.com>
Subject: Re: [for-next 07/10] IB/mlx5: Use blue flame register allocator in mlx5_ib
Date: Sun, 8 Jan 2017 08:22:57 +0200 [thread overview]
Message-ID: <20170108062257.GH15685@mtr-leonro.local> (raw)
In-Reply-To: <20170106.111131.1775665484264248231.davem@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]
On Fri, Jan 06, 2017 at 11:11:31AM -0500, David Miller wrote:
> From: Leon Romanovsky <leonro@mellanox.com>
> Date: Fri, 6 Jan 2017 08:06:09 +0200
>
> > On Thu, Jan 05, 2017 at 03:07:31PM -0500, David Miller wrote:
> >> From: Eli Cohen <eli@dev.mellanox.co.il>
> >> Date: Thu, 5 Jan 2017 14:03:18 -0600
> >>
> >> > If necessary I can make sure it builds on 32 bits as well.
> >>
> >> Please do.
> >
> > Dave,
> >
> > I'm failing to understand the benefits of building mlx5 on 32 bits, and
> > see only disadvantages:
> > * It is actual dead code without test coverage.
> > * It misleads reviewers/customers by seeing code for 32 bits.
> > * It adds compilation time for 32 bits platforms and "punishes" them
> > for not relevant for them driver.
> >
> > Why do you call removing all that as a "regression"?
>
> We have this thing called "CONFIG_COMPILE_TEST", it has tons of value,
> perhaps you've seen it before?
Thanks David,
I see your point.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-01-08 6:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 21:55 [for-next 00/10][pull request] Mellanox 100G mlx5 4K UAR support Saeed Mahameed
2017-01-03 21:55 ` [for-next 02/10] IB/mlx5: Fix error handling order in create_kernel_qp Saeed Mahameed
2017-01-03 21:55 ` [for-next 04/10] IB/mlx5: Fix retrieval of index to first hi class bfreg Saeed Mahameed
2017-01-03 21:55 ` [for-next 06/10] net/mlx5: Add interface to get reference to a UAR Saeed Mahameed
[not found] ` <1483480528-22622-1-git-send-email-saeedm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-01-03 21:55 ` [for-next 01/10] IB/mlx5: Fix kernel to user leak prevention logic Saeed Mahameed
2017-01-03 21:55 ` [for-next 03/10] mlx5: Fix naming convention with respect to UARs Saeed Mahameed
2017-01-03 21:55 ` [for-next 05/10] net/mlx5: Introduce blue flame register allocator Saeed Mahameed
2017-01-03 21:55 ` [for-next 07/10] IB/mlx5: Use blue flame register allocator in mlx5_ib Saeed Mahameed
[not found] ` <1483480528-22622-8-git-send-email-saeedm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-01-05 19:51 ` David Miller
[not found] ` <CAL3tnx4H2HsGMH=caiobivvvs0AU9yrzCmVONOdUQ_j_JMfufA@mail.gmail.com>
[not found] ` <CAL3tnx4H2HsGMH=caiobivvvs0AU9yrzCmVONOdUQ_j_JMfufA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-05 20:07 ` David Miller
2017-01-06 6:06 ` Leon Romanovsky
2017-01-06 6:06 ` Leon Romanovsky
[not found] ` <20170106060608.GG15685-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-01-06 16:11 ` David Miller
2017-01-08 6:22 ` Leon Romanovsky [this message]
2017-01-08 6:22 ` Leon Romanovsky
[not found] ` <20170108062257.GH15685-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-01-24 16:44 ` Doug Ledford
2017-01-24 17:16 ` Eli Cohen
[not found] ` <AM4PR0501MB2787B803D95B7575065CC497C5750-dp/nxUn679jFcPxmzbbP+MDSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-01-24 17:49 ` Doug Ledford
2017-01-03 21:55 ` [for-next 08/10] IB/mlx5: Allow future extension of libmlx5 input data Saeed Mahameed
2017-01-03 21:55 ` [for-next 10/10] net/mlx5: Activate support for 4K UARs Saeed Mahameed
2017-01-03 21:55 ` [for-next 09/10] IB/mlx5: Support 4k UAR for libmlx5 Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170108062257.GH15685@mtr-leonro.local \
--to=leonro@mellanox.com \
--cc=davem@redhat.com \
--cc=dledford@redhat.com \
--cc=eli@dev.mellanox.co.il \
--cc=eli@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.