From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH] nvme: use __iowrite64_copy for SQs in the CMB
Date: Sun, 8 Jan 2017 02:13:28 -0800 [thread overview]
Message-ID: <20170108101328.GF25268@infradead.org> (raw)
In-Reply-To: <CACtDJFcKB9r+Fzoo7+ewwEUR_qyt+mRxKU+JYyYXSmX6=mw5pA@mail.gmail.com>
On Wed, Jan 04, 2017@09:22:34AM +0200, Saar Gross wrote:
> As already mentioned: the current implementation uses memcpy() which
> is generic in nature, whereas the new implementation uses explicit
> 64-bit writes when possible.
> What else are you looking for?
Any explanation of why this would benefit the driver in practive.
You've now explained the mechanics of your change in detail, but still
haven't shown in numbers or bugs fixed.
Note that we currently don't use 64-bit MMIO writes in the NVMe driver
at all, as we work around buggy Apple controllers. This would be the
first one, and while I'm not against it at all, I'd rather have a good
reason to make the change instead of just having a drive-by patch in
the tree.
prev parent reply other threads:[~2017-01-08 10:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-23 19:30 [PATCH] nvme: use __iowrite64_copy for SQs in the CMB Saar Gross
2016-11-21 8:54 ` Saar Gross
2016-11-21 9:14 ` Christoph Hellwig
2016-11-22 2:43 ` Stephen Bates
2016-11-30 8:31 ` Saar Gross
2016-12-19 12:18 ` Saar Gross
2016-12-21 10:22 ` Christoph Hellwig
2017-01-04 7:22 ` Saar Gross
2017-01-08 10:13 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170108101328.GF25268@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.