All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: stable@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
	Dan Streetman <ddstreet@ieee.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, Michal Hocko <mhocko@suse.com>,
	Yu Zhao <yuzhao@google.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] stable-fixup: hotplug: fix unused function warning
Date: Mon, 9 Jan 2017 12:28:15 +0100	[thread overview]
Message-ID: <20170109112815.GA8187@kroah.com> (raw)
In-Reply-To: <20170109104811.1453295-1-arnd@arndb.de>

On Mon, Jan 09, 2017 at 11:47:50AM +0100, Arnd Bergmann wrote:
> The backport of upstream commit 777c6e0daebb ("hotplug: Make
> register and unregister notifier API symmetric") to linux-4.4.y
> introduced a harmless warning in 'allnoconfig' builds as spotted by
> kernelci.org:
> 
> kernel/cpu.c:226:13: warning: 'cpu_notify_nofail' defined but not used [-Wunused-function]
> 
> So far, this is the only stable tree that is affected, as linux-4.6 and
> higher contain commit 984581728eb4 ("cpu/hotplug: Split out cpu down functions")
> that makes the function used in all configurations, while older longterm
> releases so far don't seem to have a backport of 777c6e0daebb.
> 
> The fix for the warning is trivial: move the unused function back
> into the #ifdef section where it was before.
> 
> Link: https://kernelci.org/build/id/586fcacb59b514049ef6c3aa/logs/
> Fixes: 1c0f4e0ebb79 ("hotplug: Make register and unregister notifier API symmetric") in v4.4.y
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  kernel/cpu.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)

Thanks for this, now applied.

greg k-h

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: stable@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
	Dan Streetman <ddstreet@ieee.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, Michal Hocko <mhocko@suse.com>,
	Yu Zhao <yuzhao@google.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] stable-fixup: hotplug: fix unused function warning
Date: Mon, 9 Jan 2017 12:28:15 +0100	[thread overview]
Message-ID: <20170109112815.GA8187@kroah.com> (raw)
In-Reply-To: <20170109104811.1453295-1-arnd@arndb.de>

On Mon, Jan 09, 2017 at 11:47:50AM +0100, Arnd Bergmann wrote:
> The backport of upstream commit 777c6e0daebb ("hotplug: Make
> register and unregister notifier API symmetric") to linux-4.4.y
> introduced a harmless warning in 'allnoconfig' builds as spotted by
> kernelci.org:
> 
> kernel/cpu.c:226:13: warning: 'cpu_notify_nofail' defined but not used [-Wunused-function]
> 
> So far, this is the only stable tree that is affected, as linux-4.6 and
> higher contain commit 984581728eb4 ("cpu/hotplug: Split out cpu down functions")
> that makes the function used in all configurations, while older longterm
> releases so far don't seem to have a backport of 777c6e0daebb.
> 
> The fix for the warning is trivial: move the unused function back
> into the #ifdef section where it was before.
> 
> Link: https://kernelci.org/build/id/586fcacb59b514049ef6c3aa/logs/
> Fixes: 1c0f4e0ebb79 ("hotplug: Make register and unregister notifier API symmetric") in v4.4.y
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  kernel/cpu.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)

Thanks for this, now applied.

greg k-h

  parent reply	other threads:[~2017-01-09 11:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-09 10:47 [PATCH] stable-fixup: hotplug: fix unused function warning Arnd Bergmann
2017-01-09 10:47 ` Arnd Bergmann
2017-01-09 11:27 ` Patch "stable-fixup: hotplug: fix unused function warning" has been added to the 4.4-stable tree gregkh
2017-01-09 11:28 ` Greg Kroah-Hartman [this message]
2017-01-09 11:28   ` [PATCH] stable-fixup: hotplug: fix unused function warning Greg Kroah-Hartman
2017-01-09 11:29 ` Michal Hocko
2017-01-09 11:29   ` Michal Hocko
2017-01-09 11:47   ` Greg Kroah-Hartman
2017-01-09 11:47     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170109112815.GA8187@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=ddstreet@ieee.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=yuzhao@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.