From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Juergen Gross <JGross@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH] xenstore: bump TDB_VERSION
Date: Mon, 9 Jan 2017 15:22:48 +0000 [thread overview]
Message-ID: <20170109152247.GI1100@citrix.com> (raw)
In-Reply-To: <5873AEB4020000780012E354@prv-mh.provo.novell.com>
On Mon, Jan 09, 2017 at 07:39:32AM -0700, Jan Beulich wrote:
> Commit 9e49dcf67f ("xenstore: add per-node generation counter) changed
> the TDB layout, which - in order to not break older xenstored running
> on the same system - need to be accompanied by a version bump.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/tools/xenstore/tdb.c
> +++ b/tools/xenstore/tdb.c
> @@ -54,7 +54,7 @@
> #endif
>
> #define TDB_MAGIC_FOOD "TDB file\n"
> -#define TDB_VERSION (0x26011967 + 6)
> +#define TDB_VERSION (0x26011967 + 7)
After googling around I can't find how this macro is supposed to be used
in TDB.
Looking at the code in tdb.c this is used only to check if the dump is
of a certain version, so bumping this when the layout is changed seems
sensible.
But I haven't really read all the code in that area so a second opinion
would be much appreciated.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-01-09 15:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 14:39 [PATCH] xenstore: bump TDB_VERSION Jan Beulich
2017-01-09 15:22 ` Wei Liu [this message]
2017-01-09 16:24 ` Juergen Gross
2017-01-10 10:48 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109152247.GI1100@citrix.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=JGross@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.