* [PATCH] xenstore: bump TDB_VERSION
@ 2017-01-09 14:39 Jan Beulich
2017-01-09 15:22 ` Wei Liu
2017-01-09 16:24 ` Juergen Gross
0 siblings, 2 replies; 4+ messages in thread
From: Jan Beulich @ 2017-01-09 14:39 UTC (permalink / raw)
To: xen-devel; +Cc: Juergen Gross, Ian Jackson, Wei Liu
[-- Attachment #1: Type: text/plain, Size: 578 bytes --]
Commit 9e49dcf67f ("xenstore: add per-node generation counter) changed
the TDB layout, which - in order to not break older xenstored running
on the same system - need to be accompanied by a version bump.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/tools/xenstore/tdb.c
+++ b/tools/xenstore/tdb.c
@@ -54,7 +54,7 @@
#endif
#define TDB_MAGIC_FOOD "TDB file\n"
-#define TDB_VERSION (0x26011967 + 6)
+#define TDB_VERSION (0x26011967 + 7)
#define TDB_MAGIC (0x26011999U)
#define TDB_FREE_MAGIC (~TDB_MAGIC)
#define TDB_DEAD_MAGIC (0xFEE1DEAD)
[-- Attachment #2: xenstore-tdb-version.patch --]
[-- Type: text/plain, Size: 602 bytes --]
xenstore: bump TDB_VERSION
Commit 9e49dcf67f ("xenstore: add per-node generation counter) changed
the TDB layout, which - in order to not break older xenstored running
on the same system - need to be accompanied by a version bump.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/tools/xenstore/tdb.c
+++ b/tools/xenstore/tdb.c
@@ -54,7 +54,7 @@
#endif
#define TDB_MAGIC_FOOD "TDB file\n"
-#define TDB_VERSION (0x26011967 + 6)
+#define TDB_VERSION (0x26011967 + 7)
#define TDB_MAGIC (0x26011999U)
#define TDB_FREE_MAGIC (~TDB_MAGIC)
#define TDB_DEAD_MAGIC (0xFEE1DEAD)
[-- Attachment #3: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] xenstore: bump TDB_VERSION
2017-01-09 14:39 [PATCH] xenstore: bump TDB_VERSION Jan Beulich
@ 2017-01-09 15:22 ` Wei Liu
2017-01-09 16:24 ` Juergen Gross
1 sibling, 0 replies; 4+ messages in thread
From: Wei Liu @ 2017-01-09 15:22 UTC (permalink / raw)
To: Jan Beulich; +Cc: Juergen Gross, xen-devel, Wei Liu, Ian Jackson
On Mon, Jan 09, 2017 at 07:39:32AM -0700, Jan Beulich wrote:
> Commit 9e49dcf67f ("xenstore: add per-node generation counter) changed
> the TDB layout, which - in order to not break older xenstored running
> on the same system - need to be accompanied by a version bump.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/tools/xenstore/tdb.c
> +++ b/tools/xenstore/tdb.c
> @@ -54,7 +54,7 @@
> #endif
>
> #define TDB_MAGIC_FOOD "TDB file\n"
> -#define TDB_VERSION (0x26011967 + 6)
> +#define TDB_VERSION (0x26011967 + 7)
After googling around I can't find how this macro is supposed to be used
in TDB.
Looking at the code in tdb.c this is used only to check if the dump is
of a certain version, so bumping this when the layout is changed seems
sensible.
But I haven't really read all the code in that area so a second opinion
would be much appreciated.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] xenstore: bump TDB_VERSION
2017-01-09 14:39 [PATCH] xenstore: bump TDB_VERSION Jan Beulich
2017-01-09 15:22 ` Wei Liu
@ 2017-01-09 16:24 ` Juergen Gross
2017-01-10 10:48 ` Wei Liu
1 sibling, 1 reply; 4+ messages in thread
From: Juergen Gross @ 2017-01-09 16:24 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Wei Liu, Ian Jackson
On 09/01/17 15:39, Jan Beulich wrote:
> Commit 9e49dcf67f ("xenstore: add per-node generation counter) changed
> the TDB layout, which - in order to not break older xenstored running
> on the same system - need to be accompanied by a version bump.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Juergen Gross <jgross@suse.com>
>
> --- a/tools/xenstore/tdb.c
> +++ b/tools/xenstore/tdb.c
> @@ -54,7 +54,7 @@
> #endif
>
> #define TDB_MAGIC_FOOD "TDB file\n"
> -#define TDB_VERSION (0x26011967 + 6)
> +#define TDB_VERSION (0x26011967 + 7)
> #define TDB_MAGIC (0x26011999U)
> #define TDB_FREE_MAGIC (~TDB_MAGIC)
> #define TDB_DEAD_MAGIC (0xFEE1DEAD)
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] xenstore: bump TDB_VERSION
2017-01-09 16:24 ` Juergen Gross
@ 2017-01-10 10:48 ` Wei Liu
0 siblings, 0 replies; 4+ messages in thread
From: Wei Liu @ 2017-01-10 10:48 UTC (permalink / raw)
To: Juergen Gross; +Cc: xen-devel, Wei Liu, Ian Jackson, Jan Beulich
On Mon, Jan 09, 2017 at 05:24:14PM +0100, Juergen Gross wrote:
> On 09/01/17 15:39, Jan Beulich wrote:
> > Commit 9e49dcf67f ("xenstore: add per-node generation counter) changed
> > the TDB layout, which - in order to not break older xenstored running
> > on the same system - need to be accompanied by a version bump.
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Acked-by: Juergen Gross <jgross@suse.com>
Acked + applied.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-10 10:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-09 14:39 [PATCH] xenstore: bump TDB_VERSION Jan Beulich
2017-01-09 15:22 ` Wei Liu
2017-01-09 16:24 ` Juergen Gross
2017-01-10 10:48 ` Wei Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.