From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Fam Zheng <famz@redhat.com>,
QEMU Trivial <qemu-trivial@nongnu.org>,
"patches@linaro.org" <patches@linaro.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] disas/cris.c: Fix Coverity warning about unchecked NULL
Date: Mon, 9 Jan 2017 23:20:22 +0100 [thread overview]
Message-ID: <20170109222022.GW9606@toto> (raw)
In-Reply-To: <CAFEAcA-S6txZ79_N1PTzAGb0dQSV9zpQ-kKyjnYDyyZzsv_4Ug@mail.gmail.com>
On Mon, Jan 09, 2017 at 09:35:16PM +0000, Peter Maydell wrote:
> On 9 January 2017 at 19:10, <no-reply@patchew.org> wrote:
> > Checking PATCH 1/1: disas/cris.c: Fix Coverity warning about unchecked NULL...
> > ERROR: code indent should never use tabs
> > #24: FILE: disas/cris.c:2493:
> > +^Iif (sregp == NULL || sregp->name == NULL)$
> >
> > ERROR: suspect code indent for conditional statements (8, 10)
> > #24: FILE: disas/cris.c:2493:
> > + if (sregp == NULL || sregp->name == NULL)
> > /* Should have been caught as a non-match earlier. */
> >
> > ERROR: braces {} are necessary for all arms of this statement
> > #24: FILE: disas/cris.c:2493:
> > + if (sregp == NULL || sregp->name == NULL)
> > [...]
> >
> > total: 3 errors, 0 warnings, 8 lines checked
>
> This is because the whole file is GNU coding standards
> style, being a binutils import. Better to stick with it rather
> than rework, I think.
Yes, I agree.
Cheers,
Edgar
WARNING: multiple messages have this Message-ID (diff)
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Fam Zheng <famz@redhat.com>,
QEMU Trivial <qemu-trivial@nongnu.org>,
"patches@linaro.org" <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] disas/cris.c: Fix Coverity warning about unchecked NULL
Date: Mon, 9 Jan 2017 23:20:22 +0100 [thread overview]
Message-ID: <20170109222022.GW9606@toto> (raw)
In-Reply-To: <CAFEAcA-S6txZ79_N1PTzAGb0dQSV9zpQ-kKyjnYDyyZzsv_4Ug@mail.gmail.com>
On Mon, Jan 09, 2017 at 09:35:16PM +0000, Peter Maydell wrote:
> On 9 January 2017 at 19:10, <no-reply@patchew.org> wrote:
> > Checking PATCH 1/1: disas/cris.c: Fix Coverity warning about unchecked NULL...
> > ERROR: code indent should never use tabs
> > #24: FILE: disas/cris.c:2493:
> > +^Iif (sregp == NULL || sregp->name == NULL)$
> >
> > ERROR: suspect code indent for conditional statements (8, 10)
> > #24: FILE: disas/cris.c:2493:
> > + if (sregp == NULL || sregp->name == NULL)
> > /* Should have been caught as a non-match earlier. */
> >
> > ERROR: braces {} are necessary for all arms of this statement
> > #24: FILE: disas/cris.c:2493:
> > + if (sregp == NULL || sregp->name == NULL)
> > [...]
> >
> > total: 3 errors, 0 warnings, 8 lines checked
>
> This is because the whole file is GNU coding standards
> style, being a binutils import. Better to stick with it rather
> than rework, I think.
Yes, I agree.
Cheers,
Edgar
next prev parent reply other threads:[~2017-01-09 22:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 19:05 [Qemu-trivial] [PATCH] disas/cris.c: Fix Coverity warning about unchecked NULL Peter Maydell
2017-01-09 19:05 ` [Qemu-devel] " Peter Maydell
2017-01-09 19:10 ` [Qemu-trivial] " no-reply
2017-01-09 19:10 ` no-reply
2017-01-09 21:35 ` [Qemu-trivial] " Peter Maydell
2017-01-09 21:35 ` Peter Maydell
2017-01-09 22:20 ` Edgar E. Iglesias [this message]
2017-01-09 22:20 ` Edgar E. Iglesias
2017-01-09 20:13 ` [Qemu-trivial] " Edgar E. Iglesias
2017-01-09 20:13 ` [Qemu-devel] " Edgar E. Iglesias
2017-01-12 11:03 ` [Qemu-trivial] " Michael Tokarev
2017-01-12 11:03 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109222022.GW9606@toto \
--to=edgar.iglesias@gmail.com \
--cc=famz@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.