* [PATCH] clk: scpi: don't add cpufreq device if the scpi dvfs node is disabled
@ 2017-01-06 12:34 ` Sudeep Holla
0 siblings, 0 replies; 10+ messages in thread
From: Sudeep Holla @ 2017-01-06 12:34 UTC (permalink / raw)
To: linux-clk, Stephen Boyd, Michael Turquette
Cc: Sudeep Holla, linux-kernel, linux-arm-kernel, webczat_200,
Neil Armstrong
Currently we add the virtual cpufreq device unconditionally even when
the SCPI DVFS clock provider node is disabled. This will cause cpufreq
driver to throw errors when it gets initailised on boot/modprobe and
also when the CPUs are hot-plugged back in.
This patch fixes the issue by adding the virtual cpufreq device only if
the SCPI DVFS clock provider is available and registered.
Fixes: 9490f01e2471 ("clk: scpi: add support for cpufreq virtual device")
Reported-by: Michał Zegan <webczat_200@poczta.onet.pl>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
drivers/clk/clk-scpi.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/clk/clk-scpi.c b/drivers/clk/clk-scpi.c
index 2a3e9d8e88b0..96d37175d0ad 100644
--- a/drivers/clk/clk-scpi.c
+++ b/drivers/clk/clk-scpi.c
@@ -290,13 +290,15 @@ static int scpi_clocks_probe(struct platform_device *pdev)
of_node_put(child);
return ret;
}
- }
- /* Add the virtual cpufreq device */
- cpufreq_dev = platform_device_register_simple("scpi-cpufreq",
- -1, NULL, 0);
- if (IS_ERR(cpufreq_dev))
- pr_warn("unable to register cpufreq device");
+ if (match->data != &scpi_dvfs_ops)
+ continue;
+ /* Add the virtual cpufreq device if it's DVFS clock provider */
+ cpufreq_dev = platform_device_register_simple("scpi-cpufreq",
+ -1, NULL, 0);
+ if (IS_ERR(cpufreq_dev))
+ pr_warn("unable to register cpufreq device");
+ }
return 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] clk: scpi: don't add cpufreq device if the scpi dvfs node is disabled
@ 2017-01-06 12:34 ` Sudeep Holla
0 siblings, 0 replies; 10+ messages in thread
From: Sudeep Holla @ 2017-01-06 12:34 UTC (permalink / raw)
To: linux-arm-kernel
Currently we add the virtual cpufreq device unconditionally even when
the SCPI DVFS clock provider node is disabled. This will cause cpufreq
driver to throw errors when it gets initailised on boot/modprobe and
also when the CPUs are hot-plugged back in.
This patch fixes the issue by adding the virtual cpufreq device only if
the SCPI DVFS clock provider is available and registered.
Fixes: 9490f01e2471 ("clk: scpi: add support for cpufreq virtual device")
Reported-by: Micha? Zegan <webczat_200@poczta.onet.pl>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
drivers/clk/clk-scpi.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/clk/clk-scpi.c b/drivers/clk/clk-scpi.c
index 2a3e9d8e88b0..96d37175d0ad 100644
--- a/drivers/clk/clk-scpi.c
+++ b/drivers/clk/clk-scpi.c
@@ -290,13 +290,15 @@ static int scpi_clocks_probe(struct platform_device *pdev)
of_node_put(child);
return ret;
}
- }
- /* Add the virtual cpufreq device */
- cpufreq_dev = platform_device_register_simple("scpi-cpufreq",
- -1, NULL, 0);
- if (IS_ERR(cpufreq_dev))
- pr_warn("unable to register cpufreq device");
+ if (match->data != &scpi_dvfs_ops)
+ continue;
+ /* Add the virtual cpufreq device if it's DVFS clock provider */
+ cpufreq_dev = platform_device_register_simple("scpi-cpufreq",
+ -1, NULL, 0);
+ if (IS_ERR(cpufreq_dev))
+ pr_warn("unable to register cpufreq device");
+ }
return 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] clk: scpi: don't add cpufreq device if the scpi dvfs node is disabled
2017-01-06 12:34 ` Sudeep Holla
@ 2017-01-07 0:44 ` Michał Zegan
-1 siblings, 0 replies; 10+ messages in thread
From: Michał Zegan @ 2017-01-07 0:44 UTC (permalink / raw)
To: Sudeep Holla, linux-clk, Stephen Boyd, Michael Turquette
Cc: linux-kernel, linux-arm-kernel, Neil Armstrong
[-- Attachment #1.1: Type: text/plain, Size: 1831 bytes --]
seems the patch works as intended.
W dniu 06.01.2017 o 13:34, Sudeep Holla pisze:
> Currently we add the virtual cpufreq device unconditionally even when
> the SCPI DVFS clock provider node is disabled. This will cause cpufreq
> driver to throw errors when it gets initailised on boot/modprobe and
> also when the CPUs are hot-plugged back in.
>
> This patch fixes the issue by adding the virtual cpufreq device only if
> the SCPI DVFS clock provider is available and registered.
>
> Fixes: 9490f01e2471 ("clk: scpi: add support for cpufreq virtual device")
> Reported-by: Michał Zegan <webczat_200@poczta.onet.pl>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> drivers/clk/clk-scpi.c | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/clk/clk-scpi.c b/drivers/clk/clk-scpi.c
> index 2a3e9d8e88b0..96d37175d0ad 100644
> --- a/drivers/clk/clk-scpi.c
> +++ b/drivers/clk/clk-scpi.c
> @@ -290,13 +290,15 @@ static int scpi_clocks_probe(struct platform_device *pdev)
> of_node_put(child);
> return ret;
> }
> - }
> - /* Add the virtual cpufreq device */
> - cpufreq_dev = platform_device_register_simple("scpi-cpufreq",
> - -1, NULL, 0);
> - if (IS_ERR(cpufreq_dev))
> - pr_warn("unable to register cpufreq device");
>
> + if (match->data != &scpi_dvfs_ops)
> + continue;
> + /* Add the virtual cpufreq device if it's DVFS clock provider */
> + cpufreq_dev = platform_device_register_simple("scpi-cpufreq",
> + -1, NULL, 0);
> + if (IS_ERR(cpufreq_dev))
> + pr_warn("unable to register cpufreq device");
> + }
> return 0;
> }
>
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 525 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] clk: scpi: don't add cpufreq device if the scpi dvfs node is disabled
@ 2017-01-07 0:44 ` Michał Zegan
0 siblings, 0 replies; 10+ messages in thread
From: Michał Zegan @ 2017-01-07 0:44 UTC (permalink / raw)
To: linux-arm-kernel
seems the patch works as intended.
W dniu 06.01.2017 o 13:34, Sudeep Holla pisze:
> Currently we add the virtual cpufreq device unconditionally even when
> the SCPI DVFS clock provider node is disabled. This will cause cpufreq
> driver to throw errors when it gets initailised on boot/modprobe and
> also when the CPUs are hot-plugged back in.
>
> This patch fixes the issue by adding the virtual cpufreq device only if
> the SCPI DVFS clock provider is available and registered.
>
> Fixes: 9490f01e2471 ("clk: scpi: add support for cpufreq virtual device")
> Reported-by: Micha? Zegan <webczat_200@poczta.onet.pl>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> drivers/clk/clk-scpi.c | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/clk/clk-scpi.c b/drivers/clk/clk-scpi.c
> index 2a3e9d8e88b0..96d37175d0ad 100644
> --- a/drivers/clk/clk-scpi.c
> +++ b/drivers/clk/clk-scpi.c
> @@ -290,13 +290,15 @@ static int scpi_clocks_probe(struct platform_device *pdev)
> of_node_put(child);
> return ret;
> }
> - }
> - /* Add the virtual cpufreq device */
> - cpufreq_dev = platform_device_register_simple("scpi-cpufreq",
> - -1, NULL, 0);
> - if (IS_ERR(cpufreq_dev))
> - pr_warn("unable to register cpufreq device");
>
> + if (match->data != &scpi_dvfs_ops)
> + continue;
> + /* Add the virtual cpufreq device if it's DVFS clock provider */
> + cpufreq_dev = platform_device_register_simple("scpi-cpufreq",
> + -1, NULL, 0);
> + if (IS_ERR(cpufreq_dev))
> + pr_warn("unable to register cpufreq device");
> + }
> return 0;
> }
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 525 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170107/0969a2b2/attachment.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] clk: scpi: don't add cpufreq device if the scpi dvfs node is disabled
2017-01-07 0:44 ` Michał Zegan
@ 2017-01-09 9:58 ` Sudeep Holla
-1 siblings, 0 replies; 10+ messages in thread
From: Sudeep Holla @ 2017-01-09 9:58 UTC (permalink / raw)
To: Michał Zegan
Cc: linux-clk, Stephen Boyd, Michael Turquette, Sudeep Holla,
linux-kernel, linux-arm-kernel, Neil Armstrong
On 07/01/17 00:44, Michał Zegan wrote:
> seems the patch works as intended.
>
So, can we take this as
Tested-by: Michał Zegan <webczat_200@poczta.onet.pl> ?
> W dniu 06.01.2017 o 13:34, Sudeep Holla pisze:
>> Currently we add the virtual cpufreq device unconditionally even when
>> the SCPI DVFS clock provider node is disabled. This will cause cpufreq
>> driver to throw errors when it gets initailised on boot/modprobe and
>> also when the CPUs are hot-plugged back in.
>>
>> This patch fixes the issue by adding the virtual cpufreq device only if
>> the SCPI DVFS clock provider is available and registered.
>>
>> Fixes: 9490f01e2471 ("clk: scpi: add support for cpufreq virtual device")
>> Reported-by: Michał Zegan <webczat_200@poczta.onet.pl>
>> Cc: Neil Armstrong <narmstrong@baylibre.com>
>> Cc: Michael Turquette <mturquette@baylibre.com>
>> Cc: Stephen Boyd <sboyd@codeaurora.org>
>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] clk: scpi: don't add cpufreq device if the scpi dvfs node is disabled
@ 2017-01-09 9:58 ` Sudeep Holla
0 siblings, 0 replies; 10+ messages in thread
From: Sudeep Holla @ 2017-01-09 9:58 UTC (permalink / raw)
To: linux-arm-kernel
On 07/01/17 00:44, Micha? Zegan wrote:
> seems the patch works as intended.
>
So, can we take this as
Tested-by: Micha? Zegan <webczat_200@poczta.onet.pl> ?
> W dniu 06.01.2017 o 13:34, Sudeep Holla pisze:
>> Currently we add the virtual cpufreq device unconditionally even when
>> the SCPI DVFS clock provider node is disabled. This will cause cpufreq
>> driver to throw errors when it gets initailised on boot/modprobe and
>> also when the CPUs are hot-plugged back in.
>>
>> This patch fixes the issue by adding the virtual cpufreq device only if
>> the SCPI DVFS clock provider is available and registered.
>>
>> Fixes: 9490f01e2471 ("clk: scpi: add support for cpufreq virtual device")
>> Reported-by: Micha? Zegan <webczat_200@poczta.onet.pl>
>> Cc: Neil Armstrong <narmstrong@baylibre.com>
>> Cc: Michael Turquette <mturquette@baylibre.com>
>> Cc: Stephen Boyd <sboyd@codeaurora.org>
>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] clk: scpi: don't add cpufreq device if the scpi dvfs node is disabled
2017-01-09 9:58 ` Sudeep Holla
@ 2017-01-09 10:14 ` Michał Zegan
-1 siblings, 0 replies; 10+ messages in thread
From: Michał Zegan @ 2017-01-09 10:14 UTC (permalink / raw)
To: Sudeep Holla
Cc: linux-clk, Stephen Boyd, Michael Turquette, linux-kernel,
linux-arm-kernel, Neil Armstrong
[-- Attachment #1.1: Type: text/plain, Size: 1075 bytes --]
Of course.
W dniu 09.01.2017 o 10:58, Sudeep Holla pisze:
>
>
> On 07/01/17 00:44, Michał Zegan wrote:
>> seems the patch works as intended.
>>
>
> So, can we take this as
> Tested-by: Michał Zegan <webczat_200@poczta.onet.pl> ?
>
>> W dniu 06.01.2017 o 13:34, Sudeep Holla pisze:
>>> Currently we add the virtual cpufreq device unconditionally even when
>>> the SCPI DVFS clock provider node is disabled. This will cause cpufreq
>>> driver to throw errors when it gets initailised on boot/modprobe and
>>> also when the CPUs are hot-plugged back in.
>>>
>>> This patch fixes the issue by adding the virtual cpufreq device only if
>>> the SCPI DVFS clock provider is available and registered.
>>>
>>> Fixes: 9490f01e2471 ("clk: scpi: add support for cpufreq virtual device")
>>> Reported-by: Michał Zegan <webczat_200@poczta.onet.pl>
>>> Cc: Neil Armstrong <narmstrong@baylibre.com>
>>> Cc: Michael Turquette <mturquette@baylibre.com>
>>> Cc: Stephen Boyd <sboyd@codeaurora.org>
>>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 525 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] clk: scpi: don't add cpufreq device if the scpi dvfs node is disabled
@ 2017-01-09 10:14 ` Michał Zegan
0 siblings, 0 replies; 10+ messages in thread
From: Michał Zegan @ 2017-01-09 10:14 UTC (permalink / raw)
To: linux-arm-kernel
Of course.
W dniu 09.01.2017 o 10:58, Sudeep Holla pisze:
>
>
> On 07/01/17 00:44, Micha? Zegan wrote:
>> seems the patch works as intended.
>>
>
> So, can we take this as
> Tested-by: Micha? Zegan <webczat_200@poczta.onet.pl> ?
>
>> W dniu 06.01.2017 o 13:34, Sudeep Holla pisze:
>>> Currently we add the virtual cpufreq device unconditionally even when
>>> the SCPI DVFS clock provider node is disabled. This will cause cpufreq
>>> driver to throw errors when it gets initailised on boot/modprobe and
>>> also when the CPUs are hot-plugged back in.
>>>
>>> This patch fixes the issue by adding the virtual cpufreq device only if
>>> the SCPI DVFS clock provider is available and registered.
>>>
>>> Fixes: 9490f01e2471 ("clk: scpi: add support for cpufreq virtual device")
>>> Reported-by: Micha? Zegan <webczat_200@poczta.onet.pl>
>>> Cc: Neil Armstrong <narmstrong@baylibre.com>
>>> Cc: Michael Turquette <mturquette@baylibre.com>
>>> Cc: Stephen Boyd <sboyd@codeaurora.org>
>>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 525 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170109/26ff70dd/attachment.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] clk: scpi: don't add cpufreq device if the scpi dvfs node is disabled
2017-01-06 12:34 ` Sudeep Holla
@ 2017-01-10 0:08 ` Stephen Boyd
-1 siblings, 0 replies; 10+ messages in thread
From: Stephen Boyd @ 2017-01-10 0:08 UTC (permalink / raw)
To: Sudeep Holla
Cc: linux-clk, Michael Turquette, linux-kernel, linux-arm-kernel,
webczat_200, Neil Armstrong
On 01/06, Sudeep Holla wrote:
> Currently we add the virtual cpufreq device unconditionally even when
> the SCPI DVFS clock provider node is disabled. This will cause cpufreq
> driver to throw errors when it gets initailised on boot/modprobe and
> also when the CPUs are hot-plugged back in.
>
> This patch fixes the issue by adding the virtual cpufreq device only if
> the SCPI DVFS clock provider is available and registered.
>
> Fixes: 9490f01e2471 ("clk: scpi: add support for cpufreq virtual device")
> Reported-by: Michał Zegan <webczat_200@poczta.onet.pl>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] clk: scpi: don't add cpufreq device if the scpi dvfs node is disabled
@ 2017-01-10 0:08 ` Stephen Boyd
0 siblings, 0 replies; 10+ messages in thread
From: Stephen Boyd @ 2017-01-10 0:08 UTC (permalink / raw)
To: linux-arm-kernel
On 01/06, Sudeep Holla wrote:
> Currently we add the virtual cpufreq device unconditionally even when
> the SCPI DVFS clock provider node is disabled. This will cause cpufreq
> driver to throw errors when it gets initailised on boot/modprobe and
> also when the CPUs are hot-plugged back in.
>
> This patch fixes the issue by adding the virtual cpufreq device only if
> the SCPI DVFS clock provider is available and registered.
>
> Fixes: 9490f01e2471 ("clk: scpi: add support for cpufreq virtual device")
> Reported-by: Micha? Zegan <webczat_200@poczta.onet.pl>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-01-10 0:08 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-06 12:34 [PATCH] clk: scpi: don't add cpufreq device if the scpi dvfs node is disabled Sudeep Holla
2017-01-06 12:34 ` Sudeep Holla
2017-01-07 0:44 ` Michał Zegan
2017-01-07 0:44 ` Michał Zegan
2017-01-09 9:58 ` Sudeep Holla
2017-01-09 9:58 ` Sudeep Holla
2017-01-09 10:14 ` Michał Zegan
2017-01-09 10:14 ` Michał Zegan
2017-01-10 0:08 ` Stephen Boyd
2017-01-10 0:08 ` Stephen Boyd
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.