All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Jan Blunck <jblunck@infradead.org>
Cc: dev@dpdk.org, Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [PATCH 2/8] i40e: don't refer to eth_dev->pci_dev
Date: Tue, 10 Jan 2017 09:57:49 -0800	[thread overview]
Message-ID: <20170110095749.3cb00cab@xeon-e3> (raw)
In-Reply-To: <CALe+Z01UWj4pTK-9ciyoYsdddHv3+hOGYOf7CWNODnTMSWe57A@mail.gmail.com>

On Tue, 10 Jan 2017 13:08:30 +0100
Jan Blunck <jblunck@infradead.org> wrote:

> On Sat, Jan 7, 2017 at 7:17 PM, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> > Later patches remove pci_dev from the ethernet device structure.
> > Fix the i40e code to just use it's own name when forming zone name.
> >
> > Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> > ---
> >  drivers/net/i40e/i40e_fdir.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c
> > index 335bf15c..68a2523c 100644
> > --- a/drivers/net/i40e/i40e_fdir.c
> > +++ b/drivers/net/i40e/i40e_fdir.c
> > @@ -250,8 +250,7 @@ i40e_fdir_setup(struct i40e_pf *pf)
> >         }
> >
> >         /* reserve memory for the fdir programming packet */
> > -       snprintf(z_name, sizeof(z_name), "%s_%s_%d",
> > -                       eth_dev->driver->pci_drv.driver.name,
> > +       snprintf(z_name, sizeof(z_name), "i40e_%s_%d",  
> 
> The driver is called 'net_i40e'.

It really doesn't matter. The memory name is just so that primary and secondary
find the same resources.  Having net_ on the front doesn't change or help.

  reply	other threads:[~2017-01-10 17:58 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-07 18:17 [PATCH v2 0/8] device abstraction and VMBUS support infrastructure Stephen Hemminger
2017-01-07 18:17 ` [PATCH 1/8] ethdev: increase length ethernet device internal name Stephen Hemminger
2017-01-07 18:17 ` [PATCH 2/8] i40e: don't refer to eth_dev->pci_dev Stephen Hemminger
2017-01-10 12:08   ` Jan Blunck
2017-01-10 17:57     ` Stephen Hemminger [this message]
2017-01-11  7:55       ` Jan Blunck
2017-01-07 18:17 ` [PATCH 3/8] vmxnet3: " Stephen Hemminger
2017-01-10 12:10   ` Jan Blunck
2017-01-07 18:17 ` [PATCH 4/8] cxgbe: " Stephen Hemminger
2017-01-10 12:12   ` Jan Blunck
2017-01-07 18:17 ` [PATCH 5/8] nfp: " Stephen Hemminger
2017-01-10 12:13   ` Jan Blunck
2017-01-07 18:17 ` [PATCH 6/8] qat: " Stephen Hemminger
2017-01-10 12:15   ` Jan Blunck
2017-01-07 18:17 ` [PATCH 7/8] ethdev: break ethernet driver and pci_driver connection Stephen Hemminger
2017-01-10 13:59   ` Ferruh Yigit
2017-01-10 17:58     ` Ferruh Yigit
2017-01-10 18:02       ` [PATCH 1/2] add rte_bus->probe Ferruh Yigit
2017-01-10 18:02         ` [PATCH 2/2] separate bus and functionality driver structs Ferruh Yigit
2017-01-11  4:53         ` [PATCH 1/2] add rte_bus->probe Shreyansh Jain
2017-01-11 15:03           ` Ferruh Yigit
2017-01-12  5:28             ` Shreyansh Jain
2017-01-10 16:11   ` [PATCH 7/8] ethdev: break ethernet driver and pci_driver connection Jan Blunck
2017-01-10 18:03     ` Stephen Hemminger
2017-01-07 18:17 ` [PATCH 8/8] eal: VMBUS infrastructure Stephen Hemminger
2017-01-10 17:27   ` Jan Blunck
2017-01-10 18:05     ` Stephen Hemminger
2017-01-11 14:49   ` Jan Blunck
2017-01-11 21:13     ` Jan Blunck
2017-01-12  1:20       ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170110095749.3cb00cab@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=jblunck@infradead.org \
    --cc=sthemmin@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.