From: Stephen Hemminger <stephen@networkplumber.org>
To: Jan Blunck <jblunck@infradead.org>
Cc: dev@dpdk.org, Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [PATCH 7/8] ethdev: break ethernet driver and pci_driver connection
Date: Tue, 10 Jan 2017 10:03:21 -0800 [thread overview]
Message-ID: <20170110100321.4d53be0a@xeon-e3> (raw)
In-Reply-To: <CALe+Z00Whxvzbhcqyopt4KBNnEHk2+XZQCr4vvWua9WWUZofLA@mail.gmail.com>
On Tue, 10 Jan 2017 17:11:15 +0100
Jan Blunck <jblunck@infradead.org> wrote:
> On Sat, Jan 7, 2017 at 7:17 PM, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> > There are multiple buses and device types now. Therefore it no longer
> > makes sense that PCI driver information is part of the Ethernet driver
> > structure.
>
> The Ethernet driver itself doesn't over alot of value from an
> abstraction point of view. Its questionable if there ever will be an
> Ethernet driver that is able to operate on different types of
> low-level devices. The virtual devices are anyway able to operate
> without an Ethernet driver structure. Most of that functionality
> should get moved either into the bus abstraction or the low-level
> device probe function.
I agree that that 'struct eth_driver' is not adding a lot now.
It should really be all folded back into 'struct rte_driver'.
The concept of init, uninit and private data are all generic and not
really specific to ethernet in anyway.
If we kill off eth_driver then PCI devices only have rte_pci_driver
and VMBUS can have rte_vmbus_driver.
next prev parent reply other threads:[~2017-01-10 18:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-07 18:17 [PATCH v2 0/8] device abstraction and VMBUS support infrastructure Stephen Hemminger
2017-01-07 18:17 ` [PATCH 1/8] ethdev: increase length ethernet device internal name Stephen Hemminger
2017-01-07 18:17 ` [PATCH 2/8] i40e: don't refer to eth_dev->pci_dev Stephen Hemminger
2017-01-10 12:08 ` Jan Blunck
2017-01-10 17:57 ` Stephen Hemminger
2017-01-11 7:55 ` Jan Blunck
2017-01-07 18:17 ` [PATCH 3/8] vmxnet3: " Stephen Hemminger
2017-01-10 12:10 ` Jan Blunck
2017-01-07 18:17 ` [PATCH 4/8] cxgbe: " Stephen Hemminger
2017-01-10 12:12 ` Jan Blunck
2017-01-07 18:17 ` [PATCH 5/8] nfp: " Stephen Hemminger
2017-01-10 12:13 ` Jan Blunck
2017-01-07 18:17 ` [PATCH 6/8] qat: " Stephen Hemminger
2017-01-10 12:15 ` Jan Blunck
2017-01-07 18:17 ` [PATCH 7/8] ethdev: break ethernet driver and pci_driver connection Stephen Hemminger
2017-01-10 13:59 ` Ferruh Yigit
2017-01-10 17:58 ` Ferruh Yigit
2017-01-10 18:02 ` [PATCH 1/2] add rte_bus->probe Ferruh Yigit
2017-01-10 18:02 ` [PATCH 2/2] separate bus and functionality driver structs Ferruh Yigit
2017-01-11 4:53 ` [PATCH 1/2] add rte_bus->probe Shreyansh Jain
2017-01-11 15:03 ` Ferruh Yigit
2017-01-12 5:28 ` Shreyansh Jain
2017-01-10 16:11 ` [PATCH 7/8] ethdev: break ethernet driver and pci_driver connection Jan Blunck
2017-01-10 18:03 ` Stephen Hemminger [this message]
2017-01-07 18:17 ` [PATCH 8/8] eal: VMBUS infrastructure Stephen Hemminger
2017-01-10 17:27 ` Jan Blunck
2017-01-10 18:05 ` Stephen Hemminger
2017-01-11 14:49 ` Jan Blunck
2017-01-11 21:13 ` Jan Blunck
2017-01-12 1:20 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170110100321.4d53be0a@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=jblunck@infradead.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.