All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: davem@davemloft.net, sparclinux@vger.kernel.org, arnd@arndb.de,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sbus: char: Move D7S_MINOR to include/linux/miscdevice.h
Date: Tue, 10 Jan 2017 17:37:41 +0000	[thread overview]
Message-ID: <20170110173741.GC1340@kroah.com> (raw)
In-Reply-To: <20161215194703.11195-1-clabbe.montjoie@gmail.com>

On Thu, Dec 15, 2016 at 08:47:03PM +0100, Corentin Labbe wrote:
> This patch move the define for D7S_MINOR to include/linux/miscdevice.h.
> It's better that all minor number are in the same place.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
>  drivers/sbus/char/display7seg.c | 1 -
>  include/linux/miscdevice.h      | 1 +
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/sbus/char/display7seg.c b/drivers/sbus/char/display7seg.c
> index 33fbe82..48a5df0 100644
> --- a/drivers/sbus/char/display7seg.c
> +++ b/drivers/sbus/char/display7seg.c
> @@ -22,7 +22,6 @@
>  
>  #include <asm/display7seg.h>
>  
> -#define D7S_MINOR	193
>  #define DRIVER_NAME	"d7s"
>  #define PFX		DRIVER_NAME ": "
>  
> diff --git a/include/linux/miscdevice.h b/include/linux/miscdevice.h
> index 5385d95..b1ba37aef 100644
> --- a/include/linux/miscdevice.h
> +++ b/include/linux/miscdevice.h
> @@ -33,6 +33,7 @@
>  #define I2O_MINOR		166
>  #define HWRNG_MINOR		183
>  #define MICROCODE_MINOR		184
> +#define D7S_MINOR		193
>  #define VFIO_MINOR		196
>  #define TUN_MINOR		200
>  #define CUSE_MINOR		203
> -- 

Doesn't apply to my tree :(

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: davem@davemloft.net, sparclinux@vger.kernel.org, arnd@arndb.de,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sbus: char: Move D7S_MINOR to include/linux/miscdevice.h
Date: Tue, 10 Jan 2017 18:37:41 +0100	[thread overview]
Message-ID: <20170110173741.GC1340@kroah.com> (raw)
In-Reply-To: <20161215194703.11195-1-clabbe.montjoie@gmail.com>

On Thu, Dec 15, 2016 at 08:47:03PM +0100, Corentin Labbe wrote:
> This patch move the define for D7S_MINOR to include/linux/miscdevice.h.
> It's better that all minor number are in the same place.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
>  drivers/sbus/char/display7seg.c | 1 -
>  include/linux/miscdevice.h      | 1 +
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/sbus/char/display7seg.c b/drivers/sbus/char/display7seg.c
> index 33fbe82..48a5df0 100644
> --- a/drivers/sbus/char/display7seg.c
> +++ b/drivers/sbus/char/display7seg.c
> @@ -22,7 +22,6 @@
>  
>  #include <asm/display7seg.h>
>  
> -#define D7S_MINOR	193
>  #define DRIVER_NAME	"d7s"
>  #define PFX		DRIVER_NAME ": "
>  
> diff --git a/include/linux/miscdevice.h b/include/linux/miscdevice.h
> index 5385d95..b1ba37aef 100644
> --- a/include/linux/miscdevice.h
> +++ b/include/linux/miscdevice.h
> @@ -33,6 +33,7 @@
>  #define I2O_MINOR		166
>  #define HWRNG_MINOR		183
>  #define MICROCODE_MINOR		184
> +#define D7S_MINOR		193
>  #define VFIO_MINOR		196
>  #define TUN_MINOR		200
>  #define CUSE_MINOR		203
> -- 

Doesn't apply to my tree :(

  parent reply	other threads:[~2017-01-10 17:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-15 19:47 [PATCH] sbus: char: Move D7S_MINOR to include/linux/miscdevice.h Corentin Labbe
2016-12-15 19:47 ` Corentin Labbe
2016-12-17  1:05 ` Julian Calaby
2016-12-17  1:05   ` Julian Calaby
2017-01-10 17:37 ` Greg KH [this message]
2017-01-10 17:37   ` Greg KH
2017-09-18 18:10 ` Corentin Labbe
2017-09-18 18:10   ` Corentin Labbe
2017-09-28  4:52   ` David Miller
2017-09-28  4:52     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170110173741.GC1340@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=clabbe.montjoie@gmail.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.