From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: errata: Provide macro for major and minor cpu revisions
Date: Thu, 12 Jan 2017 15:33:15 +0000 [thread overview]
Message-ID: <20170112153315.GC13843@arm.com> (raw)
In-Reply-To: <20170111121143.9586-1-rrichter@cavium.com>
On Wed, Jan 11, 2017 at 01:11:42PM +0100, Robert Richter wrote:
> Definition of cpu ranges are hard to read if the cpu variant is not
> zero. Provide MIDR_CPU_FULL_REV() macro to describe the full hardware
> revision of a cpu including variant and (minor) revision.
>
> Signed-off-by: Robert Richter <rrichter@cavium.com>
> ---
> arch/arm64/include/asm/cputype.h | 3 +++
> arch/arm64/kernel/cpu_errata.c | 15 +++++++++------
> arch/arm64/kernel/cpufeature.c | 8 +++-----
> 3 files changed, 15 insertions(+), 11 deletions(-)
>
> diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
> index 26a68ddb11c1..983e59cbdd54 100644
> --- a/arch/arm64/include/asm/cputype.h
> +++ b/arch/arm64/include/asm/cputype.h
> @@ -56,6 +56,9 @@
> (0xf << MIDR_ARCHITECTURE_SHIFT) | \
> ((partnum) << MIDR_PARTNUM_SHIFT))
>
> +#define MIDR_CPU_FULL_REV(var, rev) \
> + (((var) << MIDR_VARIANT_SHIFT) | (rev))
Minor nit, but could you rename this to MIDR_CPU_VAR_REV instead please?
The revision field *is* the bottom 4 bits, so "full" rev doesn't really
make a lot of sense.
If you repost with that change, I'll pick it up for 4.11.
Thanks,
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Robert Richter <rrichter@cavium.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: errata: Provide macro for major and minor cpu revisions
Date: Thu, 12 Jan 2017 15:33:15 +0000 [thread overview]
Message-ID: <20170112153315.GC13843@arm.com> (raw)
In-Reply-To: <20170111121143.9586-1-rrichter@cavium.com>
On Wed, Jan 11, 2017 at 01:11:42PM +0100, Robert Richter wrote:
> Definition of cpu ranges are hard to read if the cpu variant is not
> zero. Provide MIDR_CPU_FULL_REV() macro to describe the full hardware
> revision of a cpu including variant and (minor) revision.
>
> Signed-off-by: Robert Richter <rrichter@cavium.com>
> ---
> arch/arm64/include/asm/cputype.h | 3 +++
> arch/arm64/kernel/cpu_errata.c | 15 +++++++++------
> arch/arm64/kernel/cpufeature.c | 8 +++-----
> 3 files changed, 15 insertions(+), 11 deletions(-)
>
> diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h
> index 26a68ddb11c1..983e59cbdd54 100644
> --- a/arch/arm64/include/asm/cputype.h
> +++ b/arch/arm64/include/asm/cputype.h
> @@ -56,6 +56,9 @@
> (0xf << MIDR_ARCHITECTURE_SHIFT) | \
> ((partnum) << MIDR_PARTNUM_SHIFT))
>
> +#define MIDR_CPU_FULL_REV(var, rev) \
> + (((var) << MIDR_VARIANT_SHIFT) | (rev))
Minor nit, but could you rename this to MIDR_CPU_VAR_REV instead please?
The revision field *is* the bottom 4 bits, so "full" rev doesn't really
make a lot of sense.
If you repost with that change, I'll pick it up for 4.11.
Thanks,
Will
next prev parent reply other threads:[~2017-01-12 15:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 12:11 [PATCH] arm64: errata: Provide macro for major and minor cpu revisions Robert Richter
2017-01-11 12:11 ` Robert Richter
2017-01-12 15:33 ` Will Deacon [this message]
2017-01-12 15:33 ` Will Deacon
2017-01-12 18:41 ` Robert Richter
2017-01-12 18:41 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112153315.GC13843@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.