From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/3] dmaengine: xilinx_dma: Check for channel idle state before submitting dma descriptor
Date: Fri, 13 Jan 2017 10:59:39 +0530 [thread overview]
Message-ID: <20170113052939.GP3573@localhost> (raw)
In-Reply-To: <C246CAC1457055469EF09E3A7AC4E11A4A666658@XAP-PVEXMBX01.xlnx.xilinx.com>
On Fri, Jan 13, 2017 at 04:28:11AM +0000, Appana Durga Kedareswara Rao wrote:
> Hi Vinod,
>
> Thanks for the review...
> >
> > On Sat, Jan 07, 2017 at 12:15:28PM +0530, Kedareswara rao Appana wrote:
> > > Add channel idle state to ensure that dma descriptor is not
> > > submitted when VDMA engine is in progress.
> >
> > any reason why you want to make your own varible and not use the HW to
> > query
> > as done earlier. It is not clear to me why that is removed from description
>
> We need to poll for a bit in the status register to know the dma state.
> We are currently doing that in the driver hot path
> To avoid this using own variables.
It would be worthwhile to document these, down the line people may not
remeber the motivation
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Appana Durga Kedareswara Rao <appana.durga.rao@xilinx.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"moritz.fischer@ettus.com" <moritz.fischer@ettus.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"michal.simek@xilinx.com" <michal.simek@xilinx.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Soren Brinkmann <sorenb@xilinx.com>,
"luis@debethencourt.com" <luis@debethencourt.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"Jose.Abreu@synopsys.com" <Jose.Abreu@synopsys.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"laurent.pinchart@ideasonboard.com"
<laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v5 1/3] dmaengine: xilinx_dma: Check for channel idle state before submitting dma descriptor
Date: Fri, 13 Jan 2017 10:59:39 +0530 [thread overview]
Message-ID: <20170113052939.GP3573@localhost> (raw)
In-Reply-To: <C246CAC1457055469EF09E3A7AC4E11A4A666658@XAP-PVEXMBX01.xlnx.xilinx.com>
On Fri, Jan 13, 2017 at 04:28:11AM +0000, Appana Durga Kedareswara Rao wrote:
> Hi Vinod,
>
> Thanks for the review...
> >
> > On Sat, Jan 07, 2017 at 12:15:28PM +0530, Kedareswara rao Appana wrote:
> > > Add channel idle state to ensure that dma descriptor is not
> > > submitted when VDMA engine is in progress.
> >
> > any reason why you want to make your own varible and not use the HW to
> > query
> > as done earlier. It is not clear to me why that is removed from description
>
> We need to poll for a bit in the status register to know the dma state.
> We are currently doing that in the driver hot path
> To avoid this using own variables.
It would be worthwhile to document these, down the line people may not
remeber the motivation
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Appana Durga Kedareswara Rao <appana.durga.rao@xilinx.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"michal.simek@xilinx.com" <michal.simek@xilinx.com>,
Soren Brinkmann <sorenb@xilinx.com>,
"moritz.fischer@ettus.com" <moritz.fischer@ettus.com>,
"laurent.pinchart@ideasonboard.com"
<laurent.pinchart@ideasonboard.com>,
"luis@debethencourt.com" <luis@debethencourt.com>,
"Jose.Abreu@synopsys.com" <Jose.Abreu@synopsys.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v5 1/3] dmaengine: xilinx_dma: Check for channel idle state before submitting dma descriptor
Date: Fri, 13 Jan 2017 10:59:39 +0530 [thread overview]
Message-ID: <20170113052939.GP3573@localhost> (raw)
In-Reply-To: <C246CAC1457055469EF09E3A7AC4E11A4A666658@XAP-PVEXMBX01.xlnx.xilinx.com>
On Fri, Jan 13, 2017 at 04:28:11AM +0000, Appana Durga Kedareswara Rao wrote:
> Hi Vinod,
>
> Thanks for the review...
> >
> > On Sat, Jan 07, 2017 at 12:15:28PM +0530, Kedareswara rao Appana wrote:
> > > Add channel idle state to ensure that dma descriptor is not
> > > submitted when VDMA engine is in progress.
> >
> > any reason why you want to make your own varible and not use the HW to
> > query
> > as done earlier. It is not clear to me why that is removed from description
>
> We need to poll for a bit in the status register to know the dma state.
> We are currently doing that in the driver hot path
> To avoid this using own variables.
It would be worthwhile to document these, down the line people may not
remeber the motivation
--
~Vinod
next prev parent reply other threads:[~2017-01-13 5:29 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-07 6:45 [PATCH v5 0/3] dmaengine: xilinx_dma: Bug fixes Kedareswara rao Appana
2017-01-07 6:45 ` Kedareswara rao Appana
2017-01-07 6:45 ` Kedareswara rao Appana
2017-01-07 6:45 ` [PATCH v5 1/3] dmaengine: xilinx_dma: Check for channel idle state before submitting dma descriptor Kedareswara rao Appana
2017-01-07 6:45 ` Kedareswara rao Appana
2017-01-07 6:45 ` Kedareswara rao Appana
2017-01-10 6:23 ` Vinod Koul
2017-01-10 6:23 ` Vinod Koul
2017-01-13 4:28 ` Appana Durga Kedareswara Rao
2017-01-13 4:28 ` Appana Durga Kedareswara Rao
2017-01-13 5:29 ` Vinod Koul [this message]
2017-01-13 5:29 ` Vinod Koul
2017-01-13 5:29 ` Vinod Koul
2017-01-13 5:32 ` Appana Durga Kedareswara Rao
2017-01-13 5:32 ` Appana Durga Kedareswara Rao
2017-01-13 5:32 ` Appana Durga Kedareswara Rao
2017-01-07 6:45 ` [PATCH v5 2/3] dmaeninge: xilinx_dma: Fix bug in multiple frame stores scenario in vdma Kedareswara rao Appana
2017-01-07 6:45 ` Kedareswara rao Appana
2017-01-07 6:45 ` Kedareswara rao Appana
2017-01-10 5:35 ` Rob Herring
2017-01-10 5:35 ` Rob Herring
2017-01-10 5:35 ` Rob Herring
2017-01-10 6:26 ` Vinod Koul
2017-01-10 6:26 ` Vinod Koul
2017-01-10 6:26 ` Vinod Koul
2017-01-12 14:19 ` Appana Durga Kedareswara Rao
2017-01-12 14:19 ` Appana Durga Kedareswara Rao
2017-01-12 14:19 ` Appana Durga Kedareswara Rao
2017-01-07 6:45 ` [PATCH v5 3/3] dmaengine: xilinx_dma: Fix race condition in the driver for multiple descriptor scenario Kedareswara rao Appana
2017-01-07 6:45 ` Kedareswara rao Appana
2017-01-07 6:45 ` Kedareswara rao Appana
2017-01-10 8:49 ` Vinod Koul
2017-01-10 8:49 ` Vinod Koul
2017-01-12 14:19 ` Appana Durga Kedareswara Rao
2017-01-12 14:19 ` Appana Durga Kedareswara Rao
2017-01-13 5:36 ` Vinod Koul
2017-01-13 5:36 ` Vinod Koul
2017-01-13 6:00 ` Appana Durga Kedareswara Rao
2017-01-13 6:00 ` Appana Durga Kedareswara Rao
2017-01-13 6:00 ` Appana Durga Kedareswara Rao
2017-01-13 6:22 ` Vinod Koul
2017-01-13 6:22 ` Vinod Koul
2017-01-13 6:33 ` Appana Durga Kedareswara Rao
2017-01-13 6:33 ` Appana Durga Kedareswara Rao
2017-01-13 6:33 ` Appana Durga Kedareswara Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170113052939.GP3573@localhost \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.