From: Mark Rutland <mark.rutland@arm.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH 2/3] KVM: arm64: Access CNTHCTL_EL2 bit fields correctly on VHE systems
Date: Fri, 13 Jan 2017 14:55:45 +0000 [thread overview]
Message-ID: <20170113145545.GD2472@leverpostej> (raw)
In-Reply-To: <20170113144204.GB2472@leverpostej>
On Fri, Jan 13, 2017 at 02:42:04PM +0000, Mark Rutland wrote:
> On Fri, Jan 13, 2017 at 01:30:29PM +0000, Marc Zyngier wrote:
> > On 13/01/17 12:36, Christoffer Dall wrote:
> > > Further, are we guaranteed that the static branch gets compiled into
> > > something that doesn't actually look at cpu_hwcap_keys, which is not
> > > mapped in hyp mode?
>
> If I disable CONFIG_JUMP_LABEL (which lives under "General setup", with
> teh title "Optimize very unlikely/likely branches"), I see adrp; add;
> ldr sequences accessing cpu_hwcap_keys when using cpus_have_const_cap()
> in hyp code, even with the patch below.
Looking again, that's the same sequence Marc mentioned, as it falls in
the BSS. I just happened to be looking at the unlinked .o file rather
than the vmlinux.
Sorry for the noise.
Thanks,
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] KVM: arm64: Access CNTHCTL_EL2 bit fields correctly on VHE systems
Date: Fri, 13 Jan 2017 14:55:45 +0000 [thread overview]
Message-ID: <20170113145545.GD2472@leverpostej> (raw)
In-Reply-To: <20170113144204.GB2472@leverpostej>
On Fri, Jan 13, 2017 at 02:42:04PM +0000, Mark Rutland wrote:
> On Fri, Jan 13, 2017 at 01:30:29PM +0000, Marc Zyngier wrote:
> > On 13/01/17 12:36, Christoffer Dall wrote:
> > > Further, are we guaranteed that the static branch gets compiled into
> > > something that doesn't actually look at cpu_hwcap_keys, which is not
> > > mapped in hyp mode?
>
> If I disable CONFIG_JUMP_LABEL (which lives under "General setup", with
> teh title "Optimize very unlikely/likely branches"), I see adrp; add;
> ldr sequences accessing cpu_hwcap_keys when using cpus_have_const_cap()
> in hyp code, even with the patch below.
Looking again, that's the same sequence Marc mentioned, as it falls in
the BSS. I just happened to be looking at the unlinked .o file rather
than the vmlinux.
Sorry for the noise.
Thanks,
Mark.
next prev parent reply other threads:[~2017-01-13 14:55 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 11:31 [PATCH 0/3] KVM/ARM updates for 4.10-rc4 Marc Zyngier
2017-01-13 11:31 ` Marc Zyngier
2017-01-13 11:31 ` [PATCH 1/3] KVM: arm/arm64: Fix occasional warning from the timer work function Marc Zyngier
2017-01-13 11:31 ` Marc Zyngier
2017-01-13 11:31 ` [PATCH 2/3] KVM: arm64: Access CNTHCTL_EL2 bit fields correctly on VHE systems Marc Zyngier
2017-01-13 11:31 ` Marc Zyngier
2017-01-13 12:36 ` Christoffer Dall
2017-01-13 12:36 ` Christoffer Dall
2017-01-13 13:30 ` Marc Zyngier
2017-01-13 13:30 ` Marc Zyngier
2017-01-13 13:46 ` Christoffer Dall
2017-01-13 13:46 ` Christoffer Dall
2017-01-13 13:57 ` Marc Zyngier
2017-01-13 13:57 ` Marc Zyngier
2017-01-13 14:14 ` Christoffer Dall
2017-01-13 14:14 ` Christoffer Dall
2017-01-13 14:42 ` Mark Rutland
2017-01-13 14:42 ` Mark Rutland
2017-01-13 14:55 ` Mark Rutland [this message]
2017-01-13 14:55 ` Mark Rutland
2017-01-13 14:56 ` Suzuki K Poulose
2017-01-13 14:56 ` Suzuki K Poulose
2017-01-13 19:04 ` Jintack Lim
2017-01-13 19:04 ` Jintack Lim
2017-01-16 13:30 ` Marc Zyngier
2017-01-16 13:30 ` Marc Zyngier
2017-01-16 14:11 ` Marc Zyngier
2017-01-16 14:11 ` Marc Zyngier
2017-01-16 14:19 ` Suzuki K Poulose
2017-01-16 14:19 ` Suzuki K Poulose
2017-01-13 14:46 ` Mark Rutland
2017-01-13 14:46 ` Mark Rutland
2017-01-13 14:57 ` Marc Zyngier
2017-01-13 14:57 ` Marc Zyngier
2017-01-13 11:31 ` [PATCH 3/3] KVM: arm/arm64: vgic: Fix deadlock on error handling Marc Zyngier
2017-01-13 11:31 ` Marc Zyngier
2017-01-17 16:49 ` [PATCH 0/3] KVM/ARM updates for 4.10-rc4 Radim Krčmář
2017-01-17 16:49 ` Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170113145545.GD2472@leverpostej \
--to=mark.rutland@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.