All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ivan Safonov <insafonov@gmail.com>
Cc: Kartikey singh <dr.kartikeynrc@gmail.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: staging: rtl8188eu: include: wifi: Unnecessary do-while removed from macro
Date: Sun, 15 Jan 2017 11:56:32 +0100	[thread overview]
Message-ID: <20170115105632.GB26374@kroah.com> (raw)
In-Reply-To: <3aae100e-7a1b-fbc7-4711-cc7b46edf02d@gmail.com>

On Sat, Jan 14, 2017 at 10:53:04PM +0300, Ivan Safonov wrote:
> On 01/14/2017 10:40 PM, Greg KH wrote:
> > On Sun, Jan 15, 2017 at 12:44:41AM +0530, Kartikey singh wrote:
> > Even better yet, remove it and rebuild the driver and see if it
> > breaks :)
> 
> Only if the code is not between #ifn?def / #endif...

Heh, fair enough, but it usually is a good sign if you do a build, along
with a search, that you are safe to remove something.

thanks,

greg k-h

      reply	other threads:[~2017-01-15 10:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-14 18:23 [PATCH] drivers: staging: rtl8188eu: include: wifi: Unnecessary do-while removed from macro Kartikey Singh
2017-01-14 18:38 ` Greg KH
2017-01-14 19:38   ` Kartikey Singh
2017-01-15 10:56     ` Greg KH
     [not found]   ` <CAOKLEkBoQrV_TE+61vD=43B8py21Moq-Tyczz+d=u8dTpbACkg@mail.gmail.com>
2017-01-14 19:40     ` Greg KH
2017-01-14 19:53       ` Ivan Safonov
2017-01-15 10:56         ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170115105632.GB26374@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=dr.kartikeynrc@gmail.com \
    --cc=insafonov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.