From: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
To: Lokesh Vutla <lokeshvutla-l0cyMroinI0@public.gmane.org>
Cc: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
Linux OMAP Mailing List
<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Device Tree Mailing List
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org>,
Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>,
Vignesh R <vigneshr-l0cyMroinI0@public.gmane.org>,
Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH 1/5] ARM: OMAP2+: omap_hwmod: Add support for earlycon
Date: Tue, 17 Jan 2017 10:47:03 +0000 [thread overview]
Message-ID: <20170117104703.GA11939@leverpostej> (raw)
In-Reply-To: <20170117040336.21700-2-lokeshvutla-l0cyMroinI0@public.gmane.org>
On Tue, Jan 17, 2017 at 09:33:32AM +0530, Lokesh Vutla wrote:
> Hwmod core tries to reset and idles each IP that is registered with hwmod.
> In case of earlycon, that specific uart IP cannot be reset or keep it in
> idle state else earlycon hangs once hwmod resets that uart IP. So add support
> to not reset uart that is being used as earlycon only if CONFIG_SERIAL_EARLYCON
> is enabled.
> + np = of_find_node_by_path("/chosen");
> + if (!np)
> + np = of_find_node_by_path("/chosen@0");
I think you can drop the second case here. There shouldn't be an "@0" on
a chosen node; core code handles that only to cater for some legacy
(PPC?) DTBs, and I don't beleive it's necessary for OMAP.
Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-01-17 10:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 4:03 [PATCH 0/5] ARM: OMAP2+: Add earlycon support Lokesh Vutla
[not found] ` <20170117040336.21700-1-lokeshvutla-l0cyMroinI0@public.gmane.org>
2017-01-17 4:03 ` [PATCH 1/5] ARM: OMAP2+: omap_hwmod: Add support for earlycon Lokesh Vutla
[not found] ` <20170117040336.21700-2-lokeshvutla-l0cyMroinI0@public.gmane.org>
2017-01-17 10:47 ` Mark Rutland [this message]
2017-01-17 13:47 ` Lokesh Vutla
2017-01-17 23:23 ` Tony Lindgren
[not found] ` <20170117232310.GX7403-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-01-18 3:47 ` Lokesh Vutla
[not found] ` <88830967-6e83-33fc-8a1c-d776fd694e2f-l0cyMroinI0@public.gmane.org>
2017-01-18 17:00 ` Tony Lindgren
[not found] ` <20170118170033.GD7403-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-01-19 10:05 ` Lokesh Vutla
[not found] ` <61578446-3a10-55ab-dac9-0a95b6e2c77c-l0cyMroinI0@public.gmane.org>
2017-01-19 14:56 ` Tony Lindgren
2017-01-17 4:03 ` [PATCH 2/5] ARM: dts: am33xx: Add stdout-path property Lokesh Vutla
2017-01-17 4:03 ` [PATCH 3/5] ARM: dts: am43xx: " Lokesh Vutla
2017-01-17 4:03 ` [PATCH 4/5] ARM: dts: am57xx: " Lokesh Vutla
2017-01-17 4:03 ` [PATCH 5/5] ARM: dts: dra7xx: " Lokesh Vutla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117104703.GA11939@leverpostej \
--to=mark.rutland-5wv7dgnigg8@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lokeshvutla-l0cyMroinI0@public.gmane.org \
--cc=nm-l0cyMroinI0@public.gmane.org \
--cc=nsekhar-l0cyMroinI0@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=t-kristo-l0cyMroinI0@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
--cc=vigneshr-l0cyMroinI0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.