Re: [PATCH 1/5] ARM: OMAP2+: omap_hwmod: Add support for earlycon

[Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>]

* Lokesh Vutla <lokeshvutla-l0cyMroinI0@public.gmane.org> [170119 02:08]:
> 
> 
> On Wednesday 18 January 2017 10:30 PM, Tony Lindgren wrote:
> > * Lokesh Vutla <lokeshvutla-l0cyMroinI0@public.gmane.org> [170117 19:50]:
> >>
> >>
> >> On Wednesday 18 January 2017 04:53 AM, Tony Lindgren wrote:
> >>> * Lokesh Vutla <lokeshvutla-l0cyMroinI0@public.gmane.org> [170116 20:06]:
> >>>> Hwmod core tries to reset and idles each IP that is registered with hwmod.
> >>>> In case of earlycon, that specific uart IP cannot be reset or keep it in
> >>>> idle state else earlycon hangs once hwmod resets that uart IP. So add support
> >>>> to not reset uart that is being used as earlycon only if CONFIG_SERIAL_EARLYCON
> >>>> is enabled.
> >>>
> >>> Nice :)
> >>>
> >>> I guess this has no dependency to SERIAL_OMAP vs 8250_OMAP selection?
> >>
> >> Unfortunately SERIAL_OMAP does not support earlycon yet. As I mentioned
> >> in my cover letter, I verified this series only with 8250_OMAP.
> > 
> > OK. So just to understand why it would not work with omap-serial, do we
> > need something implemented in drivers/tty/serial/earlycon.c for non 8250
> > drivers to make it work? Or are there other dependencies?
> 
> Yeah,  OF_EARLYCON_DECLARE should be declared for omap-serial. Just
> posted a patch[1] adding support for earlycon in omap-serial.

OK great. And with Vignesh's fix for omap5, I think we then have 8250-omap
and omap-serial behaving the same way on all SoC variants.

Regards,

Tony

> [1] https://patchwork.kernel.org/patch/9525377/

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html