From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@fb.com>,
linux-block@vger.kernel.org, Dexuan Cui <decui@microsoft.com>,
linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 3/4] nvme: use blk_rq_payload_bytes
Date: Wed, 18 Jan 2017 10:09:21 +0100 [thread overview]
Message-ID: <20170118090921.GA24058@lst.de> (raw)
In-Reply-To: <7532e18a-6cd3-294f-085d-e1ecdc48af6e@grimberg.me>
On Tue, Jan 17, 2017 at 10:06:51PM +0200, Sagi Grimberg wrote:
>
>> @@ -1014,9 +1013,9 @@ static int nvme_rdma_map_data(struct nvme_rdma_queue *queue,
>> }
>>
>
> Christoph, a little above here we still look at blk_rq_bytes(),
> shouldn't that look at blk_rq_payload_bytes() too?
The check is ok for now as it's just zero vs non-zero. It's somewhat
broken for Write Zeroes, though. I've fixed it in this series
which I need to submit:
http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/write-zeroes-take-2
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 3/4] nvme: use blk_rq_payload_bytes
Date: Wed, 18 Jan 2017 10:09:21 +0100 [thread overview]
Message-ID: <20170118090921.GA24058@lst.de> (raw)
In-Reply-To: <7532e18a-6cd3-294f-085d-e1ecdc48af6e@grimberg.me>
On Tue, Jan 17, 2017@10:06:51PM +0200, Sagi Grimberg wrote:
>
>> @@ -1014,9 +1013,9 @@ static int nvme_rdma_map_data(struct nvme_rdma_queue *queue,
>> }
>>
>
> Christoph, a little above here we still look at blk_rq_bytes(),
> shouldn't that look at blk_rq_payload_bytes() too?
The check is ok for now as it's just zero vs non-zero. It's somewhat
broken for Write Zeroes, though. I've fixed it in this series
which I need to submit:
http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/write-zeroes-take-2
next prev parent reply other threads:[~2017-01-18 9:09 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 11:29 fix data transfer size caculation for special payload requests Christoph Hellwig
2017-01-13 11:29 ` Christoph Hellwig
2017-01-13 11:29 ` [PATCH 1/4] block: add blk_rq_payload_bytes Christoph Hellwig
2017-01-13 11:29 ` Christoph Hellwig
2017-01-13 11:43 ` Hannes Reinecke
2017-01-13 11:43 ` Hannes Reinecke
2017-01-13 11:43 ` Hannes Reinecke
2017-01-13 21:52 ` Sagi Grimberg
2017-01-13 21:52 ` Sagi Grimberg
2017-01-13 11:29 ` [PATCH 2/4] scsi: use blk_rq_payload_bytes Christoph Hellwig
2017-01-13 11:29 ` Christoph Hellwig
2017-01-13 11:43 ` Hannes Reinecke
2017-01-13 11:43 ` Hannes Reinecke
2017-01-13 11:43 ` Hannes Reinecke
2017-01-13 21:52 ` Sagi Grimberg
2017-01-13 21:52 ` Sagi Grimberg
2017-01-13 11:29 ` [PATCH 3/4] nvme: " Christoph Hellwig
2017-01-13 11:29 ` Christoph Hellwig
2017-01-13 11:43 ` Hannes Reinecke
2017-01-13 11:43 ` Hannes Reinecke
2017-01-13 11:43 ` Hannes Reinecke
2017-01-13 21:54 ` Sagi Grimberg
2017-01-13 21:54 ` Sagi Grimberg
2017-01-17 20:06 ` Sagi Grimberg
2017-01-17 20:06 ` Sagi Grimberg
2017-01-17 20:06 ` Sagi Grimberg
2017-01-18 9:09 ` Christoph Hellwig [this message]
2017-01-18 9:09 ` Christoph Hellwig
2017-01-19 7:54 ` Sagi Grimberg
2017-01-19 7:54 ` Sagi Grimberg
2017-01-13 11:29 ` [PATCH 4/4] sd: remove __data_len hack for WRITE SAME Christoph Hellwig
2017-01-13 11:29 ` Christoph Hellwig
2017-01-13 11:44 ` Hannes Reinecke
2017-01-13 11:44 ` Hannes Reinecke
2017-01-13 11:44 ` Hannes Reinecke
2017-01-13 21:56 ` Sagi Grimberg
2017-01-13 21:56 ` Sagi Grimberg
2017-01-13 22:17 ` fix data transfer size caculation for special payload requests Jens Axboe
2017-01-13 22:17 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118090921.GA24058@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=decui@microsoft.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.