From: Yuval Shaia <yuval.shaia@oracle.com>
To: Shiraz Saleem <shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH] i40iw: Set maj_err and min_err in i40iw_sc_cqp_create
Date: Wed, 18 Jan 2017 19:54:34 +0000 [thread overview]
Message-ID: <20170118195433.GA17688@yuval-lap> (raw)
In-Reply-To: <1484761709-6072-1-git-send-email-shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Wed, Jan 18, 2017 at 11:48:29AM -0600, Shiraz Saleem wrote:
> Set maj_err and min_err in i40iw_sc_cqp_create so that it
> returns correct values for all return cases. This also
> addresses an uninitialized variable warning for maj_err and
> min_err in i40iw_create_cqp.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reported-by: Yuval Shaia <yuval.shaia@oracle.com>
> Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>
> ---
> drivers/infiniband/hw/i40iw/i40iw_ctrl.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> index 2c4b4d0..47a2529 100644
> --- a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> +++ b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> @@ -315,6 +315,9 @@ static enum i40iw_status_code i40iw_sc_cqp_create(struct i40iw_sc_cqp *cqp,
> u32 cnt = 0, p1, p2, val = 0, err_code;
> enum i40iw_status_code ret_code;
>
> + *maj_err = 0;
> + *min_err = 0;
> +
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
> ret_code = i40iw_allocate_dma_mem(cqp->dev->hw,
> &cqp->sdbuf,
> 128,
> --
> 2.8.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Shiraz Saleem <shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH] i40iw: Set maj_err and min_err in i40iw_sc_cqp_create
Date: Wed, 18 Jan 2017 21:54:34 +0200 [thread overview]
Message-ID: <20170118195433.GA17688@yuval-lap> (raw)
In-Reply-To: <1484761709-6072-1-git-send-email-shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Wed, Jan 18, 2017 at 11:48:29AM -0600, Shiraz Saleem wrote:
> Set maj_err and min_err in i40iw_sc_cqp_create so that it
> returns correct values for all return cases. This also
> addresses an uninitialized variable warning for maj_err and
> min_err in i40iw_create_cqp.
>
> Reported-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> Reported-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Shiraz Saleem <shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
> drivers/infiniband/hw/i40iw/i40iw_ctrl.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> index 2c4b4d0..47a2529 100644
> --- a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> +++ b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
> @@ -315,6 +315,9 @@ static enum i40iw_status_code i40iw_sc_cqp_create(struct i40iw_sc_cqp *cqp,
> u32 cnt = 0, p1, p2, val = 0, err_code;
> enum i40iw_status_code ret_code;
>
> + *maj_err = 0;
> + *min_err = 0;
> +
Reviewed-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> ret_code = i40iw_allocate_dma_mem(cqp->dev->hw,
> &cqp->sdbuf,
> 128,
> --
> 2.8.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-01-18 19:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 17:48 [PATCH] i40iw: Set maj_err and min_err in i40iw_sc_cqp_create Shiraz Saleem
2017-01-18 17:48 ` Shiraz Saleem
[not found] ` <1484761709-6072-1-git-send-email-shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-01-18 19:54 ` Yuval Shaia [this message]
2017-01-18 19:54 ` Yuval Shaia
2017-01-24 21:23 ` Doug Ledford
2017-01-24 21:23 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118195433.GA17688@yuval-lap \
--to=yuval.shaia@oracle.com \
--cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.