[PATCH] drivers: staging: Fix "space required after that ','" errors

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH] drivers: staging: Fix "space required after that ','" errors
@ 2017-01-17 17:26 simran singhal
  2017-01-19  9:40 ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: simran singhal @ 2017-01-17 17:26 UTC (permalink / raw)
  To: gregkh; +Cc: linux-kernel, devel

Fix checkpatch.pl "space required after that ','" errors

Signed-off-by: simran singhal <singhalsimran0@gmail.com>

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
index d7d85b3..6380b41 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
@@ -3177,7 +3177,7 @@ int ieee80211_wpa_supplicant_ioctl(struct ieee80211_device *ieee, struct iw_poin
 		break;

 	default:
-		printk("Unknown WPA supplicant request: %d\n",param->cmd);
+		printk("Unknown WPA supplicant request: %d\n", param->cmd);
 		ret = -EOPNOTSUPP;
 		break;
 	}
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
index d7d85b3..6380b41 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
@@ -3177,7 +3177,7 @@ int ieee80211_wpa_supplicant_ioctl(struct ieee80211_device *ieee, struct iw_poin
 		break;
 
 	default:
-		printk("Unknown WPA supplicant request: %d\n",param->cmd);
+		printk("Unknown WPA supplicant request: %d\n", param->cmd);
 		ret = -EOPNOTSUPP;
 		break;
 	}
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] drivers: staging: Fix "space required after that ','" errors
  2017-01-17 17:26 [PATCH] drivers: staging: Fix "space required after that ','" errors simran singhal
@ 2017-01-19  9:40 ` Greg KH
  0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2017-01-19  9:40 UTC (permalink / raw)
  To: simran singhal; +Cc: linux-kernel, devel

On Tue, Jan 17, 2017 at 10:56:31PM +0530, simran singhal wrote:
> Fix checkpatch.pl "space required after that ','" errors
> 
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> index d7d85b3..6380b41 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> @@ -3177,7 +3177,7 @@ int ieee80211_wpa_supplicant_ioctl(struct ieee80211_device *ieee, struct iw_poin
>  		break;
> 
>  	default:
> -		printk("Unknown WPA supplicant request: %d\n",param->cmd);
> +		printk("Unknown WPA supplicant request: %d\n", param->cmd);
>  		ret = -EOPNOTSUPP;
>  		break;
>  	}
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> index d7d85b3..6380b41 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> @@ -3177,7 +3177,7 @@ int ieee80211_wpa_supplicant_ioctl(struct ieee80211_device *ieee, struct iw_poin
>  		break;
>  
>  	default:
> -		printk("Unknown WPA supplicant request: %d\n",param->cmd);
> +		printk("Unknown WPA supplicant request: %d\n", param->cmd);
>  		ret = -EOPNOTSUPP;
>  		break;
>  	}
> -- 
> 2.7.4

You seem to have duplicated the patch twice here, please fix up and
resend.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] drivers: staging: Fix "space required after that ','" errors
@ 2017-01-17 17:28 simran singhal
  0 siblings, 0 replies; 4+ messages in thread
From: simran singhal @ 2017-01-17 17:28 UTC (permalink / raw)
  To: outreachy-kernel

Fix checkpatch.pl "space required after that ','" errors

Signed-off-by: simran singhal <singhalsimran0@gmail.com>

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
index d7d85b3..6380b41 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
@@ -3177,7 +3177,7 @@ int ieee80211_wpa_supplicant_ioctl(struct ieee80211_device *ieee, struct iw_poin
 		break;

 	default:
-		printk("Unknown WPA supplicant request: %d\n",param->cmd);
+		printk("Unknown WPA supplicant request: %d\n", param->cmd);
 		ret = -EOPNOTSUPP;
 		break;
 	}
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
index d7d85b3..6380b41 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
@@ -3177,7 +3177,7 @@ int ieee80211_wpa_supplicant_ioctl(struct ieee80211_device *ieee, struct iw_poin
 		break;
 
 	default:
-		printk("Unknown WPA supplicant request: %d\n",param->cmd);
+		printk("Unknown WPA supplicant request: %d\n", param->cmd);
 		ret = -EOPNOTSUPP;
 		break;
 	}
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 4+ messages in thread

[parent not found: <20170117163523.GA18643@singhal-Inspiron-5558>]

[parent not found: <20170117163806.GA9147@kroah.com>]

[parent not found: <CALrZqyO=O=zu6XRsC=+DaFR4=tCjr2GTjC+ep=0K4A2YEXEFzg@mail.gmail.com>]

[parent not found: <CALrZqyPW2ou_krA2C=HsqM0bkDEPOk_ENZi_otN+zOMJFnv9Aw@mail.gmail.com>]

* Re: [PATCH] drivers: staging: Fix "space required after that ','" errors
       [not found]     ` <CALrZqyPW2ou_krA2C=HsqM0bkDEPOk_ENZi_otN+zOMJFnv9Aw@mail.gmail.com>
@ 2017-01-18  7:08       ` Vaishali Thakkar
  0 siblings, 0 replies; 4+ messages in thread
From: Vaishali Thakkar @ 2017-01-18  7:08 UTC (permalink / raw)
  To: SIMRAN SINGHAL; +Cc: outreachy-kernel, Christian Gromm

On Wed, Jan 18, 2017 at 12:28 AM, SIMRAN SINGHAL
<singhalsimran0@gmail.com> wrote:
> Hi,
>
>  I am doing what is given on FirstPatchTutorial. I am attaching the
> screenshot of what I got after running the script.

Please cc outreachy-mailing list for this thread.

> I will be thankful if you tell me the mailing lists I have to cc.

Ok. Looking at the Maintainers file, it seems that maintainers entry is not
yet added for drivers/staging/most driver(s). That's why it shows Greg as
a result.

I've CC'ed Christian who seems to be the person of contact for these drivers
[from TODO file].

Christian, can you please send a patch to add a Maintainers entry
for drivers/staging/most/ ?

Simran, you can may be try sending patches for other files to the mailing list
and maintainers based on the result of get_maintainer.pl.

> Thanks,
> Simran Singhal
>

-- 
Vaishali
http://vaishalithakkar.in/

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-01-19  9:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-17 17:26 [PATCH] drivers: staging: Fix "space required after that ','" errors simran singhal
2017-01-19  9:40 ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2017-01-17 17:28 simran singhal
     [not found] <20170117163523.GA18643@singhal-Inspiron-5558>
     [not found] ` <20170117163806.GA9147@kroah.com>
     [not found]   ` <CALrZqyO=O=zu6XRsC=+DaFR4=tCjr2GTjC+ep=0K4A2YEXEFzg@mail.gmail.com>
     [not found]     ` <CALrZqyPW2ou_krA2C=HsqM0bkDEPOk_ENZi_otN+zOMJFnv9Aw@mail.gmail.com>
2017-01-18  7:08       ` Vaishali Thakkar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.