All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-ide@vger.kernel.org
Subject: Re: command emulation fix
Date: Thu, 19 Jan 2017 15:23:16 -0500	[thread overview]
Message-ID: <20170119202316.GA25390@mtj.duckdns.org> (raw)
In-Reply-To: <20170119143551.GA31203@lst.de>

Hello, Christoph.

On Thu, Jan 19, 2017 at 03:35:51PM +0100, Christoph Hellwig wrote:
> On Wed, Jan 18, 2017 at 11:17:50AM -0800, Tejun Heo wrote:
> > I reverted just the last patch.  The rest should be fine, right?
> 
> Yes.  And personally I think the last one is also fine, but we
> seem to disagree.

Yeah, it is probably fine but I just feel weird about changing the
code to introduce a possible failure case.  Let's leave it as-is for
now.

Thanks.

-- 
tejun

  reply	other threads:[~2017-01-19 20:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-14 16:50 command emulation fix Christoph Hellwig
2017-01-14 16:50 ` [PATCH] libata: switch allocations for command emulation to GFP_ATOMIC Christoph Hellwig
2017-01-15 23:07 ` command emulation fix Tejun Heo
2017-01-16 15:21   ` Christoph Hellwig
2017-01-18 19:17     ` Tejun Heo
2017-01-19 14:35       ` Christoph Hellwig
2017-01-19 20:23         ` Tejun Heo [this message]
2017-01-19 20:27           ` Christoph Hellwig
2017-01-19 20:34             ` Tejun Heo
2017-01-19 20:36               ` Tejun Heo
2017-01-19 20:41                 ` Christoph Hellwig
2017-01-19 20:45                   ` Tejun Heo
2017-01-19 20:40               ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170119202316.GA25390@mtj.duckdns.org \
    --to=tj@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.