All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 0/2] Add support for the ethernet switch on the ESPRESSObin
Date: Fri, 20 Jan 2017 23:38:23 +0100	[thread overview]
Message-ID: <20170120223823.GA25240@lunn.ch> (raw)
In-Reply-To: <87a8al64mp.fsf@free-electrons.com>

> Actually I didn't find anything related to the temperature measurement
> in the datasheet I have. For the 6390 there is a dedicated datsheet for
> the PHY part for the 6352 it is part of the same datasheet.

Hi Gregory

The temperature sensor changes have landed in net-next. If you have
time, please rebase to it and do some tests. Here are the likely
outcomes:

1) Like the 6390, it does not have a valid PHY product ID. Hence the
Marvell PHY driver is not loaded. You can see the PHY ID in

/sys/bus/mdio_bus/devices/*/phy_id

If it is 0x01410000, there is no product ID. I have a workaround for
this.

2) It has a valid phy_id, but it is not known to the marvell driver.
Add an entry to the table at the bottom of drivers/net/phy/marvell.c,
and a new entry in marvell_drivers. I would copy the 1540.


3) The Marvell PHY driver does recognise it, and makes the temperature
available in /sys/class/hwmon/hwmon*/temp1_input. It always returns
-25000mC. Same problem i have with the 6390. No idea how to fix it yet.

4) The Marvell PHY driver does recognise it, and makes the temperature
available in /sys/class/hwmon/hwmon*/temp1_input. The value is O.K. It
all works :-)

Personally, i'm not betting on 4 :-)


    Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Jason Cooper <jason@lakedaemon.net>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	linux-arm-kernel@lists.infradead.org,
	Nadav Haklai <nadavh@marvell.com>,
	Wilson Ding <dingwei@marvell.com>,
	Kostya Porotchkin <kostap@marvell.com>,
	Joe Zhou <shjzhou@marvell.com>,
	Jon Pannell <jpannell@marvell.com>
Subject: Re: [PATCH v5 0/2] Add support for the ethernet switch on the ESPRESSObin
Date: Fri, 20 Jan 2017 23:38:23 +0100	[thread overview]
Message-ID: <20170120223823.GA25240@lunn.ch> (raw)
In-Reply-To: <87a8al64mp.fsf@free-electrons.com>

> Actually I didn't find anything related to the temperature measurement
> in the datasheet I have. For the 6390 there is a dedicated datsheet for
> the PHY part for the 6352 it is part of the same datasheet.

Hi Gregory

The temperature sensor changes have landed in net-next. If you have
time, please rebase to it and do some tests. Here are the likely
outcomes:

1) Like the 6390, it does not have a valid PHY product ID. Hence the
Marvell PHY driver is not loaded. You can see the PHY ID in

/sys/bus/mdio_bus/devices/*/phy_id

If it is 0x01410000, there is no product ID. I have a workaround for
this.

2) It has a valid phy_id, but it is not known to the marvell driver.
Add an entry to the table at the bottom of drivers/net/phy/marvell.c,
and a new entry in marvell_drivers. I would copy the 1540.


3) The Marvell PHY driver does recognise it, and makes the temperature
available in /sys/class/hwmon/hwmon*/temp1_input. It always returns
-25000mC. Same problem i have with the 6390. No idea how to fix it yet.

4) The Marvell PHY driver does recognise it, and makes the temperature
available in /sys/class/hwmon/hwmon*/temp1_input. The value is O.K. It
all works :-)

Personally, i'm not betting on 4 :-)


    Andrew

  parent reply	other threads:[~2017-01-20 22:38 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-19 21:49 [PATCH v5 0/2] Add support for the ethernet switch on the ESPRESSObin Gregory CLEMENT
2017-01-19 21:49 ` Gregory CLEMENT
2017-01-19 21:49 ` [PATCH v5 1/2] net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= num_of_ports Gregory CLEMENT
2017-01-19 21:49   ` Gregory CLEMENT
2017-01-19 22:13   ` Vivien Didelot
2017-01-19 22:13     ` Vivien Didelot
2017-01-19 22:13     ` Vivien Didelot
2017-01-20  0:06     ` Andrew Lunn
2017-01-20  0:06       ` Andrew Lunn
2017-01-20  0:06       ` Andrew Lunn
2017-01-20  1:54       ` Vivien Didelot
2017-01-20  1:54         ` Vivien Didelot
2017-01-19 21:49 ` [PATCH v5 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341 Gregory CLEMENT
2017-01-19 21:49   ` Gregory CLEMENT
2017-01-19 22:26   ` Vivien Didelot
2017-01-19 22:26     ` Vivien Didelot
2017-01-19 22:26     ` Vivien Didelot
2017-01-20  0:12     ` Andrew Lunn
2017-01-20  0:12       ` Andrew Lunn
2017-01-20  0:12       ` Andrew Lunn
2017-01-20  1:55       ` Vivien Didelot
2017-01-20  1:55         ` Vivien Didelot
2017-01-20 17:21       ` Gregory CLEMENT
2017-01-20 17:21         ` Gregory CLEMENT
2017-01-20 17:21         ` Gregory CLEMENT
2017-01-20 17:30         ` Vivien Didelot
2017-01-20 17:30           ` Vivien Didelot
2017-01-20 23:15           ` Andrew Lunn
2017-01-20 23:15             ` Andrew Lunn
2017-01-19 22:06 ` [PATCH v5 0/2] Add support for the ethernet switch on the ESPRESSObin Andrew Lunn
2017-01-19 22:06   ` Andrew Lunn
2017-01-19 22:06   ` Andrew Lunn
2017-01-19 23:41   ` [EXT] " Jon Pannell
2017-01-19 23:41     ` Jon Pannell
2017-01-20 17:08   ` Gregory CLEMENT
2017-01-20 17:08     ` Gregory CLEMENT
2017-01-20 17:43     ` Andrew Lunn
2017-01-20 17:43       ` Andrew Lunn
2017-01-20 22:38     ` Andrew Lunn [this message]
2017-01-20 22:38       ` Andrew Lunn
2017-01-19 22:07 ` Vivien Didelot
2017-01-19 22:07   ` Vivien Didelot
2017-01-19 22:33   ` Vivien Didelot
2017-01-19 22:33     ` Vivien Didelot
2017-01-19 22:33     ` Vivien Didelot
2017-01-20 19:17 ` David Miller
2017-01-20 19:17   ` David Miller
2017-01-20 19:17   ` David Miller
2017-01-24 16:47   ` Gregory CLEMENT
2017-01-24 16:47     ` Gregory CLEMENT
2017-01-24 18:08     ` Vivien Didelot
2017-01-24 18:08       ` Vivien Didelot
2017-01-24 19:57     ` Andrew Lunn
2017-01-24 19:57       ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170120223823.GA25240@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.