From: Sean Paul <seanpaul@chromium.org>
To: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Cc: linux-samsung-soc@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/exynos: use atomic helper commit
Date: Mon, 23 Jan 2017 11:20:42 -0500 [thread overview]
Message-ID: <20170123162041.GA22897@trickycodes.roam.corp.google.com> (raw)
In-Reply-To: <588628F4.50808@math.uni-bielefeld.de>
On Mon, Jan 23, 2017 at 05:01:56PM +0100, Tobias Jakobi wrote:
> Sean Paul wrote:
> > <snip>
> >
> >>>>> As of now, I don't see any case. even without Maarten's patch set, it works well - actually, I had a test with atomic test app more than 10 hours..
> >>>> Can you provide this test application? In particular I'm asking this
> >>>> because libdrm currently doesn't provide any tests using the atomic API.
> >>>> So this application might be of interest also for other people.
> >>>
> >>> Below is the app I tested. Know that this application is from chromiumOS tree and I just fixed some parts for internal test.
> >>> https://review.tizen.org/git/?p=atform/upstream/libdrm.git;a=commitdiff;h�3bd95f2c5a9b4b69062a3ff008947054b94f55
> >> Thanks, any chance this is going to be submitted upstream?
> >>
> >
> > Probably not in its current form. I just wrote it to quickly test out
> > some stuff we didn't yet support in CrOS. I don't really think it's fit
> > for inclusion upstream.
> Thanks for the clarification! Just voicing my interest here to have
> something like this upstream. I mean with atomic now being mandatory for
> new DRM kernel drivers and all... :-)
Agreed that tests are important, I'm just hesitant to sling my spaghetti code
around too widely :)
The igt suite should have you covered for basic testing and more. CrOS also has a
bsdrm test suite that may or may not become atomic-aware in the future. Both are
better options that my atomictest, IMO.
Sean
>
> - Tobias
>
>
> >
> > Sean
> >
> > <snip>
> >
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Sean Paul, Software Engineer, Google / Chromium OS
next prev parent reply other threads:[~2017-01-23 16:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170119101840epcas5p36732799cf9d707abdf6a8f07e5169131@epcas5p3.samsung.com>
2017-01-19 10:18 ` [PATCH v2] drm/exynos: use atomic helper commit Inki Dae
2017-01-19 11:53 ` Gustavo Padovan
2017-01-19 23:15 ` Inki Dae
2017-01-19 12:49 ` Tobias Jakobi
2017-01-20 3:43 ` Inki Dae
2017-01-20 13:05 ` Tobias Jakobi
2017-01-23 9:00 ` Inki Dae
2017-01-23 12:44 ` Tobias Jakobi
2017-01-23 14:55 ` Sean Paul
2017-01-23 16:01 ` Tobias Jakobi
2017-01-23 16:20 ` Sean Paul [this message]
2017-01-23 18:03 ` Daniel Vetter
2017-01-23 23:49 ` Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170123162041.GA22897@trickycodes.roam.corp.google.com \
--to=seanpaul@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=tjakobi@math.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.