All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Laura Abbott <labbott@redhat.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] arm64: Use __pa_symbol for empty_zero_page
Date: Tue, 24 Jan 2017 12:37:33 +0000	[thread overview]
Message-ID: <20170124123617.GA7572@leverpostej> (raw)
In-Reply-To: <1485258220-21916-1-git-send-email-geert+renesas@glider.be>

On Tue, Jan 24, 2017 at 12:43:40PM +0100, Geert Uytterhoeven wrote:
> If CONFIG_DEBUG_VIRTUAL=y and CONFIG_ARM64_SW_TTBR0_PAN=y:
> 
>     virt_to_phys used for non-linear address: ffffff8008cc0000 (empty_zero_page+0x0/0x1000)
>     WARNING: CPU: 0 PID: 0 at arch/arm64/mm/physaddr.c:14 __virt_to_phys+0x28/0x60
>     ...
>     [<ffffff800809abb4>] __virt_to_phys+0x28/0x60
>     [<ffffff8008a02600>] setup_arch+0x46c/0x4d4
> 
> Fixes: 2077be6783b5936c ("arm64: Use __pa_symbol for kernel symbols")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

> ---
>  arch/arm64/kernel/setup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> index 669fc9ff728b227f..b5222094ab52db6f 100644
> --- a/arch/arm64/kernel/setup.c
> +++ b/arch/arm64/kernel/setup.c
> @@ -298,7 +298,7 @@ void __init setup_arch(char **cmdline_p)
>  	 * faults in case uaccess_enable() is inadvertently called by the init
>  	 * thread.
>  	 */
> -	init_task.thread_info.ttbr0 = virt_to_phys(empty_zero_page);
> +	init_task.thread_info.ttbr0 = __pa_symbol(empty_zero_page);
>  #endif
>  
>  #ifdef CONFIG_VT
> -- 
> 1.9.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Use __pa_symbol for empty_zero_page
Date: Tue, 24 Jan 2017 12:37:33 +0000	[thread overview]
Message-ID: <20170124123617.GA7572@leverpostej> (raw)
In-Reply-To: <1485258220-21916-1-git-send-email-geert+renesas@glider.be>

On Tue, Jan 24, 2017 at 12:43:40PM +0100, Geert Uytterhoeven wrote:
> If CONFIG_DEBUG_VIRTUAL=y and CONFIG_ARM64_SW_TTBR0_PAN=y:
> 
>     virt_to_phys used for non-linear address: ffffff8008cc0000 (empty_zero_page+0x0/0x1000)
>     WARNING: CPU: 0 PID: 0 at arch/arm64/mm/physaddr.c:14 __virt_to_phys+0x28/0x60
>     ...
>     [<ffffff800809abb4>] __virt_to_phys+0x28/0x60
>     [<ffffff8008a02600>] setup_arch+0x46c/0x4d4
> 
> Fixes: 2077be6783b5936c ("arm64: Use __pa_symbol for kernel symbols")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

> ---
>  arch/arm64/kernel/setup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> index 669fc9ff728b227f..b5222094ab52db6f 100644
> --- a/arch/arm64/kernel/setup.c
> +++ b/arch/arm64/kernel/setup.c
> @@ -298,7 +298,7 @@ void __init setup_arch(char **cmdline_p)
>  	 * faults in case uaccess_enable() is inadvertently called by the init
>  	 * thread.
>  	 */
> -	init_task.thread_info.ttbr0 = virt_to_phys(empty_zero_page);
> +	init_task.thread_info.ttbr0 = __pa_symbol(empty_zero_page);
>  #endif
>  
>  #ifdef CONFIG_VT
> -- 
> 1.9.1
> 

  reply	other threads:[~2017-01-24 12:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-24 11:43 [PATCH] arm64: Use __pa_symbol for empty_zero_page Geert Uytterhoeven
2017-01-24 11:43 ` Geert Uytterhoeven
2017-01-24 12:37 ` Mark Rutland [this message]
2017-01-24 12:37   ` Mark Rutland
2017-01-25  9:30 ` Laura Abbott
2017-01-25  9:30   ` Laura Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170124123617.GA7572@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=geert+renesas@glider.be \
    --cc=labbott@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.