From: "Daniel P. Berrange" <berrange@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] iotests: record separate timings per format, protocol pair
Date: Tue, 24 Jan 2017 12:38:17 +0000 [thread overview]
Message-ID: <20170124123817.GM14563@redhat.com> (raw)
In-Reply-To: <cfa039b5-d1df-079e-5a6e-f92e13870a2d@redhat.com>
On Tue, Jan 03, 2017 at 11:08:39AM -0600, Eric Blake wrote:
> On 01/03/2017 10:05 AM, Daniel P. Berrange wrote:
> > The 'check' program records timings for each test that
> > is run. These timings are only valid, however, for a
> > particular format/protocol combination. So if frequently
> > running 'check' with a variety of different formats or
> > protocols, the times printed can be very misleading.
> >
> > Instead of having a single 'check.time' file, maintain
> > multiple 'check.time-$IMGPROTO-$IMGFMT' files.
> >
> > Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> > ---
> > Changed in v2:
> >
> > - Use a separate file per format/protocol, instead of
> > throwing away data each time format/protocol changes
> > between runs (Eric)
> >
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Ping, any block maintainers want to take this simple patch ?
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
next prev parent reply other threads:[~2017-01-24 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 16:05 [Qemu-devel] [PATCH v2] iotests: record separate timings per format, protocol pair Daniel P. Berrange
2017-01-03 17:08 ` Eric Blake
2017-01-24 12:38 ` Daniel P. Berrange [this message]
2017-01-25 14:59 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124123817.GM14563@redhat.com \
--to=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.