From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Richard Weinberger <richard@nod.at>,
Marek Vasut <marek.vasut@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mtd@lists.infradead.org,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 1/3] mtd: name the mtd device with an optional label property
Date: Tue, 24 Jan 2017 15:27:04 +0100 [thread overview]
Message-ID: <20170124152704.03598ae5@bbrezillon> (raw)
In-Reply-To: <20170124151353.5bbffae0@bbrezillon>
On Tue, 24 Jan 2017 15:13:53 +0100
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> > if (mtd->dev.parent) {
> > if (!mtd->owner && mtd->dev.parent->driver)
> > mtd->owner = mtd->dev.parent->driver->owner;
>
> --->8---
> diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
> index 13f8052b9ff9..a12b68f941e3 100644
> --- a/include/linux/mtd/mtd.h
> +++ b/include/linux/mtd/mtd.h
> @@ -385,6 +385,8 @@ static inline void mtd_set_of_node(struct mtd_info *mtd,
> struct device_node *np)
> {
> mtd->dev.of_node = np;
> +
> + of_property_read_string(np, "label", mtd->name);
> }
>
> static inline struct device_node *mtd_get_of_node(struct mtd_info *mtd)
Sorry, I forgot to compile test this change. Here is a valid version:
--->8---
diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
index 13f8052b9ff9..581057f8d9a5 100644
--- a/include/linux/mtd/mtd.h
+++ b/include/linux/mtd/mtd.h
@@ -24,6 +24,7 @@
#include <linux/uio.h>
#include <linux/notifier.h>
#include <linux/device.h>
+#include <linux/of.h>
#include <mtd/mtd-abi.h>
@@ -385,6 +386,8 @@ static inline void mtd_set_of_node(struct mtd_info *mtd,
struct device_node *np)
{
mtd->dev.of_node = np;
+
+ of_property_read_string(np, "label", &mtd->name);
}
static inline struct device_node *mtd_get_of_node(struct mtd_info *mtd)
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: "Cédric Le Goater" <clg-Bxea+6Xhats@public.gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org>,
Marek Vasut <marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Cyrille Pitchen
<cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
Brian Norris
<computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Subject: Re: [PATCH 1/3] mtd: name the mtd device with an optional label property
Date: Tue, 24 Jan 2017 15:27:04 +0100 [thread overview]
Message-ID: <20170124152704.03598ae5@bbrezillon> (raw)
In-Reply-To: <20170124151353.5bbffae0@bbrezillon>
On Tue, 24 Jan 2017 15:13:53 +0100
Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> > if (mtd->dev.parent) {
> > if (!mtd->owner && mtd->dev.parent->driver)
> > mtd->owner = mtd->dev.parent->driver->owner;
>
> --->8---
> diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
> index 13f8052b9ff9..a12b68f941e3 100644
> --- a/include/linux/mtd/mtd.h
> +++ b/include/linux/mtd/mtd.h
> @@ -385,6 +385,8 @@ static inline void mtd_set_of_node(struct mtd_info *mtd,
> struct device_node *np)
> {
> mtd->dev.of_node = np;
> +
> + of_property_read_string(np, "label", mtd->name);
> }
>
> static inline struct device_node *mtd_get_of_node(struct mtd_info *mtd)
Sorry, I forgot to compile test this change. Here is a valid version:
--->8---
diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
index 13f8052b9ff9..581057f8d9a5 100644
--- a/include/linux/mtd/mtd.h
+++ b/include/linux/mtd/mtd.h
@@ -24,6 +24,7 @@
#include <linux/uio.h>
#include <linux/notifier.h>
#include <linux/device.h>
+#include <linux/of.h>
#include <mtd/mtd-abi.h>
@@ -385,6 +386,8 @@ static inline void mtd_set_of_node(struct mtd_info *mtd,
struct device_node *np)
{
mtd->dev.of_node = np;
+
+ of_property_read_string(np, "label", &mtd->name);
}
static inline struct device_node *mtd_get_of_node(struct mtd_info *mtd)
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-01-24 14:27 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 13:27 [PATCH 0/3] Add a "label" property to the mtd device Cédric Le Goater
2017-01-16 13:27 ` Cédric Le Goater
2017-01-16 13:27 ` [PATCH 1/3] mtd: name the mtd device with an optional label property Cédric Le Goater
2017-01-16 13:27 ` Cédric Le Goater
2017-01-16 13:32 ` Boris Brezillon
2017-01-16 13:32 ` Boris Brezillon
2017-01-24 14:13 ` Boris Brezillon
2017-01-24 14:13 ` Boris Brezillon
2017-01-24 14:27 ` Boris Brezillon [this message]
2017-01-24 14:27 ` Boris Brezillon
2017-01-25 16:47 ` Cédric Le Goater
2017-01-25 16:47 ` Cédric Le Goater
2017-01-25 16:51 ` Boris Brezillon
2017-01-25 16:51 ` Boris Brezillon
2017-01-25 16:53 ` Cédric Le Goater
2017-01-25 16:53 ` Cédric Le Goater
2017-01-16 13:27 ` [PATCH 2/3] dt-bindings: mtd: add a common label property to all mtd devices Cédric Le Goater
2017-01-16 13:27 ` Cédric Le Goater
2017-01-16 13:52 ` Boris Brezillon
2017-01-16 13:52 ` Boris Brezillon
2017-01-16 14:39 ` Cédric Le Goater
2017-01-16 14:39 ` Cédric Le Goater
2017-01-16 14:56 ` [PATCH v2 " Cédric Le Goater
2017-01-16 14:56 ` Cédric Le Goater
2017-01-19 16:42 ` Rob Herring
2017-01-19 16:42 ` Rob Herring
2017-01-16 13:27 ` [PATCH 3/3] mtd: spi-nor: add SPI_NOR_DUAL_READ to mx66l51235l Cédric Le Goater
2017-01-16 13:27 ` Cédric Le Goater
2017-01-16 16:15 ` Marek Vasut
2017-01-16 16:15 ` Marek Vasut
2017-01-16 16:39 ` Cédric Le Goater
2017-01-16 16:39 ` Cédric Le Goater
2017-01-17 18:19 ` Rob Lippert
2017-01-17 18:19 ` Rob Lippert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124152704.03598ae5@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=clg@kaod.org \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.