From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org,
qemu-devel@nongnu.org, christoffer.dall@linaro.org,
Shannon Zhao <zhaoshenglong@huawei.com>
Subject: Re: [Qemu-arm] [PATCH V2] virtio: Fix no interrupt when not creating msi controller
Date: Tue, 24 Jan 2017 17:55:12 +0200 [thread overview]
Message-ID: <20170124175419-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <f5af901b-d355-94e7-fdf1-ad1b88223bd7@redhat.com>
On Tue, Jan 24, 2017 at 04:50:44PM +0100, Paolo Bonzini wrote:
>
>
> On 24/01/2017 16:05, Michael S. Tsirkin wrote:
> >>
> >> So we have four cases:
> >>
> >> - assign with emulated irqfd + ISR
> >> - assign with emulated irqfd
> >> - assign with irqfd
> >> - deassign
> >>
> >> Currently we don't distinguish the first two, so (which I don't like)
> >> Shannon's patch ends up setting ISR twice.
> >
> > I don't see this yet - where is it set twice?
>
> Once in virtio_notify_irqfd, once in virtio_queue_guest_notifier_read.
>
> Unfortunately, for virtio-blk + MSI + KVM + old Windows drivers we need
> the one in virtio_notify_irqfd. For virtio-net + vhost + INTx we need
> the one in virtio_queue_guest_notifier_read.
Well in MSI mode virtio_queue_guest_notifier_read so we only do this
once, right? I need to check INTx mode - does virtio_notify_irqfd
get called then?
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Shannon Zhao <zhaoshenglong@huawei.com>,
qemu-devel@nongnu.org, qemu-arm@nongnu.org,
peter.maydell@linaro.org, christoffer.dall@linaro.org
Subject: Re: [Qemu-devel] [PATCH V2] virtio: Fix no interrupt when not creating msi controller
Date: Tue, 24 Jan 2017 17:55:12 +0200 [thread overview]
Message-ID: <20170124175419-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <f5af901b-d355-94e7-fdf1-ad1b88223bd7@redhat.com>
On Tue, Jan 24, 2017 at 04:50:44PM +0100, Paolo Bonzini wrote:
>
>
> On 24/01/2017 16:05, Michael S. Tsirkin wrote:
> >>
> >> So we have four cases:
> >>
> >> - assign with emulated irqfd + ISR
> >> - assign with emulated irqfd
> >> - assign with irqfd
> >> - deassign
> >>
> >> Currently we don't distinguish the first two, so (which I don't like)
> >> Shannon's patch ends up setting ISR twice.
> >
> > I don't see this yet - where is it set twice?
>
> Once in virtio_notify_irqfd, once in virtio_queue_guest_notifier_read.
>
> Unfortunately, for virtio-blk + MSI + KVM + old Windows drivers we need
> the one in virtio_notify_irqfd. For virtio-net + vhost + INTx we need
> the one in virtio_queue_guest_notifier_read.
Well in MSI mode virtio_queue_guest_notifier_read so we only do this
once, right? I need to check INTx mode - does virtio_notify_irqfd
get called then?
--
MST
next prev parent reply other threads:[~2017-01-24 15:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 0:55 [Qemu-arm] [PATCH V2] virtio: Fix no interrupt when not creating msi controller Shannon Zhao
2017-01-23 0:55 ` [Qemu-devel] " Shannon Zhao
2017-01-23 16:07 ` [Qemu-arm] " Michael S. Tsirkin
2017-01-23 16:07 ` [Qemu-devel] " Michael S. Tsirkin
2017-01-23 16:46 ` [Qemu-arm] " Paolo Bonzini
2017-01-23 16:46 ` [Qemu-devel] " Paolo Bonzini
2017-01-23 17:04 ` [Qemu-arm] " Michael S. Tsirkin
2017-01-23 17:04 ` [Qemu-devel] " Michael S. Tsirkin
2017-01-24 9:25 ` [Qemu-arm] " Paolo Bonzini
2017-01-24 9:25 ` [Qemu-devel] " Paolo Bonzini
2017-01-24 14:44 ` [Qemu-arm] " Michael S. Tsirkin
2017-01-24 14:44 ` [Qemu-devel] " Michael S. Tsirkin
2017-01-24 15:00 ` Paolo Bonzini
2017-01-24 15:00 ` Paolo Bonzini
2017-01-24 15:05 ` [Qemu-arm] " Michael S. Tsirkin
2017-01-24 15:05 ` [Qemu-devel] " Michael S. Tsirkin
2017-01-24 15:50 ` [Qemu-arm] " Paolo Bonzini
2017-01-24 15:50 ` [Qemu-devel] " Paolo Bonzini
2017-01-24 15:55 ` Michael S. Tsirkin [this message]
2017-01-24 15:55 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124175419-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=christoffer.dall@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.