All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>,
	zhouxianrong <zhouxianrong@huawei.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org, sergey.senozhatsky@gmail.com,
	ngupta@vflare.org, Mi.Sophia.Wang@huawei.com,
	zhouxiyu@huawei.com, weidu.du@huawei.com,
	zhangshiming5@huawei.com, won.ho.park@huawei.com
Subject: Re: [PATCH] mm: extend zero pages to same element pages for zram
Date: Wed, 25 Jan 2017 14:44:16 +0900	[thread overview]
Message-ID: <20170125054416.GC18289@bbox> (raw)
In-Reply-To: <20170125053849.GF2234@jagdpanzerIV.localdomain>

On Wed, Jan 25, 2017 at 02:38:49PM +0900, Sergey Senozhatsky wrote:
> On (01/25/17 13:51), Minchan Kim wrote:
> [..]
> > > Minchan, zhouxianrong, I was completely wrong. we can't
> > > do memset(). d'oh, I did not know it truncates 4 bytes to
> > > one byte only (doesn't make too much sense to me).
> > 
> > Now, I read Matthew's comment and understood. Thanks.
> > It means zhouxianrong's patch I sent recently is okay?
> 
> this one looks OK to me
> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1316290.html
> 
> 
> I'd agree with Joonsoo that doing forward prefetching is _probably_ better
> than backwards prefetching. not that it necessarily should confuse the CPU
> (need to google if ARM handles it normally), but still.

Okay, let's settle down.

zhouxianrong, please resend one Sergey pointed out with changing to
forward loop. though, sorry for a lot confusion!

> 
> 	-ss
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>,
	zhouxianrong <zhouxianrong@huawei.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>, <akpm@linux-foundation.org>,
	<sergey.senozhatsky@gmail.com>, <ngupta@vflare.org>,
	<Mi.Sophia.Wang@huawei.com>, <zhouxiyu@huawei.com>,
	<weidu.du@huawei.com>, <zhangshiming5@huawei.com>,
	<won.ho.park@huawei.com>
Subject: Re: [PATCH] mm: extend zero pages to same element pages for zram
Date: Wed, 25 Jan 2017 14:44:16 +0900	[thread overview]
Message-ID: <20170125054416.GC18289@bbox> (raw)
In-Reply-To: <20170125053849.GF2234@jagdpanzerIV.localdomain>

On Wed, Jan 25, 2017 at 02:38:49PM +0900, Sergey Senozhatsky wrote:
> On (01/25/17 13:51), Minchan Kim wrote:
> [..]
> > > Minchan, zhouxianrong, I was completely wrong. we can't
> > > do memset(). d'oh, I did not know it truncates 4 bytes to
> > > one byte only (doesn't make too much sense to me).
> > 
> > Now, I read Matthew's comment and understood. Thanks.
> > It means zhouxianrong's patch I sent recently is okay?
> 
> this one looks OK to me
> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1316290.html
> 
> 
> I'd agree with Joonsoo that doing forward prefetching is _probably_ better
> than backwards prefetching. not that it necessarily should confuse the CPU
> (need to google if ARM handles it normally), but still.

Okay, let's settle down.

zhouxianrong, please resend one Sergey pointed out with changing to
forward loop. though, sorry for a lot confusion!

> 
> 	-ss
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-01-25  5:46 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-06  8:42 [PATCH] mm: extend zero pages to same element pages for zram zhouxianrong
2017-01-06  8:42 ` zhouxianrong
2017-01-09 23:41 ` Minchan Kim
2017-01-09 23:41   ` Minchan Kim
2017-01-13  4:24   ` Sergey Senozhatsky
2017-01-13  4:24     ` Sergey Senozhatsky
2017-01-13  6:23     ` Minchan Kim
2017-01-13  6:23       ` Minchan Kim
2017-01-13  6:36       ` Sergey Senozhatsky
2017-01-13  6:36         ` Sergey Senozhatsky
2017-01-13  6:47         ` Minchan Kim
2017-01-13  6:47           ` Minchan Kim
2017-01-13  7:02           ` Sergey Senozhatsky
2017-01-13  7:02             ` Sergey Senozhatsky
2017-01-13  8:03             ` Minchan Kim
2017-01-13  8:03               ` Minchan Kim
2017-01-13  8:29 ` zhouxianrong
2017-01-13  8:29   ` zhouxianrong
2017-01-21  8:43   ` Sergey Senozhatsky
2017-01-21  8:43     ` Sergey Senozhatsky
2017-01-22  2:58     ` zhouxianrong
2017-01-22  2:58       ` zhouxianrong
2017-01-22  4:45       ` Sergey Senozhatsky
2017-01-22  4:45         ` Sergey Senozhatsky
2017-01-23  2:58       ` Joonsoo Kim
2017-01-23  2:58         ` Joonsoo Kim
2017-01-23  3:32         ` zhouxianrong
2017-01-23  3:32           ` zhouxianrong
2017-01-23  4:03         ` Sergey Senozhatsky
2017-01-23  4:03           ` Sergey Senozhatsky
2017-01-23  6:27           ` Joonsoo Kim
2017-01-23  6:27             ` Joonsoo Kim
2017-01-23  7:13             ` Sergey Senozhatsky
2017-01-23  7:13               ` Sergey Senozhatsky
2017-01-23  7:40               ` Minchan Kim
2017-01-23  7:40                 ` Minchan Kim
2017-01-24  7:58                 ` zhouxianrong
2017-01-24  7:58                   ` zhouxianrong
2017-01-25  1:29                   ` Minchan Kim
2017-01-25  1:29                     ` Minchan Kim
2017-01-25  1:32                     ` Sergey Senozhatsky
2017-01-25  1:32                       ` Sergey Senozhatsky
2017-01-25  2:48                       ` Matthew Wilcox
2017-01-25  2:48                         ` Matthew Wilcox
2017-01-25  4:18                         ` Sergey Senozhatsky
2017-01-25  4:18                           ` Sergey Senozhatsky
2017-01-25  4:51                           ` Minchan Kim
2017-01-25  4:51                             ` Minchan Kim
2017-01-25  5:38                             ` Sergey Senozhatsky
2017-01-25  5:38                               ` Sergey Senozhatsky
2017-01-25  5:44                               ` Minchan Kim [this message]
2017-01-25  5:44                                 ` Minchan Kim
2017-01-23  6:26       ` Matthew Wilcox
2017-01-23  6:26         ` Matthew Wilcox
2017-01-23  6:32         ` 答复: " zhouxianrong
2017-02-03  8:34 ` zhouxianrong
2017-02-03  8:34   ` zhouxianrong
2017-02-03  8:42 ` zhouxianrong
2017-02-03  8:42   ` zhouxianrong
2017-02-03 15:33   ` Matthew Wilcox
2017-02-03 15:33     ` Matthew Wilcox
2017-02-04  3:33     ` zhouxianrong
2017-02-04  3:33       ` zhouxianrong
2017-02-05 14:21   ` Minchan Kim
2017-02-05 14:21     ` Minchan Kim
2017-02-06  1:28     ` zhouxianrong
2017-02-06  1:28       ` zhouxianrong
2017-02-06 14:14       ` Matthew Wilcox
2017-02-06 14:14         ` Matthew Wilcox
2017-02-06 23:48       ` Minchan Kim
2017-02-06 23:48         ` Minchan Kim
2017-02-07  2:20         ` zhouxianrong
2017-02-07  2:20           ` zhouxianrong
2017-02-07  2:54           ` Minchan Kim
2017-02-07  2:54             ` Minchan Kim
2017-02-07  3:24             ` zhouxianrong
2017-02-07  3:24               ` zhouxianrong
2017-02-07  4:57               ` Minchan Kim
2017-02-07  4:57                 ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170125054416.GC18289@bbox \
    --to=minchan@kernel.org \
    --cc=Mi.Sophia.Wang@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ngupta@vflare.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=weidu.du@huawei.com \
    --cc=willy@infradead.org \
    --cc=won.ho.park@huawei.com \
    --cc=zhangshiming5@huawei.com \
    --cc=zhouxianrong@huawei.com \
    --cc=zhouxiyu@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.