All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	Andre Przywara <andre.przywara@arm.com>
Subject: Re: [PATCH v3 7/13] mmc: sunxi: Add more debug messages
Date: Wed, 25 Jan 2017 10:16:51 +0100	[thread overview]
Message-ID: <20170125091651.pss4mokis4ncdkwf@lukather> (raw)
In-Reply-To: <CAPDyKFqE7hMdwweE4zX4TcH5qCThb2_NQh5PNA_4coJQUrCwfg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1992 bytes --]

On Tue, Jan 24, 2017 at 09:22:24AM +0100, Ulf Hansson wrote:
> On 16 January 2017 at 17:56, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > Add a bit more debug messages that can be helpful when debugging the clock
> > setup.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > ---
> >  drivers/mmc/host/sunxi-mmc.c | 10 ++++++++--
> >  1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
> > index f0f6922bca8a..40ed287ceb1c 100644
> > --- a/drivers/mmc/host/sunxi-mmc.c
> > +++ b/drivers/mmc/host/sunxi-mmc.c
> > @@ -661,6 +661,9 @@ static int sunxi_mmc_oclk_onoff(struct sunxi_mmc_host *host, u32 oclk_en)
> >         unsigned long expire = jiffies + msecs_to_jiffies(750);
> >         u32 rval;
> >
> > +       dev_dbg(mmc_dev(host->mmc), "%sabling the clock\n",
> > +               oclk_en ? "en" : "dis");
> > +
> >         rval = mmc_readl(host, REG_CLKCR);
> >         rval &= ~(SDXC_CARD_CLOCK_ON | SDXC_LOW_POWER_ON | SDXC_MASK_DATA0);
> >
> > @@ -737,6 +740,7 @@ static int sunxi_mmc_clk_set_phase(struct sunxi_mmc_host *host,
> >                         index = SDXC_CLK_50M_DDR;
> >                 }
> >         } else {
> > +               dev_dbg(mmc_dev(host->mmc), "Invalid clock... returning\n");
> >                 return -EINVAL;
> >         }
> >
> > @@ -753,6 +757,9 @@ static int sunxi_mmc_clk_set_rate(struct sunxi_mmc_host *host,
> >         u32 rval, clock = ios->clock;
> >         int ret;
> >
> > +       dev_dbg(mmc_dev(host->mmc), "setting clk to %u (requested %u)\n",
> > +               clock, ios->clock);
> > +
> >
> 
> A better option is to update mmc->actual_clock. That value is
> available (and the requested value) though the debugFS nodes.

Ok, I will change that.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 7/13] mmc: sunxi: Add more debug messages
Date: Wed, 25 Jan 2017 10:16:51 +0100	[thread overview]
Message-ID: <20170125091651.pss4mokis4ncdkwf@lukather> (raw)
In-Reply-To: <CAPDyKFqE7hMdwweE4zX4TcH5qCThb2_NQh5PNA_4coJQUrCwfg@mail.gmail.com>

On Tue, Jan 24, 2017 at 09:22:24AM +0100, Ulf Hansson wrote:
> On 16 January 2017 at 17:56, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > Add a bit more debug messages that can be helpful when debugging the clock
> > setup.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > ---
> >  drivers/mmc/host/sunxi-mmc.c | 10 ++++++++--
> >  1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
> > index f0f6922bca8a..40ed287ceb1c 100644
> > --- a/drivers/mmc/host/sunxi-mmc.c
> > +++ b/drivers/mmc/host/sunxi-mmc.c
> > @@ -661,6 +661,9 @@ static int sunxi_mmc_oclk_onoff(struct sunxi_mmc_host *host, u32 oclk_en)
> >         unsigned long expire = jiffies + msecs_to_jiffies(750);
> >         u32 rval;
> >
> > +       dev_dbg(mmc_dev(host->mmc), "%sabling the clock\n",
> > +               oclk_en ? "en" : "dis");
> > +
> >         rval = mmc_readl(host, REG_CLKCR);
> >         rval &= ~(SDXC_CARD_CLOCK_ON | SDXC_LOW_POWER_ON | SDXC_MASK_DATA0);
> >
> > @@ -737,6 +740,7 @@ static int sunxi_mmc_clk_set_phase(struct sunxi_mmc_host *host,
> >                         index = SDXC_CLK_50M_DDR;
> >                 }
> >         } else {
> > +               dev_dbg(mmc_dev(host->mmc), "Invalid clock... returning\n");
> >                 return -EINVAL;
> >         }
> >
> > @@ -753,6 +757,9 @@ static int sunxi_mmc_clk_set_rate(struct sunxi_mmc_host *host,
> >         u32 rval, clock = ios->clock;
> >         int ret;
> >
> > +       dev_dbg(mmc_dev(host->mmc), "setting clk to %u (requested %u)\n",
> > +               clock, ios->clock);
> > +
> >
> 
> A better option is to update mmc->actual_clock. That value is
> available (and the requested value) though the debugFS nodes.

Ok, I will change that.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170125/48834203/attachment.sig>

  reply	other threads:[~2017-01-25  9:16 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-16 16:56 [PATCH v3 0/13] arm64: allwinner: a64: Enable MMC support Maxime Ripard
2017-01-16 16:56 ` Maxime Ripard
2017-01-16 16:56 ` Maxime Ripard
2017-01-16 16:56 ` [PATCH v3 1/13] mmc: sunxi: Fix clock frequency change sequence Maxime Ripard
2017-01-16 16:56   ` Maxime Ripard
2017-01-16 16:56   ` Maxime Ripard
2017-01-24  8:12   ` Ulf Hansson
2017-01-24  8:12     ` Ulf Hansson
2017-01-25  8:26     ` Maxime Ripard
2017-01-25  8:26       ` Maxime Ripard
2017-01-16 16:56 ` [PATCH v3 2/13] mmc: sunxi: Gate the clock when rate is 0 Maxime Ripard
2017-01-16 16:56   ` Maxime Ripard
     [not found]   ` <1f006fd86d1d9ad5eab0c0c9e435003055466a54.1484585798.git-series.maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2017-01-24  8:14     ` Ulf Hansson
2017-01-24  8:14       ` Ulf Hansson
2017-01-24  8:14       ` Ulf Hansson
2017-01-16 16:56 ` [PATCH v3 3/13] mmc: sunxi: Always set signal delay to 0 for A64 Maxime Ripard
2017-01-16 16:56   ` Maxime Ripard
2017-01-16 16:56   ` Maxime Ripard
2017-01-24  8:16   ` Ulf Hansson
2017-01-24  8:16     ` Ulf Hansson
2017-01-24  9:15     ` Andre Przywara
2017-01-24  9:15       ` Andre Przywara
     [not found]     ` <CAPDyKFoatUWz0AwY6e73OCguDx70B1B5OAoPUYX-JDPsru+aZw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-25  9:10       ` Maxime Ripard
2017-01-25  9:10         ` Maxime Ripard
2017-01-25  9:10         ` Maxime Ripard
2017-01-16 16:56 ` [PATCH v3 4/13] mmc: sunxi: Enable the new timings for the A64 MMC controllers Maxime Ripard
2017-01-16 16:56   ` Maxime Ripard
2017-01-16 16:56   ` Maxime Ripard
2017-01-16 16:56 ` [PATCH v3 5/13] mmc: sunxi: Mask DATA0 when updating the clock Maxime Ripard
2017-01-16 16:56   ` Maxime Ripard
2017-01-24  8:18   ` Ulf Hansson
2017-01-24  8:18     ` Ulf Hansson
2017-01-25  9:16     ` Maxime Ripard
2017-01-25  9:16       ` Maxime Ripard
2017-01-16 16:56 ` [PATCH v3 6/13] mmc: sunxi: Add EMMC (MMC2) controller compatible Maxime Ripard
2017-01-16 16:56   ` Maxime Ripard
2017-01-16 16:56 ` [PATCH v3 7/13] mmc: sunxi: Add more debug messages Maxime Ripard
2017-01-16 16:56   ` Maxime Ripard
2017-01-24  8:22   ` Ulf Hansson
2017-01-24  8:22     ` Ulf Hansson
2017-01-25  9:16     ` Maxime Ripard [this message]
2017-01-25  9:16       ` Maxime Ripard
2017-01-16 16:56 ` [PATCH v3 8/13] arm64: allwinner: a64: Add MMC nodes Maxime Ripard
2017-01-16 16:56   ` Maxime Ripard
2017-01-16 16:56   ` Maxime Ripard
2017-01-16 19:16   ` Corentin Labbe
2017-01-16 19:16     ` Corentin Labbe
2017-01-16 19:16     ` Corentin Labbe
2017-01-25  9:17     ` Maxime Ripard
2017-01-25  9:17       ` Maxime Ripard
2017-01-16 16:56 ` [PATCH v3 9/13] arm64: allwinner: a64: Add MMC pinctrl nodes Maxime Ripard
2017-01-16 16:56   ` Maxime Ripard
2017-01-16 16:56   ` Maxime Ripard
2017-01-16 16:57 ` [PATCH v3 10/13] arm64: allwinner: a64: Increase the MMC max frequency Maxime Ripard
2017-01-16 16:57   ` Maxime Ripard
2017-01-16 16:57   ` Maxime Ripard
2017-01-16 16:57 ` [PATCH v3 11/13] arm64: allwinner: pine64: add MMC support Maxime Ripard
2017-01-16 16:57   ` Maxime Ripard
     [not found] ` <cover.a06ce1672d7a72ee7f9bbca46fdd223edd6b2313.1484585798.git-series.maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2017-01-16 16:57   ` [PATCH v3 12/13] arm64: allwinner: a64: add UART1 pin nodes Maxime Ripard
2017-01-16 16:57     ` Maxime Ripard
2017-01-16 16:57     ` Maxime Ripard
2017-01-16 16:57 ` [PATCH v3 13/13] arm64: allwinner: add BananaPi-M64 support Maxime Ripard
2017-01-16 16:57   ` Maxime Ripard
2017-01-23 10:58 ` [PATCH v3 0/13] arm64: allwinner: a64: Enable MMC support Maxime Ripard
2017-01-23 10:58   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170125091651.pss4mokis4ncdkwf@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=andre.przywara@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.