From: Pavel Machek <pavel@ucw.cz>
To: Laura Abbott <labbott@redhat.com>
Cc: Kees Cook <keescook@chromium.org>,
Jason Wessel <jason.wessel@windriver.com>,
Jonathan Corbet <corbet@lwn.net>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
Helge Deller <deller@gmx.de>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Rob Herring <robh@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>,
Mark Rutland <mark.rutland@arm.com>, Jessica Yu <jeyu@redhat.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org,
linux-pm@vger.kernel.org, kernel-hardening@lists.openwall.com
Subject: [kernel-hardening] Re: [PATCH 1/2] security: Change name of CONFIG_DEBUG_RODATA
Date: Wed, 25 Jan 2017 14:51:24 +0100 [thread overview]
Message-ID: <20170125135124.GA20896@amd> (raw)
In-Reply-To: <fca01775-9640-8783-a657-a9e6cf0c3e0a@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1595 bytes --]
On Wed 2017-01-25 12:21:05, Laura Abbott wrote:
> On 01/19/2017 08:53 AM, Pavel Machek wrote:
> >On Wed 2017-01-18 17:29:05, Laura Abbott wrote:
> >>
> >>Despite the word 'debug' in CONFIG_DEBUG_RODATA, this kernel option
> >>provides key security features that are to be expected on a modern
> >>system. Change the name to CONFIG_HARDENED_PAGE_MAPPINGS which more
> >>accurately describes what this option is intended to do.
> >
> >I think this is bad change. CONFIG_DEBUG_RODATA is describing what it
> >does, CONFIG_HARDENED_PAGE_MAPPINGS is advertising.
> >
> >We don't do advertising, and we don't force people to re-answer the
> >config questions without good reason.
> >
> >CONFIG_HARDENED_RODATA might fix the first problem, but not the second
> >one.
> >
> > Pavel
> >
>
> (Apologies, my SMTP was set up incorrectly so my response didn't
> actually get sent out)
>
> CONFIG_DEBUG_RODATA isn't describing what it does though. It misses
> that this config may handle much more than just rodata. I think
> Mark Rutland's suggestion of STRICT_KERNEL_RWX might be more
> descriptive.
CONFIG_BUG=y
CONFIG_LBDAF=y
CONFIG_PM_OPP=y
..it is config option. It is not description of the feature. People
are living with that config option for a while. I'd keep it.
Maybe you can go from CONFIG_DEBUG_RODATA to CONFIG_RODATA... (but
you'll still have people re-answer config option.)
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Laura Abbott <labbott@redhat.com>
Cc: Kees Cook <keescook@chromium.org>,
Jason Wessel <jason.wessel@windriver.com>,
Jonathan Corbet <corbet@lwn.net>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
Helge Deller <deller@gmx.de>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Rob Herring <robh@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>,
Mark Rutland <mark.rutland@arm.com>, Jessica Yu <jeyu@redhat.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org,
linux-pm@vger.kernel.org, kernel-hard
Subject: Re: [PATCH 1/2] security: Change name of CONFIG_DEBUG_RODATA
Date: Wed, 25 Jan 2017 14:51:24 +0100 [thread overview]
Message-ID: <20170125135124.GA20896@amd> (raw)
In-Reply-To: <fca01775-9640-8783-a657-a9e6cf0c3e0a@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1595 bytes --]
On Wed 2017-01-25 12:21:05, Laura Abbott wrote:
> On 01/19/2017 08:53 AM, Pavel Machek wrote:
> >On Wed 2017-01-18 17:29:05, Laura Abbott wrote:
> >>
> >>Despite the word 'debug' in CONFIG_DEBUG_RODATA, this kernel option
> >>provides key security features that are to be expected on a modern
> >>system. Change the name to CONFIG_HARDENED_PAGE_MAPPINGS which more
> >>accurately describes what this option is intended to do.
> >
> >I think this is bad change. CONFIG_DEBUG_RODATA is describing what it
> >does, CONFIG_HARDENED_PAGE_MAPPINGS is advertising.
> >
> >We don't do advertising, and we don't force people to re-answer the
> >config questions without good reason.
> >
> >CONFIG_HARDENED_RODATA might fix the first problem, but not the second
> >one.
> >
> > Pavel
> >
>
> (Apologies, my SMTP was set up incorrectly so my response didn't
> actually get sent out)
>
> CONFIG_DEBUG_RODATA isn't describing what it does though. It misses
> that this config may handle much more than just rodata. I think
> Mark Rutland's suggestion of STRICT_KERNEL_RWX might be more
> descriptive.
CONFIG_BUG=y
CONFIG_LBDAF=y
CONFIG_PM_OPP=y
..it is config option. It is not description of the feature. People
are living with that config option for a while. I'd keep it.
Maybe you can go from CONFIG_DEBUG_RODATA to CONFIG_RODATA... (but
you'll still have people re-answer config option.)
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] security: Change name of CONFIG_DEBUG_RODATA
Date: Wed, 25 Jan 2017 14:51:24 +0100 [thread overview]
Message-ID: <20170125135124.GA20896@amd> (raw)
In-Reply-To: <fca01775-9640-8783-a657-a9e6cf0c3e0a@redhat.com>
On Wed 2017-01-25 12:21:05, Laura Abbott wrote:
> On 01/19/2017 08:53 AM, Pavel Machek wrote:
> >On Wed 2017-01-18 17:29:05, Laura Abbott wrote:
> >>
> >>Despite the word 'debug' in CONFIG_DEBUG_RODATA, this kernel option
> >>provides key security features that are to be expected on a modern
> >>system. Change the name to CONFIG_HARDENED_PAGE_MAPPINGS which more
> >>accurately describes what this option is intended to do.
> >
> >I think this is bad change. CONFIG_DEBUG_RODATA is describing what it
> >does, CONFIG_HARDENED_PAGE_MAPPINGS is advertising.
> >
> >We don't do advertising, and we don't force people to re-answer the
> >config questions without good reason.
> >
> >CONFIG_HARDENED_RODATA might fix the first problem, but not the second
> >one.
> >
> > Pavel
> >
>
> (Apologies, my SMTP was set up incorrectly so my response didn't
> actually get sent out)
>
> CONFIG_DEBUG_RODATA isn't describing what it does though. It misses
> that this config may handle much more than just rodata. I think
> Mark Rutland's suggestion of STRICT_KERNEL_RWX might be more
> descriptive.
CONFIG_BUG=y
CONFIG_LBDAF=y
CONFIG_PM_OPP=y
..it is config option. It is not description of the feature. People
are living with that config option for a while. I'd keep it.
Maybe you can go from CONFIG_DEBUG_RODATA to CONFIG_RODATA... (but
you'll still have people re-answer config option.)
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170125/14a3cd4f/attachment-0001.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Laura Abbott <labbott@redhat.com>
Cc: Kees Cook <keescook@chromium.org>,
Jason Wessel <jason.wessel@windriver.com>,
Jonathan Corbet <corbet@lwn.net>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
Helge Deller <deller@gmx.de>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Rob Herring <robh@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>,
Mark Rutland <mark.rutland@arm.com>, Jessica Yu <jeyu@redhat.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org,
linux-pm@vger.kernel.org, kernel-hardening@lists.openwall.com
Subject: Re: [PATCH 1/2] security: Change name of CONFIG_DEBUG_RODATA
Date: Wed, 25 Jan 2017 14:51:24 +0100 [thread overview]
Message-ID: <20170125135124.GA20896@amd> (raw)
In-Reply-To: <fca01775-9640-8783-a657-a9e6cf0c3e0a@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1595 bytes --]
On Wed 2017-01-25 12:21:05, Laura Abbott wrote:
> On 01/19/2017 08:53 AM, Pavel Machek wrote:
> >On Wed 2017-01-18 17:29:05, Laura Abbott wrote:
> >>
> >>Despite the word 'debug' in CONFIG_DEBUG_RODATA, this kernel option
> >>provides key security features that are to be expected on a modern
> >>system. Change the name to CONFIG_HARDENED_PAGE_MAPPINGS which more
> >>accurately describes what this option is intended to do.
> >
> >I think this is bad change. CONFIG_DEBUG_RODATA is describing what it
> >does, CONFIG_HARDENED_PAGE_MAPPINGS is advertising.
> >
> >We don't do advertising, and we don't force people to re-answer the
> >config questions without good reason.
> >
> >CONFIG_HARDENED_RODATA might fix the first problem, but not the second
> >one.
> >
> > Pavel
> >
>
> (Apologies, my SMTP was set up incorrectly so my response didn't
> actually get sent out)
>
> CONFIG_DEBUG_RODATA isn't describing what it does though. It misses
> that this config may handle much more than just rodata. I think
> Mark Rutland's suggestion of STRICT_KERNEL_RWX might be more
> descriptive.
CONFIG_BUG=y
CONFIG_LBDAF=y
CONFIG_PM_OPP=y
..it is config option. It is not description of the feature. People
are living with that config option for a while. I'd keep it.
Maybe you can go from CONFIG_DEBUG_RODATA to CONFIG_RODATA... (but
you'll still have people re-answer config option.)
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-01-25 13:51 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 1:29 [kernel-hardening] [RFC][PATCH 0/2] Better hardening names Laura Abbott
2017-01-19 1:29 ` Laura Abbott
2017-01-19 1:29 ` Laura Abbott
2017-01-19 1:29 ` Laura Abbott
2017-01-19 1:29 ` Laura Abbott
2017-01-19 1:29 ` [kernel-hardening] [PATCH 1/2] security: Change name of CONFIG_DEBUG_RODATA Laura Abbott
2017-01-19 1:29 ` Laura Abbott
2017-01-19 1:29 ` Laura Abbott
2017-01-19 1:29 ` Laura Abbott
2017-01-19 1:29 ` Laura Abbott
2017-01-19 7:53 ` [kernel-hardening] " Pavel Machek
2017-01-19 7:53 ` Pavel Machek
2017-01-19 7:53 ` Pavel Machek
2017-01-19 7:53 ` Pavel Machek
2017-01-25 11:21 ` [kernel-hardening] " Laura Abbott
2017-01-25 11:21 ` Laura Abbott
2017-01-25 11:21 ` Laura Abbott
2017-01-25 11:21 ` Laura Abbott
2017-01-25 13:51 ` Pavel Machek [this message]
2017-01-25 13:51 ` Pavel Machek
2017-01-25 13:51 ` Pavel Machek
2017-01-25 13:51 ` Pavel Machek
2017-01-19 10:56 ` [kernel-hardening] " Mark Rutland
2017-01-19 10:56 ` Mark Rutland
2017-01-19 10:56 ` Mark Rutland
2017-01-19 10:56 ` Mark Rutland
2017-01-19 11:33 ` [kernel-hardening] " Heiko Carstens
2017-01-19 11:33 ` Heiko Carstens
2017-01-19 11:33 ` Heiko Carstens
2017-01-19 11:33 ` Heiko Carstens
2017-01-19 21:17 ` [kernel-hardening] " Helge Deller
2017-01-19 21:17 ` Helge Deller
2017-01-19 21:17 ` Helge Deller
2017-01-19 21:17 ` Helge Deller
2017-01-25 11:37 ` [kernel-hardening] " Laura Abbott
2017-01-25 11:37 ` Laura Abbott
2017-01-25 11:37 ` Laura Abbott
2017-01-25 11:37 ` Laura Abbott
2017-01-25 11:37 ` Laura Abbott
2017-01-19 22:00 ` [kernel-hardening] " Kees Cook
2017-01-19 22:00 ` Kees Cook
2017-01-19 22:00 ` Kees Cook
2017-01-19 22:00 ` Kees Cook
2017-01-19 22:00 ` Kees Cook
2017-01-25 11:25 ` [kernel-hardening] " Laura Abbott
2017-01-25 11:25 ` Laura Abbott
2017-01-25 11:25 ` Laura Abbott
2017-01-25 11:25 ` Laura Abbott
2017-01-19 21:57 ` [kernel-hardening] " Kees Cook
2017-01-19 21:57 ` Kees Cook
2017-01-19 21:57 ` Kees Cook
2017-01-19 21:57 ` Kees Cook
2017-01-19 21:57 ` Kees Cook
2017-01-19 1:29 ` [kernel-hardening] [PATCH 2/2] security: Change name of CONFIG_DEBUG_SET_MODULE_RONX Laura Abbott
2017-01-19 1:29 ` Laura Abbott
2017-01-19 1:29 ` Laura Abbott
2017-01-19 1:29 ` Laura Abbott
2017-01-19 1:29 ` Laura Abbott
2017-01-19 11:11 ` [kernel-hardening] " Mark Rutland
2017-01-19 11:11 ` Mark Rutland
2017-01-19 11:11 ` Mark Rutland
2017-01-19 11:11 ` Mark Rutland
2017-01-19 11:34 ` [kernel-hardening] " Heiko Carstens
2017-01-19 11:34 ` Heiko Carstens
2017-01-19 11:34 ` Heiko Carstens
2017-01-19 11:34 ` Heiko Carstens
2017-01-19 11:34 ` Heiko Carstens
2017-01-19 11:43 ` [kernel-hardening] " Robin Murphy
2017-01-19 11:43 ` Robin Murphy
2017-01-19 11:43 ` Robin Murphy
2017-01-19 11:43 ` Robin Murphy
2017-01-25 11:44 ` [kernel-hardening] " Laura Abbott
2017-01-25 11:44 ` Laura Abbott
2017-01-25 11:44 ` Laura Abbott
2017-01-25 11:44 ` Laura Abbott
2017-01-20 5:46 ` [kernel-hardening] " kbuild test robot
2017-01-20 5:46 ` kbuild test robot
2017-01-20 5:46 ` kbuild test robot
2017-01-20 5:46 ` kbuild test robot
2017-01-20 5:46 ` kbuild test robot
2017-01-19 22:08 ` [kernel-hardening] Re: [RFC][PATCH 0/2] Better hardening names Kees Cook
2017-01-19 22:08 ` Kees Cook
2017-01-19 22:08 ` Kees Cook
2017-01-19 22:08 ` Kees Cook
2017-01-19 22:08 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170125135124.GA20896@amd \
--to=pavel@ucw.cz \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=deller@gmx.de \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=jason.wessel@windriver.com \
--cc=jejb@parisc-linux.org \
--cc=jeyu@redhat.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=labbott@redhat.com \
--cc=len.brown@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.