All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Marcel Partap <mpartap-hi6Y0CQ0nG0@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Michael Scott
	<michael.scott-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCHv4] mfd: cpcap: Add minimal support
Date: Wed, 25 Jan 2017 14:41:16 -0800	[thread overview]
Message-ID: <20170125224114.GK7403@atomide.com> (raw)
In-Reply-To: <20170124093534.GU16020@dell>

* Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> [170124 01:32]:
> On Thu, 05 Jan 2017, Tony Lindgren wrote:
> > +
> > +	bit = irq % cpcap->regmap_conf->val_bits;
> > +	mask = (1 << bit);
> 
> Nit: BIT()
...
> > + * Copyright (C) 2016 Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
> 
> Nit: 2017
...
> > +/*
> > + * Helpers for child devices to check the revision and vendor.
> > + *
> > + * REVISIT: No documentation for the bits below, please update
> > + * to use proper names for defines when available.
> > + */
> 
> Yes, please do that.
> 
> But you can do all of the above with subsequent patches.

OK I'll send you a BIT() follow-up patch.

> Applied, thanks.

Thanks, not seeing it in next or mfd git tree yet though, forgot
to push out?

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	devicetree@vger.kernel.org, Marcel Partap <mpartap@gmx.net>,
	Mark Rutland <mark.rutland@arm.com>,
	Michael Scott <michael.scott@linaro.org>
Subject: Re: [PATCHv4] mfd: cpcap: Add minimal support
Date: Wed, 25 Jan 2017 14:41:16 -0800	[thread overview]
Message-ID: <20170125224114.GK7403@atomide.com> (raw)
In-Reply-To: <20170124093534.GU16020@dell>

* Lee Jones <lee.jones@linaro.org> [170124 01:32]:
> On Thu, 05 Jan 2017, Tony Lindgren wrote:
> > +
> > +	bit = irq % cpcap->regmap_conf->val_bits;
> > +	mask = (1 << bit);
> 
> Nit: BIT()
...
> > + * Copyright (C) 2016 Tony Lindgren <tony@atomide.com>
> 
> Nit: 2017
...
> > +/*
> > + * Helpers for child devices to check the revision and vendor.
> > + *
> > + * REVISIT: No documentation for the bits below, please update
> > + * to use proper names for defines when available.
> > + */
> 
> Yes, please do that.
> 
> But you can do all of the above with subsequent patches.

OK I'll send you a BIT() follow-up patch.

> Applied, thanks.

Thanks, not seeing it in next or mfd git tree yet though, forgot
to push out?

Regards,

Tony

  reply	other threads:[~2017-01-25 22:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-06  0:44 [PATCHv4] mfd: cpcap: Add minimal support Tony Lindgren
2017-01-06  0:44 ` Tony Lindgren
     [not found] ` <20170106004439.12249-1-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-01-23 16:30   ` Tony Lindgren
2017-01-23 16:30     ` Tony Lindgren
2017-01-24  9:35   ` Lee Jones
2017-01-24  9:35     ` Lee Jones
2017-01-25 22:41     ` Tony Lindgren [this message]
2017-01-25 22:41       ` Tony Lindgren
2017-01-26 11:56       ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170125224114.GK7403@atomide.com \
    --to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=michael.scott-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=mpartap-hi6Y0CQ0nG0@public.gmane.org \
    --cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.