From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
wvoigt@us.ibm.com, nfont@linux.vnet.ibm.com,
jallen@linux.vnet.ibm.com
Subject: Re: [PATCH net 1/5] ibmvnic: harden interrupt handler
Date: Thu, 26 Jan 2017 10:28:02 -0800 [thread overview]
Message-ID: <20170126102802.4f920418@xeon-e3> (raw)
In-Reply-To: <1485378143-5084-1-git-send-email-tlfalcon@linux.vnet.ibm.com>
On Wed, 25 Jan 2017 15:02:19 -0600
Thomas Falcon <tlfalcon@linux.vnet.ibm.com> wrote:
> static irqreturn_t ibmvnic_interrupt(int irq, void *instance)
> {
> struct ibmvnic_adapter *adapter = instance;
> + unsigned long flags;
> +
> + spin_lock_irqsave(&adapter->crq.lock, flags);
> + vio_disable_interrupts(adapter->vdev);
> + tasklet_schedule(&adapter->tasklet);
> + spin_unlock_irqrestore(&adapter->crq.lock, flags);
> + return IRQ_HANDLED;
> +}
> +
Why not use NAPI? rather than a tasklet
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Cc: netdev@vger.kernel.org, wvoigt@us.ibm.com,
jallen@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org,
nfont@linux.vnet.ibm.com
Subject: Re: [PATCH net 1/5] ibmvnic: harden interrupt handler
Date: Thu, 26 Jan 2017 10:28:02 -0800 [thread overview]
Message-ID: <20170126102802.4f920418@xeon-e3> (raw)
In-Reply-To: <1485378143-5084-1-git-send-email-tlfalcon@linux.vnet.ibm.com>
On Wed, 25 Jan 2017 15:02:19 -0600
Thomas Falcon <tlfalcon@linux.vnet.ibm.com> wrote:
> static irqreturn_t ibmvnic_interrupt(int irq, void *instance)
> {
> struct ibmvnic_adapter *adapter = instance;
> + unsigned long flags;
> +
> + spin_lock_irqsave(&adapter->crq.lock, flags);
> + vio_disable_interrupts(adapter->vdev);
> + tasklet_schedule(&adapter->tasklet);
> + spin_unlock_irqrestore(&adapter->crq.lock, flags);
> + return IRQ_HANDLED;
> +}
> +
Why not use NAPI? rather than a tasklet
next prev parent reply other threads:[~2017-01-26 18:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 21:02 [PATCH net 1/5] ibmvnic: harden interrupt handler Thomas Falcon
2017-01-25 21:02 ` [PATCH net 2/5] ibmvnic: Fix MTU settings Thomas Falcon
2017-01-26 4:05 ` David Miller
2017-01-26 16:44 ` Thomas Falcon
2017-01-26 17:56 ` David Miller
2017-01-25 21:02 ` [PATCH net 3/5] ibmvnic: Fix endian error when requesting device capabilites Thomas Falcon
2017-01-25 21:02 ` [PATCH net 4/5] ibmvnic: Fix endian errors in error reporting output Thomas Falcon
2017-01-25 21:02 ` [PATCH net 5/5] ibmvnic: init completion struct before requesting long term mapped buffers Thomas Falcon
2017-01-26 4:04 ` [PATCH net 1/5] ibmvnic: harden interrupt handler David Miller
2017-01-26 16:44 ` Thomas Falcon
2017-01-26 17:56 ` David Miller
2017-01-26 18:57 ` Thomas Falcon
2017-01-26 18:57 ` Thomas Falcon
2017-01-26 18:28 ` Stephen Hemminger [this message]
2017-01-26 18:28 ` Stephen Hemminger
2017-01-26 19:05 ` Thomas Falcon
2017-01-26 19:05 ` Thomas Falcon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126102802.4f920418@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=jallen@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=nfont@linux.vnet.ibm.com \
--cc=tlfalcon@linux.vnet.ibm.com \
--cc=wvoigt@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.