All of lore.kernel.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] perf: xgene: Include module.h
Date: Thu, 26 Jan 2017 12:21:31 +0000	[thread overview]
Message-ID: <20170126122131.GF14167@arm.com> (raw)
In-Reply-To: <CACgAJHweQP7FTMHWJbW7YzfBKqbUAg+0v=aaTUK9qLs+EfyTqQ@mail.gmail.com>

On Wed, Jan 25, 2017 at 07:29:30PM -0800, Tai Tri Nguyen wrote:
> On Wed, Jan 25, 2017 at 3:46 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > I ran into a build error when I disabled CONFIG_ACPI and tried to
> > compile this driver:
> >
> > drivers/perf/xgene_pmu.c:1242:1: warning: data definition has no type or storage class
> >  MODULE_DEVICE_TABLE(of, xgene_pmu_of_match);
> >  ^
> > drivers/perf/xgene_pmu.c:1242:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
> >
> > Include module.h for the MODULE_DEVICE_TABLE macro that's
> > implicitly included through ACPI.
> >
> > Cc: Tai Nguyen <ttnguyen@apm.com>
> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> > ---
> >  drivers/perf/xgene_pmu.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c
> > index a8ac4bcef2c0..fb3281962a6d 100644
> > --- a/drivers/perf/xgene_pmu.c
> > +++ b/drivers/perf/xgene_pmu.c
> > @@ -20,6 +20,7 @@
> >   */
> >
> >  #include <linux/acpi.h>
> > +#include <linux/module.h>
> 
> Please fix alphabetic order of the include file.
> 
> Tested-by: Tai Nguyen <ttnguyen@apm.com>

I've picked this up with the includes put in the correct order.

Thanks,

Will

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Tai Tri Nguyen <ttnguyen@apm.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
	Mark Rutland <mark.rutland@arm.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] perf: xgene: Include module.h
Date: Thu, 26 Jan 2017 12:21:31 +0000	[thread overview]
Message-ID: <20170126122131.GF14167@arm.com> (raw)
In-Reply-To: <CACgAJHweQP7FTMHWJbW7YzfBKqbUAg+0v=aaTUK9qLs+EfyTqQ@mail.gmail.com>

On Wed, Jan 25, 2017 at 07:29:30PM -0800, Tai Tri Nguyen wrote:
> On Wed, Jan 25, 2017 at 3:46 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > I ran into a build error when I disabled CONFIG_ACPI and tried to
> > compile this driver:
> >
> > drivers/perf/xgene_pmu.c:1242:1: warning: data definition has no type or storage class
> >  MODULE_DEVICE_TABLE(of, xgene_pmu_of_match);
> >  ^
> > drivers/perf/xgene_pmu.c:1242:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
> >
> > Include module.h for the MODULE_DEVICE_TABLE macro that's
> > implicitly included through ACPI.
> >
> > Cc: Tai Nguyen <ttnguyen@apm.com>
> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> > ---
> >  drivers/perf/xgene_pmu.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c
> > index a8ac4bcef2c0..fb3281962a6d 100644
> > --- a/drivers/perf/xgene_pmu.c
> > +++ b/drivers/perf/xgene_pmu.c
> > @@ -20,6 +20,7 @@
> >   */
> >
> >  #include <linux/acpi.h>
> > +#include <linux/module.h>
> 
> Please fix alphabetic order of the include file.
> 
> Tested-by: Tai Nguyen <ttnguyen@apm.com>

I've picked this up with the includes put in the correct order.

Thanks,

Will

  reply	other threads:[~2017-01-26 12:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-25 23:46 [PATCH] perf: xgene: Include module.h Stephen Boyd
2017-01-25 23:46 ` Stephen Boyd
2017-01-26  2:13 ` Tai Tri Nguyen
2017-01-26  2:13   ` Tai Tri Nguyen
2017-01-26  2:16   ` Tai Tri Nguyen
2017-01-26  2:16     ` Tai Tri Nguyen
2017-01-26  3:29 ` Tai Tri Nguyen
2017-01-26  3:29   ` Tai Tri Nguyen
2017-01-26 12:21   ` Will Deacon [this message]
2017-01-26 12:21     ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170126122131.GF14167@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.