Re: [PATCH V2 05/24] aacraid: Retrieve and update the device types

[Johannes Thumshirn <jthumshirn@suse.de>]

On Thu, Jan 26, 2017 at 09:00:42PM +0000, Raghava Aditya Renukunta wrote:
> 
> 
> > -----Original Message-----
> > From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi-
> > owner@vger.kernel.org] On Behalf Of Raghava Aditya Renukunta
> > Sent: Thursday, January 26, 2017 10:44 AM
> > To: Johannes Thumshirn <jthumshirn@suse.de>
> > Cc: jejb@linux.vnet.ibm.com; martin.petersen@oracle.com; linux-
> > scsi@vger.kernel.org; Dave Carroll <david.carroll@microsemi.com>; Gana
> > Sridaran <gana.sridaran@microsemi.com>; Scott Benesh
> > <scott.benesh@microsemi.com>
> > Subject: RE: [PATCH V2 05/24] aacraid: Retrieve and update the device types
> > 
> > EXTERNAL EMAIL
> > 
> > 
> > > -----Original Message-----
> > > From: Johannes Thumshirn [mailto:jthumshirn@suse.de]
> > > Sent: Thursday, January 26, 2017 1:00 AM
> > > To: Raghava Aditya Renukunta
> > > <RaghavaAditya.Renukunta@microsemi.com>
> > > Cc: jejb@linux.vnet.ibm.com; martin.petersen@oracle.com; linux-
> > > scsi@vger.kernel.org; Dave Carroll <david.carroll@microsemi.com>; Gana
> > > Sridaran <gana.sridaran@microsemi.com>; Scott Benesh
> > > <scott.benesh@microsemi.com>
> > > Subject: Re: [PATCH V2 05/24] aacraid: Retrieve and update the device
> > types
> > >
> > > EXTERNAL EMAIL
> > >
> > >
> > > On Wed, Jan 25, 2017 at 10:00:52AM -0800, Raghava Aditya Renukunta
> > wrote:
> > > > This patch adds support to retrieve the type of each adapter connected
> > > > device. Applicable to HBA1000 and SmartIOC2000 products
> > > >
> > > > Signed-off-by: Raghava Aditya Renukunta
> > > <RaghavaAditya.Renukunta@microsemi.com>
> > > > Signed-off-by: Dave Carroll <David.Carroll@microsemi.com>
> > > >
> > > > ---
> > >
> > > [...]
> > >
> > > >  /*
> > > >   *   Adapter Information Block
> > > >   *
> > > > @@ -1056,7 +1091,28 @@ struct aac_supplement_adapter_info
> > > >       /* StructExpansion == 1 */
> > > >       __le32  FeatureBits3;
> > > >       __le32  SupportedPerformanceModes;
> > > > -     __le32  ReservedForFutureGrowth[80];
> > > > +     u8      HostBusType;            /* uses HOST_BUS_TYPE_xxx defines */
> > > > +     u8      HostBusWidth;           /* actual width in bits or links */
> > > > +     u16     HostBusSpeed;           /* actual bus speed/link rate in MHz */
> > > > +     u8      MaxRRCDrives;           /* max. number of ITP-RRC drives/pool */
> > > > +     u8      MaxDiskXtasks;          /* max. possible num of DiskX Tasks */
> > > > +
> > > > +     u8      CpldVerLoaded;
> > > > +     u8      CpldVerInFlash;
> > > > +
> > > > +     __le64  MaxRRCCapacity;
> > > > +     __le32  CompiledMaxHistLogLevel;
> > > > +     u8      CustomBoardName[12];
> > > > +     u16     SupportedCntlrMode;     /* identify supported controller mode
> > */
> > > > +     u16     ReservedForFuture16;
> > > > +     __le32  SupportedOptions3;      /* reserved for future options */
> > > > +
> > > > +     __le16  VirtDeviceBus;          /* virt. SCSI device for Thor */
> > > > +     __le16  VirtDeviceTarget;
> > > > +     __le16  VirtDeviceLUN;
> > > > +     __le16  Unused;
> > > > +     __le32  ReservedForFutureGrowth[68];
> > > > +
> > 
> > Same here.
> 
> On second thought changing all of the variables here will open up 
> Pandoras  box. I will leave them as it is for now  and change the whole
>  structure and anything attached it in one of my next patch submission series.
> 
> Will that be ok?

Yes that's something I can live with, *iff* it really happens.

Thanks,
	Johannes

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850