From: Xo Wang <xow@google.com>
To: openbmc@lists.ozlabs.org
Subject: [PATCH linux v2] arm: aspeed: zaius: Disable LPC reset for UART1
Date: Fri, 27 Jan 2017 15:23:07 -0800 [thread overview]
Message-ID: <20170127232307.110483-1-xow@google.com> (raw)
Currently, UART1 on Zaius BMC is unusable until brought out of reset by
powering the host on. In this reset state, ttyS0 can still be opened
and UART1 silently drops bytes, which is not obviously expected
behavior.
Clear the LPC block control bit that enables LPCRST# as a reset source
for UART1.
Signed-off-by: Xo Wang <xow@google.com
---
arch/arm/mach-aspeed/aspeed.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/mach-aspeed/aspeed.c b/arch/arm/mach-aspeed/aspeed.c
index 4bd3680d742d..fa99d8bde5e0 100644
--- a/arch/arm/mach-aspeed/aspeed.c
+++ b/arch/arm/mach-aspeed/aspeed.c
@@ -185,6 +185,13 @@ static void __init do_zaius_setup(void)
/* Set SPI1 CE0 decoding window to 0x30000000 */
writel(0x68600000, AST_IO(AST_BASE_SPI | 0x30));
+
+ /* Disable LPC reset for UART1, otherwise held in reset by LPCRST#,
+ * silently dropping bytes until released (usually by host power on)
+ * */
+ reg = readl(AST_IO(AST_BASE_LPC | 0x98));
+ /* Clear "Enable UART1 reset source from LPC" */
+ writel(reg & ~BIT(4), AST_IO(AST_BASE_LPC | 0x98));
}
static void __init do_witherspoon_setup(void)
--
2.11.0.483.g087da7b7c-goog
next reply other threads:[~2017-01-27 23:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 23:23 Xo Wang [this message]
2017-01-27 23:32 ` [PATCH linux v2] arm: aspeed: zaius: Disable LPC reset for UART1 Rick Altherr
2017-01-28 8:00 ` Andrew Jeffery
2017-01-31 22:23 ` Xo Wang
2017-01-31 22:24 ` Rick Altherr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170127232307.110483-1-xow@google.com \
--to=xow@google.com \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.