All of lore.kernel.org
 help / color / mirror / Atom feed
From: peter.senna@collabora.com (Peter Senna Tschudin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge
Date: Sat, 28 Jan 2017 15:16:46 +0100	[thread overview]
Message-ID: <20170128141646.GA21291@collabora.com> (raw)
In-Reply-To: <759f96e2-43da-45ba-cf8d-55bc1f6e8442@codeaurora.org>

On Thu, Jan 05, 2017 at 01:18:47PM +0530, Archit Taneja wrote:
Hi Archit,

Thank you for the comments!

[...]
> > +	total_size = (block[EDID_EXT_BLOCK_CNT] + 1) * EDID_LENGTH;
> > +	if (total_size > EDID_LENGTH) {
> > +		kfree(block);
> > +		block = kmalloc(total_size, GFP_KERNEL);
> > +		if (!block)
> > +			return NULL;
> > +
> > +		/* Yes, read the entire buffer, and do not skip the first
> > +		 * EDID_LENGTH bytes.
> > +		 */
> 
> Is this the reason why you aren't using drm_do_get_edid()?

Yes, for some hw specific reason, it is necessary to read the entire
EDID buffer starting from 0, not block by block.

[...]

I fixed all your other suggestions. Thank you!

WARNING: multiple messages have this Message-ID (diff)
From: Peter Senna Tschudin <peter.senna@collabora.com>
To: Archit Taneja <architt@codeaurora.org>
Cc: mark.rutland@arm.com, heiko@sntech.de, airlied@linux.ie,
	daniel.vetter@ffwll.ch, peter.senna@gmail.com,
	dri-devel@lists.freedesktop.org, tiwai@suse.com,
	thierry.reding@gmail.com, ykk@rock-chips.com, jslaby@suse.cz,
	martyn.welch@collabora.co.uk, Rob Herring <robh@kernel.org>,
	mchehab@osg.samsung.com, linux@armlinux.org.uk,
	javier@dowhile0.org, treding@nvidia.com, linux@roeck-us.net,
	martin.donnelly@ge.com, devicetree@vger.kernel.org,
	p.zabel@pengutronix.de, pawel.moll@arm.com,
	ijc+devicetree@hellion.org.uk, eballetbo@gmail.com,
	Fabio Estevam <fabio.estevam@nxp.com>,
	rmk+kernel@armlinux.org.uk, robh+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de,
	galak@codeaurora.org, enric.balletbo@collabora.com,
	akpm@linux-foundation.org, shawnguo@kernel.org,
	davem@davemloft.net
Subject: Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge
Date: Sat, 28 Jan 2017 15:16:46 +0100	[thread overview]
Message-ID: <20170128141646.GA21291@collabora.com> (raw)
In-Reply-To: <759f96e2-43da-45ba-cf8d-55bc1f6e8442@codeaurora.org>

On Thu, Jan 05, 2017 at 01:18:47PM +0530, Archit Taneja wrote:
Hi Archit,

Thank you for the comments!

[...]
> > +	total_size = (block[EDID_EXT_BLOCK_CNT] + 1) * EDID_LENGTH;
> > +	if (total_size > EDID_LENGTH) {
> > +		kfree(block);
> > +		block = kmalloc(total_size, GFP_KERNEL);
> > +		if (!block)
> > +			return NULL;
> > +
> > +		/* Yes, read the entire buffer, and do not skip the first
> > +		 * EDID_LENGTH bytes.
> > +		 */
> 
> Is this the reason why you aren't using drm_do_get_edid()?

Yes, for some hw specific reason, it is necessary to read the entire
EDID buffer starting from 0, not block by block.

[...]

I fixed all your other suggestions. Thank you!

WARNING: multiple messages have this Message-ID (diff)
From: Peter Senna Tschudin <peter.senna@collabora.com>
To: Archit Taneja <architt@codeaurora.org>
Cc: airlied@linux.ie, akpm@linux-foundation.org,
	daniel.vetter@ffwll.ch, davem@davemloft.net,
	devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	enric.balletbo@collabora.com, eballetbo@gmail.com,
	galak@codeaurora.org, gregkh@linuxfoundation.org,
	heiko@sntech.de, ijc+devicetree@hellion.org.uk,
	javier@dowhile0.org, jslaby@suse.cz, kernel@pengutronix.de,
	linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk,
	linux-kernel@vger.kernel.org, linux@roeck-us.net,
	mark.rutland@arm.com, martin.donnelly@ge.com,
	martyn.welch@collabora.co.uk, mchehab@osg.samsung.com,
	pawel.moll@arm.com, peter.senna@gmail.com,
	p.zabel@pengutronix.de, thierry.reding@gmail.com,
	rmk+kernel@armlinux.org.uk, robh+dt@kernel.org,
	shawnguo@kernel.org, tiwai@suse.com, treding@nvidia.com,
	ykk@rock-chips.com, Rob Herring <robh@kernel.org>,
	Fabio Estevam <fabio.estevam@nxp.com>
Subject: Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge
Date: Sat, 28 Jan 2017 15:16:46 +0100	[thread overview]
Message-ID: <20170128141646.GA21291@collabora.com> (raw)
In-Reply-To: <759f96e2-43da-45ba-cf8d-55bc1f6e8442@codeaurora.org>

On Thu, Jan 05, 2017 at 01:18:47PM +0530, Archit Taneja wrote:
Hi Archit,

Thank you for the comments!

[...]
> > +	total_size = (block[EDID_EXT_BLOCK_CNT] + 1) * EDID_LENGTH;
> > +	if (total_size > EDID_LENGTH) {
> > +		kfree(block);
> > +		block = kmalloc(total_size, GFP_KERNEL);
> > +		if (!block)
> > +			return NULL;
> > +
> > +		/* Yes, read the entire buffer, and do not skip the first
> > +		 * EDID_LENGTH bytes.
> > +		 */
> 
> Is this the reason why you aren't using drm_do_get_edid()?

Yes, for some hw specific reason, it is necessary to read the entire
EDID buffer starting from 0, not block by block.

[...]

I fixed all your other suggestions. Thank you!

  reply	other threads:[~2017-01-28 14:16 UTC|newest]

Thread overview: 97+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-01 20:24 [PATCH V7 0/4] Add driver for GE B850v3 LVDS/DP++ Bridge Peter Senna Tschudin
2017-01-01 20:24 ` Peter Senna Tschudin
2017-01-01 20:24 ` Peter Senna Tschudin
2017-01-01 20:24 ` [PATCH V7 1/4] Documentation/devicetree/bindings: b850v3_lvds_dp Peter Senna Tschudin
2017-01-01 20:24   ` Peter Senna Tschudin
2017-01-01 20:24   ` Peter Senna Tschudin
2017-01-03 22:51   ` Rob Herring
2017-01-03 22:51     ` Rob Herring
2017-01-03 22:51     ` Rob Herring
2017-01-03 23:34     ` Peter Senna Tschudin
2017-01-03 23:34       ` Peter Senna Tschudin
2017-01-03 23:34       ` Peter Senna Tschudin
2017-01-04 20:39       ` Rob Herring
2017-01-04 20:39         ` Rob Herring
2017-01-04 20:39         ` Rob Herring
2017-01-07  1:29         ` Peter Senna Tschudin
2017-01-07  1:29           ` Peter Senna Tschudin
2017-01-07  1:29           ` Peter Senna Tschudin
2017-01-10 21:04           ` Laurent Pinchart
2017-01-10 21:04             ` Laurent Pinchart
2017-01-10 21:04             ` Laurent Pinchart
2017-01-16  8:37             ` Peter Senna Tschudin
2017-01-16  8:37               ` Peter Senna Tschudin
2017-01-16  8:37               ` Peter Senna Tschudin
2017-01-18 21:10               ` Laurent Pinchart
2017-01-18 21:10                 ` Laurent Pinchart
2017-01-18 21:10                 ` Laurent Pinchart
2017-01-19  8:12                 ` Peter Senna Tschudin
2017-01-19  8:12                   ` Peter Senna Tschudin
2017-01-19  8:12                   ` Peter Senna Tschudin
2017-01-19  8:17                   ` Laurent Pinchart
2017-01-19  8:17                     ` Laurent Pinchart
2017-01-19  8:17                     ` Laurent Pinchart
2017-01-19  9:25                     ` Peter Senna Tschudin
2017-01-19  9:25                       ` Peter Senna Tschudin
2017-01-19  9:25                       ` Peter Senna Tschudin
2017-01-19 11:49                       ` Laurent Pinchart
2017-01-19 11:49                         ` Laurent Pinchart
2017-01-19 11:49                         ` Laurent Pinchart
2017-01-10 21:06   ` Laurent Pinchart
2017-01-10 21:06     ` Laurent Pinchart
2017-01-10 21:06     ` Laurent Pinchart
2017-01-01 20:24 ` [PATCH V7 2/4] MAINTAINERS: Add entry for GE B850v3 LVDS/DP++ Bridge Peter Senna Tschudin
2017-01-01 20:24   ` Peter Senna Tschudin
2017-01-01 20:24   ` Peter Senna Tschudin
2017-01-01 20:24 ` [PATCH V7 3/4] drm/bridge: Add driver " Peter Senna Tschudin
2017-01-01 20:24   ` Peter Senna Tschudin
2017-01-01 20:24   ` Peter Senna Tschudin
2017-01-02 11:26   ` Peter Senna Tschudin
2017-01-02 11:26     ` Peter Senna Tschudin
2017-01-02 11:26     ` Peter Senna Tschudin
2017-01-05  7:48   ` Archit Taneja
2017-01-05  7:48     ` Archit Taneja
2017-01-05  7:48     ` Archit Taneja
2017-01-28 14:16     ` Peter Senna Tschudin [this message]
2017-01-28 14:16       ` Peter Senna Tschudin
2017-01-28 14:16       ` Peter Senna Tschudin
2017-01-30 17:05       ` Jani Nikula
2017-01-30 17:05         ` Jani Nikula
2017-01-30 17:05         ` Jani Nikula
2017-02-01  9:44         ` Archit Taneja
2017-02-01  9:44           ` Archit Taneja
2017-02-01  9:44           ` Archit Taneja
2017-02-01 10:58           ` Peter Senna Tschudin
2017-02-01 10:58             ` Peter Senna Tschudin
2017-02-01 10:58             ` Peter Senna Tschudin
2017-02-01 11:35             ` Daniel Vetter
2017-02-01 11:35               ` Daniel Vetter
2017-02-01 11:35               ` Daniel Vetter
2017-02-01 12:21               ` Peter Senna Tschudin
2017-02-01 12:21                 ` Peter Senna Tschudin
2017-02-01 12:21                 ` Peter Senna Tschudin
2017-02-02  9:56                 ` Archit Taneja
2017-02-02  9:56                   ` Archit Taneja
2017-02-02  9:56                   ` Archit Taneja
2017-02-02  1:46               ` Emil Velikov
2017-02-02  1:46               ` Emil Velikov
2017-02-02  1:46                 ` Emil Velikov
2017-02-02  1:46                 ` Emil Velikov
2017-02-02 11:53                 ` Peter Senna Tschudin
2017-02-02 11:53                   ` Peter Senna Tschudin
2017-02-02 11:53                   ` Peter Senna Tschudin
2017-02-02 12:37                   ` Emil Velikov
2017-02-02 12:37                     ` Emil Velikov
2017-02-02 12:37                     ` Emil Velikov
2017-02-03  8:00                     ` Daniel Vetter
2017-02-03  8:00                       ` Daniel Vetter
2017-02-03  8:00                       ` Daniel Vetter
2017-02-03 12:25                       ` Emil Velikov
2017-02-03 12:25                         ` Emil Velikov
2017-02-03 12:25                         ` Emil Velikov
2017-02-06  8:45                         ` Daniel Vetter
2017-02-06  8:45                           ` Daniel Vetter
2017-02-06  8:45                           ` Daniel Vetter
2017-01-01 20:24 ` [PATCH V7 4/4] dts/imx6q-b850v3: Use " Peter Senna Tschudin
2017-01-01 20:24   ` Peter Senna Tschudin
2017-01-01 20:24   ` Peter Senna Tschudin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170128141646.GA21291@collabora.com \
    --to=peter.senna@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.