From: Thierry Reding <thierry.reding@gmail.com>
To: Shailendra Verma <shailendra.v@samsung.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Alexandre Courbot <gnurou@gmail.com>,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
p.shailesh@samsung.com, ashish.kalra@samsung.com,
Shailendra Verma <shailendra.capricorn@gmail.com>
Subject: Re: [PATCH] pwm - Fix possible NULL derefrence.
Date: Mon, 30 Jan 2017 08:10:20 +0100 [thread overview]
Message-ID: <20170130071020.GE3585@ulmo.ba.sec> (raw)
In-Reply-To: <1485751953-29341-1-git-send-email-shailendra.v@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 453 bytes --]
On Mon, Jan 30, 2017 at 10:22:33AM +0530, Shailendra Verma wrote:
> of_match_device could return NULL, and so can cause a NULL
> pointer dereference later.
>
> Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>
> ---
> drivers/pwm/pwm-sun4i.c | 4 ++++
> drivers/pwm/pwm-tegra.c | 5 +++++
> 2 files changed, 9 insertions(+)
Both of these drivers will only run on purely OF systems, so this check
is unnecessary.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pwm - Fix possible NULL derefrence.
Date: Mon, 30 Jan 2017 08:10:20 +0100 [thread overview]
Message-ID: <20170130071020.GE3585@ulmo.ba.sec> (raw)
In-Reply-To: <1485751953-29341-1-git-send-email-shailendra.v@samsung.com>
On Mon, Jan 30, 2017 at 10:22:33AM +0530, Shailendra Verma wrote:
> of_match_device could return NULL, and so can cause a NULL
> pointer dereference later.
>
> Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>
> ---
> drivers/pwm/pwm-sun4i.c | 4 ++++
> drivers/pwm/pwm-tegra.c | 5 +++++
> 2 files changed, 9 insertions(+)
Both of these drivers will only run on purely OF systems, so this check
is unnecessary.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170130/cf76abbe/attachment.sig>
next prev parent reply other threads:[~2017-01-30 7:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170130045241epcas1p2a5a0625327e4caab59236ec85551f95e@epcas1p2.samsung.com>
2017-01-30 4:52 ` [PATCH] pwm - Fix possible NULL derefrence Shailendra Verma
2017-01-30 4:52 ` Shailendra Verma
2017-01-30 7:10 ` Thierry Reding [this message]
2017-01-30 7:10 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130071020.GE3585@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=ashish.kalra@samsung.com \
--cc=gnurou@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=p.shailesh@samsung.com \
--cc=shailendra.capricorn@gmail.com \
--cc=shailendra.v@samsung.com \
--cc=swarren@wwwdotorg.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.